From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBA7FC433FE for ; Thu, 2 Dec 2021 00:03:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354089AbhLBAG3 (ORCPT ); Wed, 1 Dec 2021 19:06:29 -0500 Received: from esa5.hgst.iphmx.com ([216.71.153.144]:65140 "EHLO esa5.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353994AbhLBAG0 (ORCPT ); Wed, 1 Dec 2021 19:06:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1638403383; x=1669939383; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=dnRwlM2g208wpzcQ1fHoMh5ABTusv5pFo5cTKx90whg=; b=QlM3Z7K8vAy/wVLJov+zpBdtLpdod8iR17myhXI/dZ5aOqljwmzrNAVD mear1UarNBnB3SueOtSw/8gmt0Bf+IlLNxITx0DjZdPACZWSQIjfRb1tN nXLBlJ/i85tpx+FM2l4/mnqLtpL/tgZpw2Fs0b9wkSimoR7btkA96wqwS r9B3eWiOSCxyE8apa/i7/94cMiTL3l0uA9+Ptl9krMxznfgvGxmL4qQmW ZPZMKE4XeTkk4BOKTDBnbrrAk9k3rMSxrO5C8JuExV6PkhKWMJND4Tg9b Hg8y92dUxA8sQu2VMJpFFxayklw1OgCWSmQHPyEch5tCp4YDTY0zHzxul A==; X-IronPort-AV: E=Sophos;i="5.87,280,1631548800"; d="scan'208";a="187234991" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 02 Dec 2021 07:58:14 +0800 IronPort-SDR: GmZ6ICH7s+bqQrVfb2HwWcQm069mJ5H3pp8YLEhsh/xbG3AGia8NM+Boy4bEF30k1oEgzTWK1X NNL+U1KfU06gJGluXna8K87AR76yrvCOWv5oR6BqJziVhRgj4XNYd5WSpV3U0+sssgpp9Oamyd RiUAAX2fXkM814jTeVvWm5W6TrxSr/u3CmDQmvK+ur1B1lmO/S1oRL1n/EwCqpmiwsev7M1crj GsLekprHGPwQRYKY+AhbPSU1ZEXvtze4GFbiFEXZitlJjykC8gDZoxmAaxUf3gQZuTmaruWYE2 zP/Oh5yKm2NKkOmDZ9EHAk3b Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2021 15:32:57 -0800 IronPort-SDR: w0s330atjYNIgL5vMvgSE/XjL6D4TjgHBvnGzKsFLED2YR4P1CxGaDnjXTT2dY1Q/0bct5xdoM BI8PQVXgFoY+Uo95hWa6B4LFEYEwrK4TEOINbKR7J7GKLvf+rDsyp3MVRJV7qzJn0Sn1EqRaCF 0Ay/zPcIJJTZW31f3EHDjVHCyqPuj2SK2RySzydMlt7JBvhDsCQn/DppgcsnM5pPiRStflgA8a 3QR7qzTW4THhBXxkNc+pVLdtE5P38NcPY2B05HFlb1OWa93QZ+tJI2m50sOMAqHME2P08f7Xqg pR8= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2021 15:58:14 -0800 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4J4GHm5fbHz1RtVp for ; Wed, 1 Dec 2021 15:58:12 -0800 (PST) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1638403091; x=1640995092; bh=dnRwlM2g208wpzcQ1fHoMh5ABTusv5pFo5c TKx90whg=; b=Smg8tZ+TvJgoqFK7osdFry7pC21BK7S3yr15mJQjwB/VT9nSMYr 7iIvDU9l8vFruHz8R0A0SVuly46XttI5hP7+kfC5nbW0dAzvHaZXyz4ZDsmfd3qB D0Ph8lgqh06/wHt+lro2VpDTfjRFCGMvRHXyhklU38zB6iPfugAApaDMw29xaH6x Pocm/LRy1wZ1rAlLDlzn9u7axyibnyRJDEalhSezz+2Wqhp77ULG7HlRPACEG+Q7 fSVIANXzSmOc7Dv7ZW8aIyMLJPlNNQjybxvXCKMmPtm/7CIV298EqCCQ+BEWWo6h LcJe0ZNh1pNmkNb9fwaGI9bsqmnIs91czqw== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Lu2ACb02C0cg for ; Wed, 1 Dec 2021 15:58:11 -0800 (PST) Received: from [10.225.54.48] (unknown [10.225.54.48]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4J4GHc4pQzz1RtVl; Wed, 1 Dec 2021 15:58:04 -0800 (PST) Message-ID: <0cbaad0b-bab0-177e-48ef-5c4f6dd4391a@opensource.wdc.com> Date: Thu, 2 Dec 2021 08:58:03 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH 12/14] dt-bindings: ata: Convert Broadcom SATA to YAML Content-Language: en-US To: Florian Fainelli , devicetree@vger.kernel.org Cc: Rob Herring , Linus Walleij , Bartosz Golaszewski , "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" , Gregory Fong , Thomas Gleixner , Marc Zyngier , Ulf Hansson , Thierry Reding , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Lee Jones , Philipp Zabel , Matt Mackall , Herbert Xu , Ray Jui , Scott Branden , Alessandro Zummo , Alexandre Belloni , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Markus Mayer , Greg Kroah-Hartman , Al Cooper , Doug Berger , "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" , open list , "open list:GPIO SUBSYSTEM" , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" , "open list:MULTIMEDIA CARD (MMC), SECURE DIGITAL (SD) AND..." , "open list:PWM SUBSYSTEM" , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" , "open list:THERMAL" , "open list:USB SUBSYSTEM" References: <20211201205110.41656-1-f.fainelli@gmail.com> <20211201205110.41656-13-f.fainelli@gmail.com> From: Damien Le Moal Organization: Western Digital In-Reply-To: <20211201205110.41656-13-f.fainelli@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 2021/12/02 5:51, Florian Fainelli wrote: > Convert the Broadcom SATA3 AHCI controller Device Tree binding to YAML > to help with validation. > > Signed-off-by: Florian Fainelli > --- > .../bindings/ata/brcm,sata-brcm.txt | 45 --------- > .../bindings/ata/brcm,sata-brcm.yaml | 91 +++++++++++++++++++ > 2 files changed, 91 insertions(+), 45 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/ata/brcm,sata-brcm.txt > create mode 100644 Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml > > diff --git a/Documentation/devicetree/bindings/ata/brcm,sata-brcm.txt b/Documentation/devicetree/bindings/ata/brcm,sata-brcm.txt > deleted file mode 100644 > index b9ae4ce4a0a0..000000000000 > --- a/Documentation/devicetree/bindings/ata/brcm,sata-brcm.txt > +++ /dev/null > @@ -1,45 +0,0 @@ > -* Broadcom SATA3 AHCI Controller > - > -SATA nodes are defined to describe on-chip Serial ATA controllers. > -Each SATA controller should have its own node. > - > -Required properties: > -- compatible : should be one or more of > - "brcm,bcm7216-ahci" > - "brcm,bcm7425-ahci" > - "brcm,bcm7445-ahci" > - "brcm,bcm-nsp-ahci" > - "brcm,sata3-ahci" > - "brcm,bcm63138-ahci" > -- reg : register mappings for AHCI and SATA_TOP_CTRL > -- reg-names : "ahci" and "top-ctrl" > -- interrupts : interrupt mapping for SATA IRQ > - > -Optional properties: > - > -- reset: for "brcm,bcm7216-ahci" must be a valid reset phandle > - pointing to the RESCAL reset controller provider node. > -- reset-names: for "brcm,bcm7216-ahci", must be "rescal". > - > -Also see ahci-platform.txt. > - > -Example: > - > - sata@f045a000 { > - compatible = "brcm,bcm7445-ahci", "brcm,sata3-ahci"; > - reg = <0xf045a000 0xa9c>, <0xf0458040 0x24>; > - reg-names = "ahci", "top-ctrl"; > - interrupts = <0 30 0>; > - #address-cells = <1>; > - #size-cells = <0>; > - > - sata0: sata-port@0 { > - reg = <0>; > - phys = <&sata_phy 0>; > - }; > - > - sata1: sata-port@1 { > - reg = <1>; > - phys = <&sata_phy 1>; > - }; > - }; > diff --git a/Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml b/Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml > new file mode 100644 > index 000000000000..4098d56872ae > --- /dev/null > +++ b/Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml > @@ -0,0 +1,91 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/ata/brcm,sata-brcm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Broadcom SATA3 AHCI Controller > + > +description: > + SATA nodes are defined to describe on-chip Serial ATA controllers. > + Each SATA controller should have its own node. > + > +maintainers: > + - Florian Fainelli > + > +allOf: > + - $ref: sata-common.yaml# > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - brcm,bcm7216-ahci > + - const: brcm,sata3-ahci > + - items: > + - enum: > + - brcm,bcm7445-ahci > + - const: brcm,sata3-ahci > + - items: > + - enum: > + - brcm,bcm7425-ahci > + - const: brcm,sata3-ahci > + - items: > + - const: brcm,bcm-nsp-ahci > + - items: > + - const: brcm,bcm63138-ahci > + > + reg: > + minItems: 2 > + maxItems: 2 > + > + reg-names: > + items: > + - const: ahci > + - const: top-ctrl > + > + interrupts: true > + > +if: > + properties: > + compatible: > + contains: > + enum: > + - brcm,bcm7216-ahci > +then: > + properties: > + resets: true > + reset-names: > + items: > + - const: rescal > + > +required: > + - compatible > + - reg > + - interrupts > + - "#address-cells" > + - "#size-cells" > + > +unevaluatedProperties: false > + > +examples: > + - | > + sata@f045a000 { > + compatible = "brcm,bcm7445-ahci", "brcm,sata3-ahci"; > + reg = <0xf045a000 0xa9c>, <0xf0458040 0x24>; > + reg-names = "ahci", "top-ctrl"; > + interrupts = <0 30 0>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + sata0: sata-port@0 { > + reg = <0>; > + phys = <&sata_phy 0>; > + }; > + > + sata1: sata-port@1 { > + reg = <1>; > + phys = <&sata_phy 1>; > + }; > + }; > Acked-by: Damien Le Moal Rob, Will take this through your tree ? -- Damien Le Moal Western Digital Research