From: Jens Axboe <axboe@kernel.dk>
To: Tejun Heo <tj@kernel.org>
Cc: linux-ide@vger.kernel.org, Hannes Reinecke <hare@kernel.org>,
kernel-team@fb.com
Subject: Re: [PATCH] libata: don't request sense data on !ZAC ATA devices
Date: Tue, 25 Jun 2019 09:35:04 -0600 [thread overview]
Message-ID: <0d864165-79be-ea02-59ba-3a3d00bdfaf2@kernel.dk> (raw)
In-Reply-To: <20190624163250.GP657710@devbig004.ftw2.facebook.com>
On 6/24/19 10:32 AM, Tejun Heo wrote:
> ZAC support added sense data requesting on error for both ZAC and ATA
> devices. This seems to cause erratic error handling behaviors on some
> SSDs where the device reports sense data availability and then
> delivers the wrong content making EH take the wrong actions. The
> failure mode was sporadic on a LITE-ON ssd and couldn't be reliably
> reproduced.
>
> There is no value in requesting sense data from non-ZAC ATA devices
> while there's a significant risk of introducing EH misbehaviors which
> are difficult to reproduce and fix. Let's do the sense data dancing
> only for ZAC devices.
Applied, thanks Tejun.
--
Jens Axboe
prev parent reply other threads:[~2019-06-25 15:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 16:32 [PATCH] libata: don't request sense data on !ZAC ATA devices Tejun Heo
2019-06-24 20:27 ` Damien Le Moal
2019-06-24 20:57 ` Tejun Heo
2019-06-24 21:59 ` Damien Le Moal
2019-06-25 6:05 ` Hannes Reinecke
2019-06-25 12:25 ` Damien Le Moal
2019-06-25 15:35 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d864165-79be-ea02-59ba-3a3d00bdfaf2@kernel.dk \
--to=axboe@kernel.dk \
--cc=hare@kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).