From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Jiri Slaby <jslaby@suse.cz>, axboe@kernel.dk
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [RFC 3/3] ata: sata_mv, avoid trigerrable BUG_ON
Date: Fri, 14 Jun 2019 11:24:46 +0300 [thread overview]
Message-ID: <0e9f8a3b-65b9-4d87-21f1-684f7e44b166@cogentembedded.com> (raw)
In-Reply-To: <20190614071140.6233-3-jslaby@suse.cz>
Hello!
On 14.06.2019 10:11, Jiri Slaby wrote:
> There are several reports that the BUG_ON on unsupported command in
> mv_qc_prep can be triggered under some circumstances:
> https://bugzilla.suse.com/show_bug.cgi?id=1110252
> https://serverfault.com/questions/888897/raid-problems-after-power-outage
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1652185
> https://bugs.centos.org/view.php?id=14998
>
> Let sata_mv handle the failure gracefully: warn about that incl. the
> failed command number and return an AC_ERR_INVALID error. We can do that
> now thanks to the previous patch.
>
> Remove also the long-standing FIXME.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: linux-ide@vger.kernel.org
> ---
> drivers/ata/sata_mv.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
> index d6aac7b31c45..144fa0982168 100644
> --- a/drivers/ata/sata_mv.c
> +++ b/drivers/ata/sata_mv.c
> @@ -2098,12 +2098,10 @@ static int mv_qc_prep(struct ata_queued_cmd *qc)
> * non-NCQ mode are: [RW] STREAM DMA and W DMA FUA EXT, none
> * of which are defined/used by Linux. If we get here, this
> * driver needs work.
> - *
> - * FIXME: modify libata to give qc_prep a return value and
> - * return error here.
> */
> - BUG_ON(tf->command);
> - break;
> + ata_port_err(ap, "%s: unsupported command: %d\n", __func__,
> + tf->command);
I'd use "%x" here instead of "%d".
> + return AC_ERR_INVALID;
> }
> mv_crqb_pack_cmd(cw++, tf->nsect, ATA_REG_NSECT, 0);
> mv_crqb_pack_cmd(cw++, tf->hob_lbal, ATA_REG_LBAL, 0);
MBR, Sergei
next prev parent reply other threads:[~2019-06-14 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 7:11 [RFC 1/3] ata: Documentation, fix function names Jiri Slaby
2019-06-14 7:11 ` [RFC 2/3] ata: make qc_prep return an int Jiri Slaby
2019-06-14 7:11 ` [RFC 3/3] ata: sata_mv, avoid trigerrable BUG_ON Jiri Slaby
2019-06-14 8:24 ` Sergei Shtylyov [this message]
2019-06-14 8:33 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e9f8a3b-65b9-4d87-21f1-684f7e44b166@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=axboe@kernel.dk \
--cc=jslaby@suse.cz \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).