From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: add horkage for missing Identify Device log
Date: Wed, 10 Nov 2021 15:17:31 +0900 [thread overview]
Message-ID: <1030065c-1ec2-991e-10a0-c01231b9b664@opensource.wdc.com> (raw)
In-Reply-To: <YYo3N/dwJmOxCBHE@infradead.org>
On 2021/11/09 17:54, Christoph Hellwig wrote:
> On Tue, Nov 09, 2021 at 08:57:23AM +0900, Damien Le Moal wrote:
>> ACS defines the ATA Identify Device Data log as mandatory. A warning
>> message currently signals to the user if a device does not report
>> supporting this log page in the log directory page. However, it is
>> useless to constantly access the log directory and warn about this lack
>> of support once we have discovered that the device does not support
>> this mandatory log page.
>>
>> Introduce the horkage flag ATA_HORKAGE_NO_ID_DEV_LOG to mark a device as
>> lacking support for the Identify Device Data log page. Set this flag
>> when ata_log_supported() returns false in ata_identify_page_supported().
>> The warning is printed only once on device scan and the log directory
>> not accessed again to test for Identify Device Data log page support.
>
> Should we also just set it by default for older devices? I'd need to
> look up when it was introduced, but I think it is a somewhat recent
> addition.
It is marked as mandatory at least since ACS-3.
Need to check before that. Will do.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2021-11-10 6:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 23:57 [PATCH] libata: add horkage for missing Identify Device log Damien Le Moal
2021-11-09 8:54 ` Christoph Hellwig
2021-11-10 6:17 ` Damien Le Moal [this message]
2021-11-10 7:53 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1030065c-1ec2-991e-10a0-c01231b9b664@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=hch@infradead.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).