From: John Garry <john.garry@huawei.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: Jens Axboe <axboe@kernel.dk>,
"open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)"
<linux-ide@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] libata: Use per port sync for detach
Date: Mon, 18 May 2020 16:21:18 +0100 [thread overview]
Message-ID: <1470d3de-7785-9f05-2b12-9272ac0005b8@huawei.com> (raw)
In-Reply-To: <91334913-eac8-c8e0-ced6-f1bb8d8b2507@huawei.com>
On 18/05/2020 10:06, John Garry wrote:
> On 15/05/2020 18:48, Kai-Heng Feng wrote:
>>> 841] ret_from_fork+0x10/0x1c
>>> [ 28.393400] ---[ end trace 9972785c7052048f ]---
>>> [ 28.435826] ahci 0000:b4:03.0: SSS flag set, parallel bus scan
>>> disabled
>> Can you please test the following patch:
>>
>> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
>> index 474c6c34fe02..51ee0cc4d414 100644
>> --- a/drivers/ata/libata-eh.c
>> +++ b/drivers/ata/libata-eh.c
>> @@ -3583,8 +3583,10 @@ int ata_eh_recover(struct ata_port *ap,
>> ata_prereset_fn_t prereset,
>> rc = 0;
>> /* if UNLOADING, finish immediately */
>> - if (ap->pflags & ATA_PFLAG_UNLOADING)
>> + if (ap->pflags & ATA_PFLAG_UNLOADING) {
>> + ap->pflags |= ATA_PFLAG_UNLOADED;
>> goto out;
>> + }
>>
>> It's only compile-tested, many drivers panic with
>> CONFIG_DEBUG_TEST_DRIVER_REMOVE enabled, so the system I have can't
>> even boot properly:(
>
According to the comment for async_synchronize_cookie(), we sync upto
(but excluding) the cookie:
/**
* async_synchronize_cookie - synchronize asynchronous function calls
with cookie checkpointing
*
* This function waits until all asynchronous function calls prior to
@cookie
* have been done.
So maybe it should be:
+ for (i = 0; i < host->n_ports; i++)
+ async_synchronize_cookie(host->ports[i]->cookie + 1);
That is how other callsites use this API, and that change resolves the
WARN for me.
Thanks,
John
next prev parent reply other threads:[~2020-05-18 15:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 11:09 [PATCH] libata: Use per port sync for detach Kai-Heng Feng
2020-05-15 12:38 ` John Garry
2020-05-15 17:48 ` Kai-Heng Feng
2020-05-18 9:06 ` John Garry
2020-05-18 15:21 ` John Garry [this message]
2020-05-19 6:09 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470d3de-7785-9f05-2b12-9272ac0005b8@huawei.com \
--to=john.garry@huawei.com \
--cc=axboe@kernel.dk \
--cc=kai.heng.feng@canonical.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).