From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D769C433DF for ; Mon, 22 Jun 2020 09:03:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C5AE206D7 for ; Mon, 22 Jun 2020 09:03:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592816629; bh=dfPq2bWzwrh5d/nPvytI9Z/3m/amVEV2Rcw1LlZyQmc=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=yE2LlBF3G/whkEIzDIMEOzhgi+pmTiUHrA5FOSXxG4vG1QX3CPjOlIhIr2w2c6s8S ynPkmdUEqsQy4KfzTJfsgUulE6A+nRxc8+2hMiCQa7DywgTdR9lHprYFOmiOlv2VbC 9HiAaylB7+omNfypoL3ylmEi+zjlXJMaf/dafYqo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726511AbgFVJDn (ORCPT ); Mon, 22 Jun 2020 05:03:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:40434 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725907AbgFVJDm (ORCPT ); Mon, 22 Jun 2020 05:03:42 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C351B206D7; Mon, 22 Jun 2020 09:03:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592816621; bh=dfPq2bWzwrh5d/nPvytI9Z/3m/amVEV2Rcw1LlZyQmc=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=vhvP7fE2MPNiHbfOeqUpBKYvYHUd3trLSwHmotHtfbD0VQFAa3Kwf3asD6snmMfVn 7p1K872LOY3D+lW5N2LJm3deS04WJDM10Qxgq0hfBEHc7pew9hlgtznyNjzvlDqDoI hWZw7i2g7uSA8PFpTf60IR4oph7Kn4ltUnLQO8vI= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200620033007.1444705-8-keescook@chromium.org> References: <20200620033007.1444705-1-keescook@chromium.org> <20200620033007.1444705-8-keescook@chromium.org> Subject: Re: [PATCH v2 07/16] clk: st: Remove uninitialized_var() usage From: Stephen Boyd Cc: Kees Cook , Linus Torvalds , Miguel Ojeda , Alexander Potapenko , Joe Perches , Andy Whitcroft , x86@kernel.org, drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, b43-dev@lists.infradead.org, netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-wireless@vger.kernel.org, linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, linux-spi@vger.kernel.org, linux-mm@kvack.org, clang-built-linux@googlegroups.com To: Kees Cook , linux-kernel@vger.kernel.org Date: Mon, 22 Jun 2020 02:03:41 -0700 Message-ID: <159281662109.62212.9073761737183602994@swboyd.mtv.corp.google.com> User-Agent: alot/0.9 Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Quoting Kees Cook (2020-06-19 20:29:58) > Using uninitialized_var() is dangerous as it papers over real bugs[1] > (or can in the future), and suppresses unrelated compiler warnings (e.g. > "unused variable"). If the compiler thinks it is uninitialized, either > simply initialize the variable or make compiler changes. As a precursor > to removing[2] this[3] macro[4], just remove this variable since it was > actually unused: >=20 > drivers/clk/st/clkgen-fsyn.c: In function \u2018quadfs_set_rate\u2019: > drivers/clk/st/clkgen-fsyn.c:793:6: warning: unused variable \u2018i\u201= 9 [-Wunused-variable] > 793 | int i; > | ^ >=20 > [1] https://lore.kernel.org/lkml/20200603174714.192027-1-glider@google.co= m/ > [2] https://lore.kernel.org/lkml/CA+55aFw+Vbj0i=3D1TGqCR5vQkCzWJ0QxK6Cern= OU6eedsudAixw@mail.gmail.com/ > [3] https://lore.kernel.org/lkml/CA+55aFwgbgqhbp1fkxvRKEpzyR5J8n1vKT1VZdz= 9knmPuXhOeg@mail.gmail.com/ > [4] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=3DyVJu65TpLg= N_ybYNv0VEOKA@mail.gmail.com/ >=20 > Fixes: 5f7aa9071e93 ("clk: st: Support for QUADFS inside ClockGenB/C/D/E/= F") > Signed-off-by: Kees Cook > --- Acked-by: Stephen Boyd