From: torvic9@mailbox.org
To: Hans de Goede <hdegoede@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"hpa@redhat.com" <hpa@redhat.com>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"damien.lemoal@wdc.com" <damien.lemoal@wdc.com>
Subject: Re: [PATCH v4] libata: Add ATA_HORKAGE_NO_NCQ_ON_AMD for Samsung 860 and 870 SSD.
Date: Wed, 1 Sep 2021 13:11:01 +0200 (CEST) [thread overview]
Message-ID: <1693972970.60125.1630494661286@office.mailbox.org> (raw)
In-Reply-To: <2df1c3d5-301d-dc46-7f9f-d28be2933bd3@redhat.com>
> Hans de Goede <hdegoede@redhat.com> hat am 01.09.2021 11:38 geschrieben:
>
>
> Hi,
>
> On 9/1/21 10:55 AM, Hans de Goede wrote:
> > Hi Tor,
> >
> > On 9/1/21 9:37 AM, torvic9@mailbox.org wrote:
> >> (Sorry for not doing a proper reply)
> >>
> >> Hello,
> >> Noob here.
> >> I have a Samsung 860 Pro connected to a AMD X570 chipset mainboard and
> >> it just works flawlessly on 5.13 and 5.14.
> >> Are you sure that *every* 860/870 is concerned by this problem on
> >> *every* AMD controller?
> >
> > I am pretty sure that every 860 / 870 EVO is affected,
> > I am not sure if the PRO is also affected.
>
> So while reading https://bugzilla.kernel.org/show_bug.cgi?id=201693
> again to add a comment asking if anyone was seeing this on a
> pro to I found existing comments of both queued-trims being
> an issue on the 860 pro, as well as the 860 pro having issues
> with some AMD sata controllers.
>
> So it seems safe to say that the 860 pro has the same issues
> as the 860 and 870 evo models. Chances are you don't have
> discard support enabled causing you to not see the queued-trim
> issues (which means you also won't see any difference from
> disabling support for queued-trim commands).
Thanks for your answer, Hans.
If you mean the "discard" mount option, then yes, you're correct,
I don't use this because some (apparently) knowledgeable people
recommended against using it especially on LUKS partitions.
I don't know whether that's true though, it might be outdated.
I do however do manual TRIMs with "fstrim".
>
> So this just leaves your question of:
>
> "concerned by this problem on *every* AMD controller?"
>
> Where "this problem" is needing to completely disable NCQ
> and I guess the answer is no, not every AMD controller
> is affected. Still the plan is to err on the safe side for now,
> allowing overriding this from the kernel cmdline with:
>
> libata.force=ncqamd
I agree to do it in a safe way, that sounds like a good solution.
>
> I will add a comment to:
>
> https://bugzilla.kernel.org/show_bug.cgi?id=201693
>
> Asking for PCI-ids of the controllers where people are seeing
> this and then maybe we can narrow down the "AMD" check in a
> future follow up patch.
I can send you PCI and device IDs later if it helps.
>
> Regards,
>
> Hans
next prev parent reply other threads:[~2021-09-01 11:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 7:37 [PATCH v4] libata: Add ATA_HORKAGE_NO_NCQ_ON_AMD for Samsung 860 and 870 SSD torvic9
2021-09-01 8:13 ` Damien Le Moal
2021-09-01 17:56 ` Tor Vic
2021-09-01 18:58 ` Martin K. Petersen
2021-09-02 7:44 ` torvic9
2021-09-02 18:41 ` Martin K. Petersen
2021-09-01 8:55 ` Hans de Goede
2021-09-01 9:38 ` Hans de Goede
2021-09-01 11:11 ` torvic9 [this message]
2021-09-01 17:59 ` Tor Vic
-- strict thread matches above, loose matches on Subject: below --
2021-09-01 4:52 Kate Hsuan
2021-09-01 5:47 ` Damien Le Moal
2021-09-01 6:32 ` Christoph Hellwig
2021-09-01 9:01 ` Hans de Goede
2021-09-01 9:09 ` Kate Hsuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1693972970.60125.1630494661286@office.mailbox.org \
--to=torvic9@mailbox.org \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=hdegoede@redhat.com \
--cc=hpa@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).