From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
ide <linux-ide@vger.kernel.org>,
bzolnier@gmail.com
Subject: Re: [PATCH] IDE: fix PCI must_checks
Date: Thu, 5 Apr 2007 21:16:09 +0100 [thread overview]
Message-ID: <20070405211609.5263d627@the-village.bc.nu> (raw)
In-Reply-To: <20070405130330.f5f8a2a6.akpm@linux-foundation.org>
> pci_set_mwi() is an advisory thing, and on certain platforms it might fail
> to set the cacheline size to the desired number. This is not a fatal error
> and the driver can successfully run at a lesser performance level.
Correct.
> If that description is accurate then I'd contend that pci_set_mwi() is
> misdesigned. It should not be returning a negative error code for
> something which is not an error.
It is an error to *some* drivers but not all. Kind of like setting some
of the other features may be essential for some chips and not others.
> And we *need* to be excessively anal in the PCI setup code. We have metric
> shitloads of bugs due to problems in that area, and the more formality and
> error handling and error reporting we can get in there the better off we
> will be.
No argument there
If we want to deal with some of the mess we should also remove all direct
writing of PCI latency timers and replace them with a function to stop
drivers setting unsafe values and ignoring chip errata the core knows
about but they dont
next prev parent reply other threads:[~2007-04-05 20:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-05 4:37 [PATCH] IDE: fix PCI must_checks Randy Dunlap
2007-04-05 11:13 ` Alan Cox
2007-04-05 20:03 ` Andrew Morton
2007-04-05 20:16 ` Alan Cox [this message]
2007-04-05 21:20 ` Andrew Morton
2007-04-06 5:05 ` Randy Dunlap
2007-04-06 17:41 ` Alan Cox
2007-04-16 17:19 ` [RFC/PATCH -mm] add pci_try_set_mwi Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070405211609.5263d627@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).