From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00B53C47089 for ; Thu, 27 May 2021 19:10:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD7716139A for ; Thu, 27 May 2021 19:10:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232565AbhE0TLz (ORCPT ); Thu, 27 May 2021 15:11:55 -0400 Received: from mxout01.lancloud.ru ([45.84.86.81]:41790 "EHLO mxout01.lancloud.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229878AbhE0TLy (ORCPT ); Thu, 27 May 2021 15:11:54 -0400 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout01.lancloud.ru 70E4F206FFD4 Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH v2] pata_ep93xx: fix deferred probing To: Jens Axboe , Sergey Shtylyov , References: <509fda88-2e0d-2cc7-f411-695d7e94b136@omprussia.ru> <946c838b-0a9f-dfd0-70ac-a0c67c57deea@omp.ru> <934957f3-ff80-ae1d-8839-d5ffe2a952d1@kernel.dk> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: <200d3bdc-bc01-1635-ed2d-e92c0cf29787@omp.ru> Date: Thu, 27 May 2021 22:10:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <934957f3-ff80-ae1d-8839-d5ffe2a952d1@kernel.dk> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1908.lancloud.ru (fd00:f066::208) Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 5/27/21 10:03 PM, Jens Axboe wrote: [...] >>> The driver overrides the error codes returned by platform_get_irq() to >>> -ENXIO, so if it returns -EPROBE_DEFER, the driver would fail the probe >>> permanently instead of the deferred probing. Propagate the error code >>> upstream, as it should have been done from the start... >>> >>> Fixes: 2fff27512600 ("PATA host controller driver for ep93xx") >>> Signed-off-by: Sergey Shtylyov >> >> Again, 2 months has passed and no feedback whatsoever... the patch has fell >> thru the cracks? Sorry for the wrong tenses -- forgot to re-read after editing. :-) > It'd help if you sent out patches like this in a series, instead of > individual ones, when they are addressing the same issue across > multiple drivers. Makes the risk of them getting lost much smaller. That's what I try to do,. generally. Not sure how these 3 patches ended up being all on their own... :-/ > That said, I'll apply this one, thanks. Thanx! :-) MBR, Sergey