From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9106C433FF for ; Wed, 14 Aug 2019 02:20:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 873E620842 for ; Wed, 14 Aug 2019 02:20:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565749207; bh=MyHtG47uOAPOj2mNF0ndNfw6NE6cKDd6Bqu/U6pudMI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=kVvjQh44l7V8NkGNLY5/tZarbLi5v59wNQpOWD6lzx1IVFNqxQtUh6waXIh1VhgVQ FRaWM32wrSrFCps1U9142xvGvyZtd7+yd90uH2y4Pcjs/s26e/WKM7umwy81XLYJLw NJrUk34GNwmOgAh2SGm53ZY2VM7MmoOTa1zOpDYU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727608AbfHNCUC (ORCPT ); Tue, 13 Aug 2019 22:20:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:50446 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729768AbfHNCTd (ORCPT ); Tue, 13 Aug 2019 22:19:33 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BB3042084D; Wed, 14 Aug 2019 02:19:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565749173; bh=MyHtG47uOAPOj2mNF0ndNfw6NE6cKDd6Bqu/U6pudMI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G9G1MgH2A0orLAkGAunWG/7hchl4Xw8zKK+Bk7znfrhhgljIIbUP5ebr51WwzRbpb wUmAgm4CgEyetpLdhnsNbHJUocSumPvZt3s2xvK0tBwfMrEgIxnf/Fsulh6vljFwH0 R/RPQGQ4wZkwm7sWG1PZj5vUeV5Xlc0CkPEm6IW0= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jens Axboe , Kees Cook , Sasha Levin , linux-ide@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 38/44] libata: add SG safety checks in SFF pio transfers Date: Tue, 13 Aug 2019 22:18:27 -0400 Message-Id: <20190814021834.16662-38-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190814021834.16662-1-sashal@kernel.org> References: <20190814021834.16662-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org From: Jens Axboe [ Upstream commit 752ead44491e8c91e14d7079625c5916b30921c5 ] Abort processing of a command if we run out of mapped data in the SG list. This should never happen, but a previous bug caused it to be possible. Play it safe and attempt to abort nicely if we don't have more SG segments left. Reviewed-by: Kees Cook Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/ata/libata-sff.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c index cc2f2e35f4c2e..8c36ff0c2dd49 100644 --- a/drivers/ata/libata-sff.c +++ b/drivers/ata/libata-sff.c @@ -704,6 +704,10 @@ static void ata_pio_sector(struct ata_queued_cmd *qc) unsigned int offset; unsigned char *buf; + if (!qc->cursg) { + qc->curbytes = qc->nbytes; + return; + } if (qc->curbytes == qc->nbytes - qc->sect_size) ap->hsm_task_state = HSM_ST_LAST; @@ -729,6 +733,8 @@ static void ata_pio_sector(struct ata_queued_cmd *qc) if (qc->cursg_ofs == qc->cursg->length) { qc->cursg = sg_next(qc->cursg); + if (!qc->cursg) + ap->hsm_task_state = HSM_ST_LAST; qc->cursg_ofs = 0; } } -- 2.20.1