From: Thierry Reding <thierry.reding@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Jens Axboe <axboe@kernel.dk>,
Jonathan Hunter <jonathanh@nvidia.com>, JC Kuo <jckuo@nvidia.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-ide@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH 0/4] regulator: add and use a helper for setting supply names
Date: Fri, 30 Aug 2019 10:15:50 +0200 [thread overview]
Message-ID: <20190830081550.GA25502@ulmo> (raw)
In-Reply-To: <20190830071740.4267-1-brgl@bgdev.pl>
[-- Attachment #1: Type: text/plain, Size: 2315 bytes --]
On Fri, Aug 30, 2019 at 09:17:36AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> There are ~80 users of regulator bulk APIs that set the supply names
> in a for loop before using the bulk helpers.
>
> This series proposes to add a helper function for setting supply names
> and uses it in a couple tegra drivers. If accepted: a coccinelle script
> should be easy to develop that would address this in other drivers.
>
> Bartosz Golaszewski (4):
> regulator: provide regulator_bulk_set_supply_names()
> ahci: tegra: use regulator_bulk_set_supply_names()
> phy: tegra: use regulator_bulk_set_supply_names()
> usb: host: xhci-tegra: use regulator_bulk_set_supply_names()
>
> drivers/ata/ahci_tegra.c | 6 +++---
> drivers/phy/tegra/xusb.c | 6 +++---
> drivers/regulator/helpers.c | 21 +++++++++++++++++++++
> drivers/usb/host/xhci-tegra.c | 5 +++--
> include/linux/regulator/consumer.h | 12 ++++++++++++
> 5 files changed, 42 insertions(+), 8 deletions(-)
The diffstat here suggests that this isn't really helpful. Even if you
subtract the regulator code that adds the new helper, you actually have
a zero diffstat (and a positive one in one case).
Instead, why don't we take this one step further and roll a bit more of
the boilerplate into the new helper, something along these lines:
struct regulator_bulk_data *
devm_regulator_bulk_get_from_names(struct device *dev,
const char * const *supply_names,
unsigned int num_supplies)
{
struct regulator_bulk_data *data;
unsigned int i;
int err;
data = devm_kcalloc(dev, num_supplies, sizeof(*data));
if (!data)
return ERR_PTR(-ENOMEM);
for (i = 0; i < num_supplies; i++)
data[i].supply = supply_names[i];
err = devm_regulator_bulk_get(dev, num_supplies, data);
if (err < 0)
return ERR_PTR(err);
return data;
}
That seems to be still a very common pattern and gets rid of a lot more
boilerplate, so your diffstat will actually start to be negative at some
point.
I suppose one could add a non-managed variant for this as well, but I'm
counting 6 uses of regulator_bulk_get() vs. ~140 uses of the managed
variant, so I'm not sure it's worth it.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-08-30 8:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 7:17 [PATCH 0/4] regulator: add and use a helper for setting supply names Bartosz Golaszewski
2019-08-30 7:17 ` [PATCH 1/4] regulator: provide regulator_bulk_set_supply_names() Bartosz Golaszewski
2019-09-02 5:39 ` kbuild test robot
2019-09-02 7:46 ` kbuild test robot
2019-09-02 12:23 ` Applied "regulator: provide regulator_bulk_set_supply_names()" to the regulator tree Mark Brown
2019-08-30 7:17 ` [PATCH 2/4] ahci: tegra: use regulator_bulk_set_supply_names() Bartosz Golaszewski
2019-08-30 7:17 ` [PATCH 3/4] phy: " Bartosz Golaszewski
2019-08-30 7:17 ` [PATCH 4/4] usb: host: xhci-tegra: " Bartosz Golaszewski
2019-08-30 8:15 ` Thierry Reding [this message]
2019-08-30 11:06 ` [PATCH 0/4] regulator: add and use a helper for setting supply names Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830081550.GA25502@ulmo \
--to=thierry.reding@gmail.com \
--cc=axboe@kernel.dk \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jckuo@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kishon@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).