[PATCHv3 00/40] ata: kill ATA_DEBUG

[Hannes Reinecke <hare@suse.de>]

Hi all,

this is a rewrite of an earlier patchset titled
'ata: move DPRINTK to dynamic debugging'.
The overall idea is that it's really tiresome to having
to recompile the kernel every time one wants or needs
to debug ata issues, especially as the kernel already provides
mechanism for dynamic debugging messages.

At the same time dynamic debugging does increase the load on
the logging subsystem, and things like printk() are poorly
suited for high-speed logging.

So this patchset does several things:
- cleans up the logging messages by removing duplicate
  or pointless messages
- Converts I/O and error handling related messages to
  tracepoints
- Moves all remaining messages over to dynamic debugging

With that ATA_DEBUG can be killed.

Note, I'll be preparing an additional patchset for killing
off ATA_VERBOSE_DEBUG, too, but wanted to get this one out
first before it becomes too large.

As usual, comments and reviews are welcome.

Changes to v1:
- Included reviews from Bartlomiej
- Merged patches

Changes to v2:
- Included reviews from Barlomiej

Hannes Reinecke (40):
  libata: drop BPRINTK()
  libata.h: whitespace and indentation fixes
  libata-transport: Whitespace cleanup
  libata: move ata_{port,link,dev}_dbg to standard dev_XXX() macros
  libata: move __func__ into ata_{port,link,dev}_dbg() helper
  libata: remove pointless debugging messages
  ata_piix: remove debugging messages
  libata-core: remove pointless debugging messages
  libata: Add ata_port_classify() helper
  libata: move ata_dump_id() to dynamic debugging
  libata: sanitize ATA_HORKAGE_DUMP_ID
  sata_mv: replace DPRINTK with 'pci_dump' module parameter
  sata_mv: kill 'port' argument in mv_dump_all_regs()
  sata_sx4: move DPRINTK to VPRINTK
  libata: add reset tracepoints
  libata: drop DPRINTK() calls in reset
  libata: tracepoints for bus-master DMA
  libata: drop debugging statements for bus-master DMA
  pata_octeon_cf: add bmdma tracepoints and drop DPRINTK() calls
  pata_arasan_cf: use generic tracepoints
  sata_dwc_460ex: use generic tracepoints
  sata_nv: use generic tracepoints
  libata-sff: tracepoints for HSM state machine
  libata-sff: add tracepoints for ata_sff_flush_pio_task()
  libata-scsi: drop DPRINTK calls for cdb translation
  libata: add tracepoints for ATA error handling
  libata: drop DPRINTK() calls during ATA error handling
  libata-eh: remove DPRINTK() calls for request sense
  pata_octeon_cf: move DPRINTK to VPRINTK
  pdc_adma: move DPRINTK to VPRINTK
  sata_rcar: move DPRINTK to VPRINTK
  sata_qstor: move DPRINTK to VPRINTK
  pata_pdc2027x: Replace PDPRINTK() with standard ata logging
  sata_nv: move DPRINTK to ata debugging
  sata_fsl: move DPRINTK to ata debugging
  libata-core: move DPRINTK to ata debugging
  libata: remove DPRINTK() macro
  libata: kill ATA_MSG_INFO
  libata: kill ATA_MSG_CTL
  libata: remove references to ATA_DEBUG

 drivers/ata/acard-ahci.c        |   4 -
 drivers/ata/ahci.c              |  12 +-
 drivers/ata/ahci_qoriq.c        |   4 -
 drivers/ata/ata_piix.c          |   3 -
 drivers/ata/libahci.c           |  15 +-
 drivers/ata/libata-acpi.c       |  62 +++----
 drivers/ata/libata-core.c       | 229 +++++++++---------------
 drivers/ata/libata-eh.c         |  47 ++---
 drivers/ata/libata-pmp.c        |   8 -
 drivers/ata/libata-scsi.c       |  20 +--
 drivers/ata/libata-sff.c        |  76 ++++----
 drivers/ata/libata-trace.c      |  29 ++++
 drivers/ata/libata-transport.c  |  14 +-
 drivers/ata/pata_arasan_cf.c    |   3 +
 drivers/ata/pata_octeon_cf.c    |  23 +--
 drivers/ata/pata_pdc2027x.c     |  81 ++++-----
 drivers/ata/pata_pdc202xx_old.c |   2 -
 drivers/ata/pata_sil680.c       |   1 -
 drivers/ata/pdc_adma.c          |   2 +-
 drivers/ata/sata_dwc_460ex.c    |  57 +-----
 drivers/ata/sata_fsl.c          | 102 +++++------
 drivers/ata/sata_inic162x.c     |   2 +-
 drivers/ata/sata_mv.c           | 110 ++++++------
 drivers/ata/sata_nv.c           |  29 ++--
 drivers/ata/sata_qstor.c        |   2 +-
 drivers/ata/sata_rcar.c         |   8 +-
 drivers/ata/sata_sil24.c        |   5 +-
 drivers/ata/sata_sx4.c          |   2 +-
 include/linux/libata.h          | 105 +++++------
 include/trace/events/libata.h   | 377 ++++++++++++++++++++++++++++++++++++++++
 30 files changed, 809 insertions(+), 625 deletions(-)

-- 
2.16.4