From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F6DBC2D0E7 for ; Thu, 26 Mar 2020 09:45:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E73A42070A for ; Thu, 26 Mar 2020 09:45:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726292AbgCZJpj (ORCPT ); Thu, 26 Mar 2020 05:45:39 -0400 Received: from verein.lst.de ([213.95.11.211]:44786 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727780AbgCZJpj (ORCPT ); Thu, 26 Mar 2020 05:45:39 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 602E068C65; Thu, 26 Mar 2020 10:45:35 +0100 (CET) Date: Thu, 26 Mar 2020 10:45:34 +0100 From: Christoph Hellwig To: Bartlomiej Zolnierkiewicz Cc: Jens Axboe , Michael Schmitz , Geert Uytterhoeven , Christoph Hellwig , linux-ide@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 02/27] ata: expose ncq_enable_prio sysfs attribute only on NCQ capable hosts Message-ID: <20200326094534.GA9596@lst.de> References: <20200317144333.2904-1-b.zolnierkie@samsung.com> <20200317144333.2904-3-b.zolnierkie@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200317144333.2904-3-b.zolnierkie@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On Tue, Mar 17, 2020 at 03:43:08PM +0100, Bartlomiej Zolnierkiewicz wrote: > There is no point in exposing ncq_enable_prio sysfs attribute for > devices on PATA and non-NCQ capable SATA hosts so: > > * remove dev_attr_ncq_prio_enable from ata_common_sdev_attrs[] > > * add ata_ncq_sdev_attrs[] > > * update ATA_NCQ_SHT() macro to use ata_ncq_sdev_attrs[] > > Signed-off-by: Bartlomiej Zolnierkiewicz Looks good, Reviewed-by: Christoph Hellwig