From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1955C43331 for ; Thu, 26 Mar 2020 09:50:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C28CC2070A for ; Thu, 26 Mar 2020 09:50:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727796AbgCZJul (ORCPT ); Thu, 26 Mar 2020 05:50:41 -0400 Received: from verein.lst.de ([213.95.11.211]:44845 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727780AbgCZJul (ORCPT ); Thu, 26 Mar 2020 05:50:41 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 5CE0C68BFE; Thu, 26 Mar 2020 10:50:39 +0100 (CET) Date: Thu, 26 Mar 2020 10:50:39 +0100 From: Christoph Hellwig To: Bartlomiej Zolnierkiewicz Cc: Jens Axboe , Michael Schmitz , Geert Uytterhoeven , Christoph Hellwig , linux-ide@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 15/27] ata: let compiler optimize out ata_eh_set_lpm() on non-SATA hosts Message-ID: <20200326095039.GI9596@lst.de> References: <20200317144333.2904-1-b.zolnierkie@samsung.com> <20200317144333.2904-16-b.zolnierkie@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200317144333.2904-16-b.zolnierkie@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On Tue, Mar 17, 2020 at 03:43:21PM +0100, Bartlomiej Zolnierkiewicz wrote: > Add !IS_ENABLED(CONFIG_SATA_HOST) to ata_eh_set_lpm() to allow > compiler to optimize out the function for non-SATA configs (for > PATA hosts "ap && !ap->ops->set_lpm" condition is always true so > it's sufficient for the function to return zero). Looks good, Reviewed-by: Christoph Hellwig