From: Tony Asleson <tasleson@redhat.com> To: linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, b.zolnierkie@samsung.com, axboe@kernel.dk Subject: [v4 10/11] print_req_error: Use durable_name_printk_ratelimited Date: Fri, 24 Jul 2020 12:17:05 -0500 Message-ID: <20200724171706.1550403-11-tasleson@redhat.com> (raw) In-Reply-To: <20200724171706.1550403-1-tasleson@redhat.com> Replace printk_ratelimited with one that adds the key/value durable name to log entry. Signed-off-by: Tony Asleson <tasleson@redhat.com> --- block/blk-core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/block/blk-core.c b/block/blk-core.c index 9bfaee050c82..a1f35e3e21d8 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -213,12 +213,15 @@ EXPORT_SYMBOL_GPL(blk_status_to_errno); static void print_req_error(struct request *req, blk_status_t status, const char *caller) { + struct device *dev; int idx = (__force int)status; if (WARN_ON_ONCE(idx >= ARRAY_SIZE(blk_errors))) return; - printk_ratelimited(KERN_ERR + dev = (req->rq_disk) ? disk_to_dev(req->rq_disk) : NULL; + + durable_name_printk_ratelimited(KERN_ERR, dev, "%s: %s error, dev %s, sector %llu op 0x%x:(%s) flags 0x%x " "phys_seg %u prio class %u\n", caller, blk_errors[idx].name, -- 2.26.2
next prev parent reply index Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-24 17:16 [v4 00/11] Add persistent durable identifier to storage log messages Tony Asleson 2020-07-24 17:16 ` [v4 01/11] struct device: Add function callback durable_name Tony Asleson 2020-07-24 17:16 ` [v4 02/11] create_syslog_header: Add durable name Tony Asleson 2020-07-24 17:16 ` [v4 03/11] dev_vprintk_emit: Increase hdr size Tony Asleson 2020-07-25 10:05 ` Andy Shevchenko 2020-08-26 18:26 ` Tony Asleson 2020-07-24 17:16 ` [v4 04/11] scsi: Add durable_name for dev_printk Tony Asleson 2020-07-25 10:20 ` Andy Shevchenko 2020-07-24 17:17 ` [v4 05/11] nvme: Add durable name " Tony Asleson 2020-07-25 9:05 ` Sergei Shtylyov 2020-07-25 10:23 ` Andy Shevchenko 2020-07-24 17:17 ` [v4 06/11] libata: Add ata_scsi_durable_name Tony Asleson 2020-07-25 0:48 ` kernel test robot 2020-07-25 1:07 ` kernel test robot 2020-07-25 1:07 ` [RFC PATCH] libata: ata_scsi_durable_name() can be static kernel test robot 2020-07-25 1:18 ` [v4 06/11] libata: Add ata_scsi_durable_name kernel test robot 2020-07-25 10:26 ` Andy Shevchenko 2020-07-24 17:17 ` [v4 07/11] Add durable_name_printk Tony Asleson 2020-07-24 17:17 ` [v4 08/11] libata: use durable_name_printk Tony Asleson 2020-07-24 17:17 ` [v4 09/11] Add durable_name_printk_ratelimited Tony Asleson 2020-07-24 17:17 ` Tony Asleson [this message] 2020-07-25 9:15 ` [v4 10/11] print_req_error: Use durable_name_printk_ratelimited Sergei Shtylyov 2020-07-24 17:17 ` [v4 11/11] buffer_io_error: " Tony Asleson 2020-07-25 10:29 ` Andy Shevchenko 2020-07-26 15:10 ` [v4 00/11] Add persistent durable identifier to storage log messages Christoph Hellwig 2020-07-27 15:45 ` Tony Asleson 2020-07-27 16:46 ` Hannes Reinecke 2020-07-27 17:42 ` Tony Asleson 2020-07-27 19:17 ` Douglas Gilbert 2020-07-27 20:27 ` Tony Asleson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200724171706.1550403-11-tasleson@redhat.com \ --to=tasleson@redhat.com \ --cc=axboe@kernel.dk \ --cc=b.zolnierkie@samsung.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-ide@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-ide Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-ide/0 linux-ide/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-ide linux-ide/ https://lore.kernel.org/linux-ide \ linux-ide@vger.kernel.org public-inbox-index linux-ide Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-ide AGPL code for this site: git clone https://public-inbox.org/public-inbox.git