From: Tony Asleson <tasleson@redhat.com> To: linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, b.zolnierkie@samsung.com, axboe@kernel.dk Subject: [v4 01/11] struct device: Add function callback durable_name Date: Fri, 24 Jul 2020 12:16:56 -0500 Message-ID: <20200724171706.1550403-2-tasleson@redhat.com> (raw) In-Reply-To: <20200724171706.1550403-1-tasleson@redhat.com> Function callback and function to be used to write a persistent durable name to the supplied character buffer. This will be used to add structured key-value data to log messages for hardware related errors which allows end users to correlate message and specific hardware. Signed-off-by: Tony Asleson <tasleson@redhat.com> --- drivers/base/core.c | 24 ++++++++++++++++++++++++ include/linux/device.h | 4 ++++ 2 files changed, 28 insertions(+) diff --git a/drivers/base/core.c b/drivers/base/core.c index 0cad34f1eede..511b7d2fc916 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -2304,6 +2304,30 @@ int dev_set_name(struct device *dev, const char *fmt, ...) } EXPORT_SYMBOL_GPL(dev_set_name); +/** + * dev_durable_name - Write "DURABLE_NAME"=<durable name> in buffer + * @dev: device + * @buffer: character buffer to write results + * @len: length of buffer + * @return: Number of bytes written to buffer + */ +int dev_durable_name(const struct device *dev, char *buffer, size_t len) +{ + int tmp, dlen; + + if (dev && dev->durable_name) { + tmp = snprintf(buffer, len, "DURABLE_NAME="); + if (tmp < len) { + dlen = dev->durable_name(dev, buffer + tmp, + len - tmp); + if (dlen > 0 && ((dlen + tmp) < len)) + return dlen + tmp; + } + } + return 0; +} +EXPORT_SYMBOL_GPL(dev_durable_name); + /** * device_to_dev_kobj - select a /sys/dev/ directory for the device * @dev: device diff --git a/include/linux/device.h b/include/linux/device.h index ac8e37cd716a..281755404c21 100644 --- a/include/linux/device.h +++ b/include/linux/device.h @@ -613,6 +613,8 @@ struct device { struct iommu_group *iommu_group; struct dev_iommu *iommu; + int (*durable_name)(const struct device *dev, char *buff, size_t len); + bool offline_disabled:1; bool offline:1; bool of_node_reused:1; @@ -654,6 +656,8 @@ static inline const char *dev_name(const struct device *dev) extern __printf(2, 3) int dev_set_name(struct device *dev, const char *name, ...); +int dev_durable_name(const struct device *d, char *buffer, size_t len); + #ifdef CONFIG_NUMA static inline int dev_to_node(struct device *dev) { -- 2.26.2
next prev parent reply index Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-24 17:16 [v4 00/11] Add persistent durable identifier to storage log messages Tony Asleson 2020-07-24 17:16 ` Tony Asleson [this message] 2020-07-24 17:16 ` [v4 02/11] create_syslog_header: Add durable name Tony Asleson 2020-07-24 17:16 ` [v4 03/11] dev_vprintk_emit: Increase hdr size Tony Asleson 2020-07-25 10:05 ` Andy Shevchenko 2020-08-26 18:26 ` Tony Asleson 2020-07-24 17:16 ` [v4 04/11] scsi: Add durable_name for dev_printk Tony Asleson 2020-07-25 10:20 ` Andy Shevchenko 2020-07-24 17:17 ` [v4 05/11] nvme: Add durable name " Tony Asleson 2020-07-25 9:05 ` Sergei Shtylyov 2020-07-25 10:23 ` Andy Shevchenko 2020-07-24 17:17 ` [v4 06/11] libata: Add ata_scsi_durable_name Tony Asleson 2020-07-25 0:48 ` kernel test robot 2020-07-25 1:07 ` kernel test robot 2020-07-25 1:07 ` [RFC PATCH] libata: ata_scsi_durable_name() can be static kernel test robot 2020-07-25 1:18 ` [v4 06/11] libata: Add ata_scsi_durable_name kernel test robot 2020-07-25 10:26 ` Andy Shevchenko 2020-07-24 17:17 ` [v4 07/11] Add durable_name_printk Tony Asleson 2020-07-24 17:17 ` [v4 08/11] libata: use durable_name_printk Tony Asleson 2020-07-24 17:17 ` [v4 09/11] Add durable_name_printk_ratelimited Tony Asleson 2020-07-24 17:17 ` [v4 10/11] print_req_error: Use durable_name_printk_ratelimited Tony Asleson 2020-07-25 9:15 ` Sergei Shtylyov 2020-07-24 17:17 ` [v4 11/11] buffer_io_error: " Tony Asleson 2020-07-25 10:29 ` Andy Shevchenko 2020-07-26 15:10 ` [v4 00/11] Add persistent durable identifier to storage log messages Christoph Hellwig 2020-07-27 15:45 ` Tony Asleson 2020-07-27 16:46 ` Hannes Reinecke 2020-07-27 17:42 ` Tony Asleson 2020-07-27 19:17 ` Douglas Gilbert 2020-07-27 20:27 ` Tony Asleson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200724171706.1550403-2-tasleson@redhat.com \ --to=tasleson@redhat.com \ --cc=axboe@kernel.dk \ --cc=b.zolnierkie@samsung.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-ide@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-ide Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-ide/0 linux-ide/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-ide linux-ide/ https://lore.kernel.org/linux-ide \ linux-ide@vger.kernel.org public-inbox-index linux-ide Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-ide AGPL code for this site: git clone https://public-inbox.org/public-inbox.git