Hi Tony, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on 3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162] url: https://github.com/0day-ci/linux/commits/Tony-Asleson/Add-persistent-durable-identifier-to-storage-log-messages/20200725-011936 base: 3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162 config: i386-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-14) 9.3.0 reproduce (this is a W=1 build): # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/ata/libata-scsi.c:1094:5: warning: no previous prototype for 'ata_scsi_durable_name' [-Wmissing-prototypes] 1094 | int ata_scsi_durable_name(const struct device *dev, char *buf, size_t len) | ^~~~~~~~~~~~~~~~~~~~~ vim +/ata_scsi_durable_name +1094 drivers/ata/libata-scsi.c 1093 > 1094 int ata_scsi_durable_name(const struct device *dev, char *buf, size_t len) 1095 { 1096 struct ata_device *ata_dev = container_of(dev, struct ata_device, tdev); 1097 1098 return scsi_durable_name(ata_dev->sdev, buf, len); 1099 } 1100 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org