Linux-ide Archive on lore.kernel.org
 help / color / Atom feed
From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Jens Axboe <axboe@kernel.dk>, Rob Herring <robh+dt@kernel.org>,
	Vinod Koul <vkoul@kernel.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Marek Vasut <marek.vasut+renesas@gmail.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Mark Brown <broonie@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	linux-ide@vger.kernel.org, dmaengine <dmaengine@vger.kernel.org>,
	Linux I2C <linux-i2c@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	linux-pci <linux-pci@vger.kernel.org>,
	ALSA Development Mailing List <alsa-devel@alsa-project.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	USB list <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 20/20] arm64: dts: renesas: r8a774e1: Add VIN and CSI-2 nodes
Date: Fri, 7 Aug 2020 13:27:54 +0200
Message-ID: <20200807112754.GC3387836@oden.dyn.berto.se> (raw)
In-Reply-To: <CAMuHMdXie+GfKBO22mFrn4oG_y7YUxU9ekQdWnp1hn-6z2mLuQ@mail.gmail.com>

Hi Geert, Lad,

On 2020-08-06 13:47:58 +0200, Geert Uytterhoeven wrote:
> Hi Prabhakar,
> 
> On Thu, Aug 6, 2020 at 1:17 PM Lad, Prabhakar
> <prabhakar.csengg@gmail.com> wrote:
> > On Wed, Aug 5, 2020 at 12:19 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > On Thu, Jul 16, 2020 at 7:20 PM Lad Prabhakar
> > > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> > > > Add VIN and CSI-2 nodes to RZ/G2H (R8A774E1) SoC dtsi.
> > > >
> > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>
> > >
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > >
> > > However, before I queue this in renesas-devel for v5.10, I'd like to
> > > have some clarification about the issue below.
> > >
> > > > --- a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
> > > > +++ b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
> > >
> > > > +               vin4: video@e6ef4000 {
> > > > +                       compatible = "renesas,vin-r8a774e1";
> > > > +                       reg = <0 0xe6ef4000 0 0x1000>;
> > > > +                       interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
> > > > +                       clocks = <&cpg CPG_MOD 807>;
> > > > +                       power-domains = <&sysc R8A774E1_PD_ALWAYS_ON>;
> > > > +                       resets = <&cpg 807>;
> > > > +                       renesas,id = <4>;
> > > > +                       status = "disabled";
> > > > +
> > > > +                       ports {
> > > > +                               #address-cells = <1>;
> > > > +                               #size-cells = <0>;
> > > > +
> > > > +                               port@1 {
> > > > +                                       #address-cells = <1>;
> > > > +                                       #size-cells = <0>;
> > >
> > > "make dtbs W=1" says:
> > >
> > >     arch/arm64/boot/dts/renesas/r8a774e1.dtsi:1562.12-1572.7: Warning
> > > (graph_child_address): /soc/video@e6ef4000/ports/port@1: graph node
> > > has single child node 'endpoint@0', #address-cells/#size-cells are not
> > > necessary
> > >
> > > (same for vin5-7 below)
> > >
> > Referring to commit 5e53dbf4edb4d ("arm64: dts: renesas: r8a77990: Fix
> > VIN endpoint numbering") we definitely need endpoint numbering.
> > Probably the driver needs to be fixed to handle such cases.
> 
> > > > +
> > > > +                                       reg = <1>;
> > > > +
> > > > +                                       vin4csi20: endpoint@0 {
> > > > +                                               reg = <0>;
> > > > +                                               remote-endpoint = <&csi20vin4>;
> 
> On R-Car E3, the single endpoint is at address 2, so "make dtbs W=1"doesn't
> complain. Here it is at address 0.
> 
> Niklas?

First the R-Car VIN driver makes decisions based on which endpoint is 
described, each endpoint 0-3 represents a different CSI-2 block on the 
other end (0: CSI20, 1: CSI21, 2: CSI40 and 3: CSI41).

Then how to handle the warning I'm not sure. I can only really see 2 
options.

1. Ignore the warning.
2. Remove #address-cells, #size-cells and reg properties from port@ if 
   the only endpoint described is endpoint@0.

I would prefers option 2. that is what we do in other cases (for example 
on Gen2 boards that only have a single parallel sensor in some early DTS 
files we don't have the ports node and just describe a single port with 
the same reasoning.

We are not at risk at someone describing a second CSI-2 bock as an 
overlay so I see no real harm in option 2. What are your thoughts Geert?  
You know more about DT then me.

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

-- 
Regards,
Niklas Söderlund

  reply index

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-16 17:18 [PATCH 00/20] Add support for SATA/PCIe/USB2[3]/VIN/CSI on R8A774E1 Lad Prabhakar
2020-07-16 17:18 ` [PATCH 01/20] dt-bindings: pci: rcar-pci: Add device tree support for r8a774e1 Lad Prabhakar
2020-07-21  3:33   ` Rob Herring
2020-07-22  8:51   ` Wolfram Sang
2020-08-05  8:55   ` Geert Uytterhoeven
2020-08-27 17:34   ` Lad, Prabhakar
2020-08-28  1:13     ` Yoshihiro Shimoda
2020-09-19 10:46   ` Lad, Prabhakar
2020-07-16 17:18 ` [PATCH 02/20] arm64: dts: renesas: r8a774e1: Add PCIe device nodes Lad Prabhakar
2020-07-22  8:58   ` Wolfram Sang
2020-07-22  9:00     ` Wolfram Sang
2020-07-22  9:03       ` Lad, Prabhakar
2020-08-05 11:08   ` Geert Uytterhoeven
2020-07-16 17:18 ` [PATCH 03/20] dt-bindings: ata: renesas,rcar-sata: Add r8a774e1 support Lad Prabhakar
2020-07-21  3:34   ` [PATCH 03/20] dt-bindings: ata: renesas, rcar-sata: " Rob Herring
2020-08-05  8:48   ` [PATCH 03/20] dt-bindings: ata: renesas,rcar-sata: " Geert Uytterhoeven
2020-09-19 10:23   ` Lad, Prabhakar
2020-07-16 17:18 ` [PATCH 04/20] arm64: dts: renesas: r8a774e1: Add SATA controller node Lad Prabhakar
2020-08-05 11:09   ` Geert Uytterhoeven
2020-07-16 17:18 ` [PATCH 05/20] dt-bindings: phy: renesas,usb2-phy: Add r8a774e1 support Lad Prabhakar
2020-07-20  6:35   ` Vinod Koul
2020-08-05  8:54   ` Geert Uytterhoeven
2020-07-16 17:18 ` [PATCH 06/20] arm64: dts: renesas: r8a774e1: Add USB2.0 phy and host (EHCI/OHCI) device nodes Lad Prabhakar
2020-08-05 11:09   ` Geert Uytterhoeven
2020-07-16 17:18 ` [PATCH 07/20] dt-bindings: usb: renesas,usb3-peri: Document r8a774e1 support Lad Prabhakar
2020-07-21  3:35   ` [PATCH 07/20] dt-bindings: usb: renesas, usb3-peri: " Rob Herring
2020-08-05  8:56   ` [PATCH 07/20] dt-bindings: usb: renesas,usb3-peri: " Geert Uytterhoeven
2020-09-19 10:50   ` Lad, Prabhakar
2020-09-20 14:08     ` Greg Kroah-Hartman
2020-09-21  7:30       ` Geert Uytterhoeven
2020-09-22  8:39         ` Greg Kroah-Hartman
2020-09-22  8:40           ` Lad, Prabhakar
2020-07-16 17:18 ` [PATCH 08/20] dt-bindings: usb: usb-xhci: " Lad Prabhakar
2020-07-21  3:35   ` Rob Herring
2020-08-05  8:58   ` Geert Uytterhoeven
2020-08-27 17:15   ` Lad, Prabhakar
2020-08-28  1:11     ` Yoshihiro Shimoda
2020-08-28  7:52       ` Lad, Prabhakar
2020-07-16 17:18 ` [PATCH 09/20] dt-bindings: phy: renesas,usb3-phy: Add " Lad Prabhakar
2020-07-20  6:35   ` Vinod Koul
2020-08-05  9:01   ` Geert Uytterhoeven
2020-07-16 17:18 ` [PATCH 10/20] arm64: dts: renesas: r8a774e1: Add USB3.0 device nodes Lad Prabhakar
2020-08-05 11:14   ` Geert Uytterhoeven
2020-07-16 17:18 ` [PATCH 11/20] dt-bindings: usb: renesas,usbhs: Add r8a774e1 support Lad Prabhakar
2020-07-21  3:35   ` Rob Herring
2020-08-05  9:02   ` Geert Uytterhoeven
2020-08-27 17:08   ` Lad, Prabhakar
2020-08-28  1:08     ` Yoshihiro Shimoda
2020-09-19 10:54   ` Lad, Prabhakar
2020-09-20 14:08     ` Greg Kroah-Hartman
2020-09-21  7:29       ` Geert Uytterhoeven
2020-07-16 17:18 ` [PATCH 12/20] dt-bindings: dma: renesas,usb-dmac: Add binding for r8a774e1 Lad Prabhakar
2020-07-20  6:36   ` Vinod Koul
2020-08-05  9:03   ` Geert Uytterhoeven
2020-07-16 17:18 ` [PATCH 13/20] arm64: dts: renesas: r8a774e1: Add USB-DMAC and HSUSB device nodes Lad Prabhakar
2020-08-05 11:14   ` Geert Uytterhoeven
2020-07-16 17:18 ` [PATCH 14/20] dt-bindings: sound: renesas,rsnd: Document r8a774e1 bindings Lad Prabhakar
2020-08-05  9:05   ` Geert Uytterhoeven
2020-07-16 17:18 ` [PATCH 15/20] arm64: dts: renesas: r8a774e1: Add audio support Lad Prabhakar
2020-08-05 11:15   ` Geert Uytterhoeven
2020-07-16 17:18 ` [PATCH 16/20] dt-bindings: media: renesas,csi2: Add R8A774E1 support Lad Prabhakar
2020-07-17 13:13   ` Niklas
2020-07-21  3:36   ` Rob Herring
2020-07-16 17:18 ` [PATCH 17/20] dt-bindings: media: renesas,vin: " Lad Prabhakar
2020-07-17 13:07   ` Niklas
2020-07-21  3:36   ` Rob Herring
2020-07-16 17:18 ` [PATCH 18/20] media: rcar-csi2: Enable support for R8A774E1 Lad Prabhakar
2020-07-17 13:13   ` Niklas
2020-07-16 17:18 ` [PATCH 19/20] media: rcar-vin: " Lad Prabhakar
2020-07-17 13:19   ` Niklas
2020-07-16 17:18 ` [PATCH 20/20] arm64: dts: renesas: r8a774e1: Add VIN and CSI-2 nodes Lad Prabhakar
2020-08-05 11:18   ` Geert Uytterhoeven
2020-08-06 11:16     ` Lad, Prabhakar
2020-08-06 11:47       ` Geert Uytterhoeven
2020-08-07 11:27         ` Niklas Söderlund [this message]
2020-08-07 11:36           ` Geert Uytterhoeven
2020-08-08  7:48             ` Niklas Söderlund
2020-07-17 15:39 ` [PATCH 00/20] Add support for SATA/PCIe/USB2[3]/VIN/CSI on R8A774E1 Mark Brown
2020-07-22  8:50 ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200807112754.GC3387836@oden.dyn.berto.se \
    --to=niklas.soderlund@ragnatech.se \
    --cc=alsa-devel@alsa-project.org \
    --cc=axboe@kernel.dk \
    --cc=bhelgaas@google.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kishon@ti.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=marek.vasut+renesas@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=prabhakar.csengg@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ide Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-ide/0 linux-ide/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-ide linux-ide/ https://lore.kernel.org/linux-ide \
		linux-ide@vger.kernel.org
	public-inbox-index linux-ide

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-ide


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git