From: "Pali Rohár" <pali@kernel.org>
To: Sascha Hauer <s.hauer@pengutronix.de>, Jens Axboe <axboe@kernel.dk>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH v2] libata: Fix retrieving of active qcs
Date: Wed, 28 Oct 2020 14:55:14 +0100 [thread overview]
Message-ID: <20201028135514.r2m3kxchbg6nljht@pali> (raw)
In-Reply-To: <20200508054644.GJ5877@pengutronix.de>
On Friday 08 May 2020 07:46:44 Sascha Hauer wrote:
> From fcdcfa9e7a4ee4faf411de1df4f3c4e12c78545c Mon Sep 17 00:00:00 2001
> From: Sascha Hauer <s.hauer@pengutronix.de>
> Date: Fri, 8 May 2020 07:28:19 +0200
> Subject: [PATCH] ata: sata_nv: Fix retrieving of active qcs
>
> ata_qc_complete_multiple() has to be called with the tags physically
> active, that is the hw tag is at bit 0. ap->qc_active has the same tag
> at bit ATA_TAG_INTERNAL instead, so call ata_qc_get_active() to fix that
> up. This is done in the vein of 8385d756e114 ("libata: Fix retrieving of
> active qcs").
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
I tested this second change on nforce4 box with sata_nv controllers:
00:07.0 IDE interface [0101]: NVIDIA Corporation CK804 Serial ATA Controller [10de:0054] (rev f3)
00:08.0 IDE interface [0101]: NVIDIA Corporation CK804 Serial ATA Controller [10de:0055] (rev f3)
Both disks are working fine, I do not see any regression or change, so
you can add my:
Tested-by: Pali Rohár <pali@kernel.org>
Ideally add also Fixes line:
Fixes: 28361c403683 ("libata: add extra internal command")
Jens, do you need something more from me? Some special tests, etc?
> ---
> drivers/ata/sata_nv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/sata_nv.c b/drivers/ata/sata_nv.c
> index eb9dc14e5147..20190f66ced9 100644
> --- a/drivers/ata/sata_nv.c
> +++ b/drivers/ata/sata_nv.c
> @@ -2100,7 +2100,7 @@ static int nv_swncq_sdbfis(struct ata_port *ap)
> pp->dhfis_bits &= ~done_mask;
> pp->dmafis_bits &= ~done_mask;
> pp->sdbfis_bits |= done_mask;
> - ata_qc_complete_multiple(ap, ap->qc_active ^ done_mask);
> + ata_qc_complete_multiple(ap, ata_qc_get_active(ap) ^ done_mask);
>
> if (!ap->qc_active) {
> DPRINTK("over\n");
> --
> 2.26.2
next prev parent reply other threads:[~2020-10-29 1:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 8:04 [PATCH v2] libata: Fix retrieving of active qcs Sascha Hauer
2019-12-25 18:18 ` Pali Rohár
2019-12-25 18:26 ` Jens Axboe
2019-12-25 18:36 ` Pali Rohár
2019-12-26 0:06 ` Jens Axboe
2020-01-06 8:16 ` Sascha Hauer
2020-01-27 11:16 ` Pali Rohár
2020-01-27 11:24 ` Sascha Hauer
2020-05-03 21:46 ` Pali Rohár
2020-05-08 5:46 ` Sascha Hauer
2020-10-28 13:55 ` Pali Rohár [this message]
2020-10-28 13:58 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028135514.r2m3kxchbg6nljht@pali \
--to=pali@kernel.org \
--cc=axboe@kernel.dk \
--cc=kernel@pengutronix.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).