From: "Reimar Döffinger" <Reimar.Doeffinger@gmx.de>
To: linux-ide@vger.kernel.org
Subject: [PATCH] libata: add kernel parameter to force ATA_HORKAGE_NO_DMA_LOG
Date: Wed, 17 Mar 2021 19:04:13 +0100 [thread overview]
Message-ID: <20210317180413.2992-1-Reimar.Doeffinger@gmx.de> (raw)
The ATA_CMD_READ_LOG_DMA_EXT can cause controller/device to
become unresponsive until the next power cycle.
This seems to particularly affect IDE to SATA adapters,
possibly in combination with certain SATA SSDs, though
there might be more/different cases.
Comment 5 of https://bugzilla.kernel.org/show_bug.cgi?id=195895
is an example.
Having an option to disable its use allows booting systems affected,
which besides being a useful workaround is also a necessary
step to allow gathering more debug info on these systems.
Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
---
Documentation/admin-guide/kernel-parameters.txt | 2 ++
drivers/ata/libata-core.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index 04545725f187..d2428b3b98f1 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -2473,6 +2473,8 @@
* [no]ncqtrim: Turn off queued DSM TRIM.
+ * [no]dmalog: Turn off use of ATA_CMD_READ_LOG_DMA_EXT (0x47) command
+
* nohrst, nosrst, norst: suppress hard, soft
and both resets.
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 61c762961ca8..7fb865333a38 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -6104,6 +6104,8 @@ static int __init ata_parse_force_one(char **cur,
{ "ncq", .horkage_off = ATA_HORKAGE_NONCQ },
{ "noncqtrim", .horkage_on = ATA_HORKAGE_NO_NCQ_TRIM },
{ "ncqtrim", .horkage_off = ATA_HORKAGE_NO_NCQ_TRIM },
+ { "nodmalog", .horkage_on = ATA_HORKAGE_NO_DMA_LOG },
+ { "dmalog", .horkage_off = ATA_HORKAGE_NO_DMA_LOG },
{ "dump_id", .horkage_on = ATA_HORKAGE_DUMP_ID },
{ "pio0", .xfer_mask = 1 << (ATA_SHIFT_PIO + 0) },
{ "pio1", .xfer_mask = 1 << (ATA_SHIFT_PIO + 1) },
--
2.30.2
next reply other threads:[~2021-03-17 18:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 18:04 Reimar Döffinger [this message]
2021-08-14 13:47 Reimar Döffinger
2021-08-15 8:18 ` Christoph Hellwig
2021-08-15 16:34 ` Reimar Döffinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210317180413.2992-1-Reimar.Doeffinger@gmx.de \
--to=reimar.doeffinger@gmx.de \
--cc=linux-ide@vger.kernel.org \
--subject='Re: [PATCH] libata: add kernel parameter to force ATA_HORKAGE_NO_DMA_LOG' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).