linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/1] ata: Replace inclusion of kernel.h by bits.h in the header
@ 2021-04-09 15:34 Andy Shevchenko
  2021-05-17 12:20 ` Andy Shevchenko
  2021-05-17 15:11 ` Jens Axboe
  0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2021-04-09 15:34 UTC (permalink / raw)
  To: Andy Shevchenko, linux-ide, linux-kernel; +Cc: Jens Axboe

ata.h uses BIT() macro, hence bits.h must be included. Otherwise
there is no need to have kernel.h included, I do not see any
direct users of it in ata.h. Hence replace inclusion of kernel.h.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2: replaced kernel.h by bits.h (lkp), tested allmod/yesconfig on x86_64 (Jens)
 include/linux/ata.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/ata.h b/include/linux/ata.h
index 6e67aded28f8..1b44f40c7700 100644
--- a/include/linux/ata.h
+++ b/include/linux/ata.h
@@ -13,7 +13,7 @@
 #ifndef __LINUX_ATA_H__
 #define __LINUX_ATA_H__
 
-#include <linux/kernel.h>
+#include <linux/bits.h>
 #include <linux/string.h>
 #include <linux/types.h>
 #include <asm/byteorder.h>
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 1/1] ata: Replace inclusion of kernel.h by bits.h in the header
  2021-04-09 15:34 [PATCH v2 1/1] ata: Replace inclusion of kernel.h by bits.h in the header Andy Shevchenko
@ 2021-05-17 12:20 ` Andy Shevchenko
  2021-05-17 15:11 ` Jens Axboe
  1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2021-05-17 12:20 UTC (permalink / raw)
  To: linux-ide, linux-kernel; +Cc: Jens Axboe

On Fri, Apr 09, 2021 at 06:34:56PM +0300, Andy Shevchenko wrote:
> ata.h uses BIT() macro, hence bits.h must be included. Otherwise
> there is no need to have kernel.h included, I do not see any
> direct users of it in ata.h. Hence replace inclusion of kernel.h.

Jens, can we now apply this one?

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v2: replaced kernel.h by bits.h (lkp), tested allmod/yesconfig on x86_64 (Jens)
>  include/linux/ata.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/ata.h b/include/linux/ata.h
> index 6e67aded28f8..1b44f40c7700 100644
> --- a/include/linux/ata.h
> +++ b/include/linux/ata.h
> @@ -13,7 +13,7 @@
>  #ifndef __LINUX_ATA_H__
>  #define __LINUX_ATA_H__
>  
> -#include <linux/kernel.h>
> +#include <linux/bits.h>
>  #include <linux/string.h>
>  #include <linux/types.h>
>  #include <asm/byteorder.h>
> -- 
> 2.30.2
> 

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 1/1] ata: Replace inclusion of kernel.h by bits.h in the header
  2021-04-09 15:34 [PATCH v2 1/1] ata: Replace inclusion of kernel.h by bits.h in the header Andy Shevchenko
  2021-05-17 12:20 ` Andy Shevchenko
@ 2021-05-17 15:11 ` Jens Axboe
  1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2021-05-17 15:11 UTC (permalink / raw)
  To: Andy Shevchenko, linux-ide, linux-kernel

On 4/9/21 9:34 AM, Andy Shevchenko wrote:
> ata.h uses BIT() macro, hence bits.h must be included. Otherwise
> there is no need to have kernel.h included, I do not see any
> direct users of it in ata.h. Hence replace inclusion of kernel.h.

Applied, thanks.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-17 16:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 15:34 [PATCH v2 1/1] ata: Replace inclusion of kernel.h by bits.h in the header Andy Shevchenko
2021-05-17 12:20 ` Andy Shevchenko
2021-05-17 15:11 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).