linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 00/21] Rid W=1 warnings from IDE
@ 2021-06-02 10:17 Lee Jones
  2021-06-02 10:17 ` [PATCH 01/21] ide: alim15x3: Document alim15x3_init_one()'s 'id' param Lee Jones
                   ` (21 more replies)
  0 siblings, 22 replies; 25+ messages in thread
From: Lee Jones @ 2021-06-02 10:17 UTC (permalink / raw)
  To: lee.jones
  Cc: linux-kernel, Adrian Sun, Alan Cox, Andre Hedrick,
	Benjamin Herrenschmidt, Benoit Poulot-Cazajous,
	Christian Brunner, Christopher J. Reimer, CJ, Clear Zhang,
	David S. Miller, Duncan Laurie, Erik Andersen, Frank Tiernan,
	Gadi Oxman, Jens Axboe, linux-ide, linuxppc-dev, Mark Lord,
	Michael Ellerman, Mike Waychison, or, Paul Mackerras,
	Robert Bringman, Scott Snyder, Sergei Shtylyov, Tim Hockin

This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.

Lee Jones (21):
  ide: alim15x3: Document alim15x3_init_one()'s 'id' param
  ide: ide-dma: Document ide_dma_unmap_sg()'s missing 'cmd' param
  ide: ide-dma-sff: Provide some missing 'param' descriptions
  ide: ide-io: Fix a few kernel-doc misdemeanours
  ide: ide-proc: Strip out unused fops structure and accompanying
    call-back
  ide: cs5530: Fix incorrect documentation for function
    init_chipset_cs5530()
  ide: ide-probe: Fix-up incorrectly documented function
    probe_for_drive()
  ide: hpt366: Provide some missing descriptions for 'f_{low,high}'
  ide: piix: Remove unused variable 'sitre'
  ide: pdc202xx_new: Supply missing description for 'set_indexed_reg()'s
    'value' param
  ide: slc90e66: Remove unused variable 'sitre'
  ide: it821x: Fix a couple of incorrectly documented functions
  ide: siimage: Fix some incorrectly documented functions/params
  ide: via82cxxx: Fix misdocumentation of via_set_speed()'s 'hwif' param
  ide: ide-cd_ioctl: Remove unused variable 'stat'
  ide: ide-cd: Demote kernel-doc abuse
  ide: ide-acpi: Mark debugging variable 'bus' as __maybe_unused
  ide: ide-io: Document ide_intr()'s param 'irq'
  ide: piix: Fix incorrectly documented param 'hwif'
  ide: ide-acpi: Provide missing description for param 'obj_loc'
  ide: pmac: Staticise local function 'pmac_ide_probe'

 drivers/ide/alim15x3.c     |  1 +
 drivers/ide/cs5530.c       |  2 +-
 drivers/ide/hpt366.c       |  2 ++
 drivers/ide/ide-acpi.c     |  4 +++-
 drivers/ide/ide-cd.c       |  2 +-
 drivers/ide/ide-cd_ioctl.c |  3 +--
 drivers/ide/ide-dma-sff.c  |  4 ++++
 drivers/ide/ide-dma.c      |  1 +
 drivers/ide/ide-io.c       |  9 +++++----
 drivers/ide/ide-probe.c    |  2 +-
 drivers/ide/ide-proc.c     | 13 -------------
 drivers/ide/it821x.c       |  4 ++--
 drivers/ide/pdc202xx_new.c |  1 +
 drivers/ide/piix.c         |  4 +---
 drivers/ide/pmac.c         |  2 +-
 drivers/ide/siimage.c      |  4 ++--
 drivers/ide/slc90e66.c     |  3 +--
 drivers/ide/via82cxxx.c    |  2 +-
 18 files changed, 29 insertions(+), 34 deletions(-)

Cc: Adrian Sun <a.sun@sun.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Andre Hedrick <andre@linux-ide.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Benoit Poulot-Cazajous <poulot@chorus.fr>
Cc: Christian Brunner <chb@muc.de>
Cc: "Christopher J. Reimer" <reimer@doe.carleton.ca>
Cc: CJ <cjtsai@ali.com.tw>
Cc: Clear Zhang <Clear.Zhang@ali.com.tw>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Duncan Laurie <void@sun.com>
Cc: Erik Andersen <andersee@debian.org>
Cc: Frank Tiernan <frankt@promise.com>
Cc: Gadi Oxman <gadio@netvision.net.il>
Cc: Jens Axboe <axboe@suse.de>
Cc: linux-ide@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org
Cc: Mark Lord <mlord@pobox.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Mike Waychison <crlf@sun.com>
Cc: or <source@mvista.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Robert Bringman <rob@mars.trion.com>
Cc: Scott Snyder <snyder@fnald0.fnal.gov>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: "Software, Inc" <source@mvista.com>
Cc: support to <linux-ide@vger.kernel.org>
Cc: Tim Hockin <thockin@sun.com>
-- 
2.31.1


^ permalink raw reply	[flat|nested] 25+ messages in thread

* [PATCH 01/21] ide: alim15x3: Document alim15x3_init_one()'s 'id' param
  2021-06-02 10:17 [PATCH 00/21] Rid W=1 warnings from IDE Lee Jones
@ 2021-06-02 10:17 ` Lee Jones
  2021-06-02 10:17 ` [PATCH 02/21] ide: ide-dma: Document ide_dma_unmap_sg()'s missing 'cmd' param Lee Jones
                   ` (20 subsequent siblings)
  21 siblings, 0 replies; 25+ messages in thread
From: Lee Jones @ 2021-06-02 10:17 UTC (permalink / raw)
  To: lee.jones
  Cc: linux-kernel, David S. Miller, CJ, Andre Hedrick, Clear Zhang,
	Software, Inc, linux-ide

Fixes the following W=1 kernel build warning(s):

 drivers/ide/alim15x3.c:536: warning: Function parameter or member 'id' not described in 'alim15x3_init_one'

Cc: "David S. Miller" <davem@davemloft.net>
Cc: CJ <cjtsai@ali.com.tw>
Cc: Andre Hedrick <andre@linux-ide.org>
Cc: Clear Zhang <Clear.Zhang@ali.com.tw>
Cc: "Software, Inc" <source@mvista.com>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/ide/alim15x3.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ide/alim15x3.c b/drivers/ide/alim15x3.c
index a5043e048f919..39684d12d45e5 100644
--- a/drivers/ide/alim15x3.c
+++ b/drivers/ide/alim15x3.c
@@ -526,6 +526,7 @@ static const struct ide_port_info ali15x3_chipset = {
 /**
  *	alim15x3_init_one	-	set up an ALi15x3 IDE controller
  *	@dev: PCI device to set up
+ *	@id: PCI ID
  *
  *	Perform the actual set up for an ALi15x3 that has been found by the
  *	hot plug layer.
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH 02/21] ide: ide-dma: Document ide_dma_unmap_sg()'s missing 'cmd' param
  2021-06-02 10:17 [PATCH 00/21] Rid W=1 warnings from IDE Lee Jones
  2021-06-02 10:17 ` [PATCH 01/21] ide: alim15x3: Document alim15x3_init_one()'s 'id' param Lee Jones
@ 2021-06-02 10:17 ` Lee Jones
  2021-06-02 10:17 ` [PATCH 03/21] ide: ide-dma-sff: Provide some missing 'param' descriptions Lee Jones
                   ` (19 subsequent siblings)
  21 siblings, 0 replies; 25+ messages in thread
From: Lee Jones @ 2021-06-02 10:17 UTC (permalink / raw)
  To: lee.jones
  Cc: linux-kernel, David S. Miller, Andre Hedrick,
	Christopher J. Reimer, Benoit Poulot-Cazajous, Christian Brunner,
	Robert Bringman, linux-ide

Fixes the following W=1 kernel build warning(s):

 drivers/ide/ide-dma.c:165: warning: Function parameter or member 'cmd' not described in 'ide_dma_unmap_sg'

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Andre Hedrick <andre@linux-ide.org>
Cc: "Christopher J. Reimer" <reimer@doe.carleton.ca>
Cc: Benoit Poulot-Cazajous <poulot@chorus.fr>
Cc: Christian Brunner <chb@muc.de>
Cc: Robert Bringman <rob@mars.trion.com>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/ide/ide-dma.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ide/ide-dma.c b/drivers/ide/ide-dma.c
index 6f344654ef229..a02d02ad9ea23 100644
--- a/drivers/ide/ide-dma.c
+++ b/drivers/ide/ide-dma.c
@@ -153,6 +153,7 @@ static int ide_dma_map_sg(ide_drive_t *drive, struct ide_cmd *cmd)
 /**
  *	ide_dma_unmap_sg	-	clean up DMA mapping
  *	@drive: The drive to unmap
+ *	@cmd: The IDEcommand
  *
  *	Teardown mappings after DMA has completed. This must be called
  *	after the completion of each use of ide_build_dmatable and before
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH 03/21] ide: ide-dma-sff: Provide some missing 'param' descriptions
  2021-06-02 10:17 [PATCH 00/21] Rid W=1 warnings from IDE Lee Jones
  2021-06-02 10:17 ` [PATCH 01/21] ide: alim15x3: Document alim15x3_init_one()'s 'id' param Lee Jones
  2021-06-02 10:17 ` [PATCH 02/21] ide: ide-dma: Document ide_dma_unmap_sg()'s missing 'cmd' param Lee Jones
@ 2021-06-02 10:17 ` Lee Jones
  2021-06-02 10:17 ` [PATCH 04/21] ide: ide-io: Fix a few kernel-doc misdemeanours Lee Jones
                   ` (18 subsequent siblings)
  21 siblings, 0 replies; 25+ messages in thread
From: Lee Jones @ 2021-06-02 10:17 UTC (permalink / raw)
  To: lee.jones; +Cc: linux-kernel, David S. Miller, linux-ide

Fixes the following W=1 kernel build warning(s):

 drivers/ide/ide-dma-sff.c:84: warning: Function parameter or member 'on' not described in 'ide_dma_host_set'
 drivers/ide/ide-dma-sff.c:116: warning: Function parameter or member 'drive' not described in 'ide_build_dmatable'
 drivers/ide/ide-dma-sff.c:116: warning: Function parameter or member 'cmd' not described in 'ide_build_dmatable'

Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/ide/ide-dma-sff.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/ide/ide-dma-sff.c b/drivers/ide/ide-dma-sff.c
index b7c2c0bd18b53..8603df4d92fd8 100644
--- a/drivers/ide/ide-dma-sff.c
+++ b/drivers/ide/ide-dma-sff.c
@@ -75,6 +75,7 @@ static void ide_dma_sff_write_status(ide_hwif_t *hwif, u8 val)
 /**
  *	ide_dma_host_set	-	Enable/disable DMA on a host
  *	@drive: drive to control
+ *	@on: whether to enable/disable the IDE controller's DMA
  *
  *	Enable/disable DMA on an IDE controller following generic
  *	bus-mastering IDE controller behaviour.
@@ -98,6 +99,9 @@ EXPORT_SYMBOL_GPL(ide_dma_host_set);
 /**
  *	ide_build_dmatable	-	build IDE DMA table
  *
+ *	@drive: The drive to unmap
+ *	@cmd: The IDEcommand
+ *
  *	ide_build_dmatable() prepares a dma request. We map the command
  *	to get the pci bus addresses of the buffers and then build up
  *	the PRD table that the IDE layer wants to be fed.
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH 04/21] ide: ide-io: Fix a few kernel-doc misdemeanours
  2021-06-02 10:17 [PATCH 00/21] Rid W=1 warnings from IDE Lee Jones
                   ` (2 preceding siblings ...)
  2021-06-02 10:17 ` [PATCH 03/21] ide: ide-dma-sff: Provide some missing 'param' descriptions Lee Jones
@ 2021-06-02 10:17 ` Lee Jones
  2021-06-02 10:17 ` [PATCH 05/21] ide: ide-proc: Strip out unused fops structure and accompanying call-back Lee Jones
                   ` (17 subsequent siblings)
  21 siblings, 0 replies; 25+ messages in thread
From: Lee Jones @ 2021-06-02 10:17 UTC (permalink / raw)
  To: lee.jones; +Cc: linux-kernel, David S. Miller, linux-ide

Fixes the following W=1 kernel build warning(s):

 drivers/ide/ide-io.c:268: warning: expecting prototype for execute_drive_command(). Prototype was for execute_drive_cmd() instead
 drivers/ide/ide-io.c:320: warning: Function parameter or member 'drive' not described in 'start_request'
 drivers/ide/ide-io.c:320: warning: Function parameter or member 'rq' not described in 'start_request'
 drivers/ide/ide-io.c:618: warning: Function parameter or member 't' not described in 'ide_timer_expiry'
 drivers/ide/ide-io.c:618: warning: Excess function parameter 'data' description in 'ide_timer_expiry'
 drivers/ide/ide-io.c:775: warning: Excess function parameter 'regs' description in 'ide_intr'

Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/ide/ide-io.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c
index 4867b67b60d69..bd3e78985bcc7 100644
--- a/drivers/ide/ide-io.c
+++ b/drivers/ide/ide-io.c
@@ -252,7 +252,7 @@ void ide_init_sg_cmd(struct ide_cmd *cmd, unsigned int nr_bytes)
 EXPORT_SYMBOL_GPL(ide_init_sg_cmd);
 
 /**
- *	execute_drive_command	-	issue special drive command
+ *	execute_drive_cmd	-	issue special drive command
  *	@drive: the drive to issue the command on
  *	@rq: the request structure holding the command
  *
@@ -309,6 +309,8 @@ static ide_startstop_t ide_special_rq(ide_drive_t *drive, struct request *rq)
 
 /**
  *	start_request	-	start of I/O and command issuing for IDE
+ *	@drive: the drive to issue the command on
+ *	@rq: the request structure holding the command
  *
  *	start_request() initiates handling of a new I/O request. It
  *	accepts commands and I/O (read/write) requests.
@@ -602,7 +604,7 @@ static int drive_is_ready(ide_drive_t *drive)
 
 /**
  *	ide_timer_expiry	-	handle lack of an IDE interrupt
- *	@data: timer callback magic (hwif)
+ *	@t: timer callback magic (hwif)
  *
  *	An IDE command has timed out before the expected drive return
  *	occurred. At this point we attempt to clean up the current
@@ -748,9 +750,7 @@ static void unexpected_intr(int irq, ide_hwif_t *hwif)
 
 /**
  *	ide_intr	-	default IDE interrupt handler
- *	@irq: interrupt number
  *	@dev_id: hwif
- *	@regs: unused weirdness from the kernel irq layer
  *
  *	This is the default IRQ handler for the IDE layer. You should
  *	not need to override it. If you do be aware it is subtle in
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH 05/21] ide: ide-proc: Strip out unused fops structure and accompanying call-back
  2021-06-02 10:17 [PATCH 00/21] Rid W=1 warnings from IDE Lee Jones
                   ` (3 preceding siblings ...)
  2021-06-02 10:17 ` [PATCH 04/21] ide: ide-io: Fix a few kernel-doc misdemeanours Lee Jones
@ 2021-06-02 10:17 ` Lee Jones
  2021-06-02 10:17 ` [PATCH 06/21] ide: cs5530: Fix incorrect documentation for function init_chipset_cs5530() Lee Jones
                   ` (16 subsequent siblings)
  21 siblings, 0 replies; 25+ messages in thread
From: Lee Jones @ 2021-06-02 10:17 UTC (permalink / raw)
  To: lee.jones; +Cc: linux-kernel, David S. Miller, linux-ide

Fixes the following W=1 kernel build warning(s):

 drivers/ide/ide-proc.c:457:37: warning: ‘ide_media_proc_fops’ defined but not used [-Wunused-const-variable=]

Fixes: ec7d9c9ce897 ("ide: replace ->proc_fops with ->proc_show")
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/ide/ide-proc.c | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/drivers/ide/ide-proc.c b/drivers/ide/ide-proc.c
index 15c17f3781ee9..34bed14f88c78 100644
--- a/drivers/ide/ide-proc.c
+++ b/drivers/ide/ide-proc.c
@@ -449,19 +449,6 @@ static int ide_media_proc_show(struct seq_file *m, void *v)
 	return 0;
 }
 
-static int ide_media_proc_open(struct inode *inode, struct file *file)
-{
-	return single_open(file, ide_media_proc_show, PDE_DATA(inode));
-}
-
-static const struct file_operations ide_media_proc_fops = {
-	.owner		= THIS_MODULE,
-	.open		= ide_media_proc_open,
-	.read		= seq_read,
-	.llseek		= seq_lseek,
-	.release	= single_release,
-};
-
 static ide_proc_entry_t generic_drive_entries[] = {
 	{ "driver",	S_IFREG|S_IRUGO,	 ide_driver_proc_show	},
 	{ "identify",	S_IFREG|S_IRUSR,	 ide_identify_proc_show	},
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH 06/21] ide: cs5530: Fix incorrect documentation for function init_chipset_cs5530()
  2021-06-02 10:17 [PATCH 00/21] Rid W=1 warnings from IDE Lee Jones
                   ` (4 preceding siblings ...)
  2021-06-02 10:17 ` [PATCH 05/21] ide: ide-proc: Strip out unused fops structure and accompanying call-back Lee Jones
@ 2021-06-02 10:17 ` Lee Jones
  2021-06-02 10:17 ` [PATCH 07/21] ide: ide-probe: Fix-up incorrectly documented function probe_for_drive() Lee Jones
                   ` (15 subsequent siblings)
  21 siblings, 0 replies; 25+ messages in thread
From: Lee Jones @ 2021-06-02 10:17 UTC (permalink / raw)
  To: lee.jones
  Cc: linux-kernel, David S. Miller, Andre Hedrick, Mark Lord, linux-ide

Fixes the following W=1 kernel build warning(s):

 drivers/ide/cs5530.c:139: warning: expecting prototype for init_chipset_5530(). Prototype was for init_chipset_cs5530() instead

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Andre Hedrick <andre@linux-ide.org>
Cc: Mark Lord <mlord@pobox.com>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/ide/cs5530.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ide/cs5530.c b/drivers/ide/cs5530.c
index 5bb46e7130c8a..366be8c978a6e 100644
--- a/drivers/ide/cs5530.c
+++ b/drivers/ide/cs5530.c
@@ -129,7 +129,7 @@ static void cs5530_set_dma_mode(ide_hwif_t *hwif, ide_drive_t *drive)
 }
 
 /**
- *	init_chipset_5530	-	set up 5530 bridge
+ *	init_chipset_cs5530	-	set up 5530 bridge
  *	@dev: PCI device
  *
  *	Initialize the cs5530 bridge for reliable IDE DMA operation.
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH 07/21] ide: ide-probe: Fix-up incorrectly documented function probe_for_drive()
  2021-06-02 10:17 [PATCH 00/21] Rid W=1 warnings from IDE Lee Jones
                   ` (5 preceding siblings ...)
  2021-06-02 10:17 ` [PATCH 06/21] ide: cs5530: Fix incorrect documentation for function init_chipset_cs5530() Lee Jones
@ 2021-06-02 10:17 ` Lee Jones
  2021-06-02 10:17 ` [PATCH 08/21] ide: hpt366: Provide some missing descriptions for 'f_{low,high}' Lee Jones
                   ` (14 subsequent siblings)
  21 siblings, 0 replies; 25+ messages in thread
From: Lee Jones @ 2021-06-02 10:17 UTC (permalink / raw)
  To: lee.jones
  Cc: linux-kernel, David S. Miller, Mark Lord, Gadi Oxman,
	Andre Hedrick, support to

Fixes the following W=1 kernel build warning(s):

 drivers/ide/ide-probe.c:476: warning: expecting prototype for probe_for_drives(). Prototype was for probe_for_drive() instead

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Mark Lord <mlord@pobox.com>
Cc: Gadi Oxman <gadio@netvision.net.il>
Cc: Andre Hedrick <andre@linux-ide.org>
Cc: support to <linux-ide@vger.kernel.org>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/ide/ide-probe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c
index aefd74c0d8628..c1fde697657d7 100644
--- a/drivers/ide/ide-probe.c
+++ b/drivers/ide/ide-probe.c
@@ -461,7 +461,7 @@ static int do_probe (ide_drive_t *drive, u8 cmd)
 }
 
 /**
- *	probe_for_drives	-	upper level drive probe
+ *	probe_for_drive	-	upper level drive probe
  *	@drive: drive to probe for
  *
  *	probe_for_drive() tests for existence of a given drive using do_probe()
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH 08/21] ide: hpt366: Provide some missing descriptions for 'f_{low,high}'
  2021-06-02 10:17 [PATCH 00/21] Rid W=1 warnings from IDE Lee Jones
                   ` (6 preceding siblings ...)
  2021-06-02 10:17 ` [PATCH 07/21] ide: ide-probe: Fix-up incorrectly documented function probe_for_drive() Lee Jones
@ 2021-06-02 10:17 ` Lee Jones
  2021-06-02 10:17 ` [PATCH 09/21] ide: piix: Remove unused variable 'sitre' Lee Jones
                   ` (13 subsequent siblings)
  21 siblings, 0 replies; 25+ messages in thread
From: Lee Jones @ 2021-06-02 10:17 UTC (permalink / raw)
  To: lee.jones
  Cc: linux-kernel, David S. Miller, Andre Hedrick, Adrian Sun,
	Duncan Laurie, Tim Hockin, Mike Waychison, Alan Cox,
	Sergei Shtylyov, or, linux-ide

Fixes the following W=1 kernel build warning(s):

 drivers/ide/hpt366.c:849: warning: Function parameter or member 'f_low' not described in 'hpt37x_calibrate_dpll'
 drivers/ide/hpt366.c:849: warning: Function parameter or member 'f_high' not described in 'hpt37x_calibrate_dpll'

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Andre Hedrick <andre@linux-ide.org>
Cc: Adrian Sun <a.sun@sun.com>
Cc: Duncan Laurie <void@sun.com>
Cc: Tim Hockin <thockin@sun.com>
Cc: Mike Waychison <crlf@sun.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: or <source@mvista.com>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/ide/hpt366.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/ide/hpt366.c b/drivers/ide/hpt366.c
index b3d44de777cbd..69c7c2abf3e51 100644
--- a/drivers/ide/hpt366.c
+++ b/drivers/ide/hpt366.c
@@ -841,6 +841,8 @@ static void hpt3xxn_rw_disk(ide_drive_t *drive, struct request *rq)
 /**
  *	hpt37x_calibrate_dpll	-	calibrate the DPLL
  *	@dev: PCI device
+ *	@f_low: DPLL low value
+ *	@f_high: DPLL high value
  *
  *	Perform a calibration cycle on the DPLL.
  *	Returns 1 if this succeeds
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH 09/21] ide: piix: Remove unused variable 'sitre'
  2021-06-02 10:17 [PATCH 00/21] Rid W=1 warnings from IDE Lee Jones
                   ` (7 preceding siblings ...)
  2021-06-02 10:17 ` [PATCH 08/21] ide: hpt366: Provide some missing descriptions for 'f_{low,high}' Lee Jones
@ 2021-06-02 10:17 ` Lee Jones
  2021-06-02 10:17 ` [PATCH 10/21] ide: pdc202xx_new: Supply missing description for 'set_indexed_reg()'s 'value' param Lee Jones
                   ` (12 subsequent siblings)
  21 siblings, 0 replies; 25+ messages in thread
From: Lee Jones @ 2021-06-02 10:17 UTC (permalink / raw)
  To: lee.jones
  Cc: linux-kernel, David S. Miller, Andre Hedrick, Software, Inc, linux-ide

Fixes the following W=1 kernel build warning(s):

 drivers/ide/piix.c: In function ‘piix_set_dma_mode’:
 drivers/ide/piix.c:146:8: warning: variable ‘sitre’ set but not used [-Wunused-but-set-variable]

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Andre Hedrick <andre@linux-ide.org>
Cc: "Software, Inc" <source@mvista.com>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/ide/piix.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/ide/piix.c b/drivers/ide/piix.c
index 2634768a4e664..ede42d2a5b0b1 100644
--- a/drivers/ide/piix.c
+++ b/drivers/ide/piix.c
@@ -143,13 +143,11 @@ static void piix_set_dma_mode(ide_hwif_t *hwif, ide_drive_t *drive)
 	int v_flag		= 0x01 << drive->dn;
 	int w_flag		= 0x10 << drive->dn;
 	int u_speed		= 0;
-	int			sitre;
 	u16			reg4042, reg4a;
 	u8			reg48, reg54, reg55;
 	const u8 speed		= drive->dma_mode;
 
 	pci_read_config_word(dev, maslave, &reg4042);
-	sitre = (reg4042 & 0x4000) ? 1 : 0;
 	pci_read_config_byte(dev, 0x48, &reg48);
 	pci_read_config_word(dev, 0x4a, &reg4a);
 	pci_read_config_byte(dev, 0x54, &reg54);
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH 10/21] ide: pdc202xx_new: Supply missing description for 'set_indexed_reg()'s 'value' param
  2021-06-02 10:17 [PATCH 00/21] Rid W=1 warnings from IDE Lee Jones
                   ` (8 preceding siblings ...)
  2021-06-02 10:17 ` [PATCH 09/21] ide: piix: Remove unused variable 'sitre' Lee Jones
@ 2021-06-02 10:17 ` Lee Jones
  2021-06-02 10:17 ` [PATCH 11/21] ide: slc90e66: Remove unused variable 'sitre' Lee Jones
                   ` (11 subsequent siblings)
  21 siblings, 0 replies; 25+ messages in thread
From: Lee Jones @ 2021-06-02 10:17 UTC (permalink / raw)
  To: lee.jones
  Cc: linux-kernel, David S. Miller, Andre Hedrick, Frank Tiernan, linux-ide

Fixes the following W=1 kernel build warning(s):

 drivers/ide/pdc202xx_new.c:84: warning: Function parameter or member 'value' not described in 'set_indexed_reg'

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Andre Hedrick <andre@linux-ide.org>
Cc: Frank Tiernan <frankt@promise.com>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/ide/pdc202xx_new.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ide/pdc202xx_new.c b/drivers/ide/pdc202xx_new.c
index 7c276b8aeb5fe..537521213e148 100644
--- a/drivers/ide/pdc202xx_new.c
+++ b/drivers/ide/pdc202xx_new.c
@@ -79,6 +79,7 @@ static u8 get_indexed_reg(ide_hwif_t *hwif, u8 index)
  * set_indexed_reg - Set indexed register
  * @hwif: for the port address
  * @index: index of the indexed register
+ * @value: value of the indexed register
  */
 static void set_indexed_reg(ide_hwif_t *hwif, u8 index, u8 value)
 {
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH 11/21] ide: slc90e66: Remove unused variable 'sitre'
  2021-06-02 10:17 [PATCH 00/21] Rid W=1 warnings from IDE Lee Jones
                   ` (9 preceding siblings ...)
  2021-06-02 10:17 ` [PATCH 10/21] ide: pdc202xx_new: Supply missing description for 'set_indexed_reg()'s 'value' param Lee Jones
@ 2021-06-02 10:17 ` Lee Jones
  2021-06-02 10:17 ` [PATCH 12/21] ide: it821x: Fix a couple of incorrectly documented functions Lee Jones
                   ` (10 subsequent siblings)
  21 siblings, 0 replies; 25+ messages in thread
From: Lee Jones @ 2021-06-02 10:17 UTC (permalink / raw)
  To: lee.jones
  Cc: linux-kernel, David S. Miller, Andre Hedrick, Software, Inc, linux-ide

Fixes the following W=1 kernel build warning(s):

 drivers/ide/slc90e66.c: In function ‘slc90e66_set_dma_mode’:
 drivers/ide/slc90e66.c:80:6: warning: variable ‘sitre’ set but not used [-Wunused-but-set-variable]

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Andre Hedrick <andre@linux-ide.org>
Cc: "Software, Inc" <source@mvista.com>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/ide/slc90e66.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/ide/slc90e66.c b/drivers/ide/slc90e66.c
index cd47445fda1ff..0b06c74dddf36 100644
--- a/drivers/ide/slc90e66.c
+++ b/drivers/ide/slc90e66.c
@@ -77,13 +77,12 @@ static void slc90e66_set_dma_mode(ide_hwif_t *hwif, ide_drive_t *drive)
 {
 	struct pci_dev *dev	= to_pci_dev(hwif->dev);
 	u8 maslave		= hwif->channel ? 0x42 : 0x40;
-	int sitre = 0, a_speed	= 7 << (drive->dn * 4);
+	int a_speed		= 7 << (drive->dn * 4);
 	int u_speed = 0, u_flag = 1 << drive->dn;
 	u16			reg4042, reg44, reg48, reg4a;
 	const u8 speed		= drive->dma_mode;
 
 	pci_read_config_word(dev, maslave, &reg4042);
-	sitre = (reg4042 & 0x4000) ? 1 : 0;
 	pci_read_config_word(dev, 0x44, &reg44);
 	pci_read_config_word(dev, 0x48, &reg48);
 	pci_read_config_word(dev, 0x4a, &reg4a);
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH 12/21] ide: it821x: Fix a couple of incorrectly documented functions
  2021-06-02 10:17 [PATCH 00/21] Rid W=1 warnings from IDE Lee Jones
                   ` (10 preceding siblings ...)
  2021-06-02 10:17 ` [PATCH 11/21] ide: slc90e66: Remove unused variable 'sitre' Lee Jones
@ 2021-06-02 10:17 ` Lee Jones
  2021-06-02 10:17 ` [PATCH 13/21] ide: siimage: Fix some incorrectly documented functions/params Lee Jones
                   ` (9 subsequent siblings)
  21 siblings, 0 replies; 25+ messages in thread
From: Lee Jones @ 2021-06-02 10:17 UTC (permalink / raw)
  To: lee.jones; +Cc: linux-kernel, David S. Miller, linux-ide

Fixes the following W=1 kernel build warning(s):

 drivers/ide/it821x.c:362: warning: expecting prototype for it821x_dma_read(). Prototype was for it821x_dma_start() instead
 drivers/ide/it821x.c:384: warning: expecting prototype for it821x_dma_write(). Prototype was for it821x_dma_end() instead

Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/ide/it821x.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ide/it821x.c b/drivers/ide/it821x.c
index aad746007330c..e7c965c3703e5 100644
--- a/drivers/ide/it821x.c
+++ b/drivers/ide/it821x.c
@@ -346,7 +346,7 @@ static void it821x_tune_udma(ide_drive_t *drive, u8 mode_wanted)
 }
 
 /**
- *	it821x_dma_read	-	DMA hook
+ *	it821x_dma_start	-	DMA hook
  *	@drive: drive for DMA
  *
  *	The IT821x has a single timing register for MWDMA and for PIO
@@ -372,7 +372,7 @@ static void it821x_dma_start(ide_drive_t *drive)
 }
 
 /**
- *	it821x_dma_write	-	DMA hook
+ *	it821x_dma_end	-	DMA hook
  *	@drive: drive for DMA stop
  *
  *	The IT821x has a single timing register for MWDMA and for PIO
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH 13/21] ide: siimage: Fix some incorrectly documented functions/params
  2021-06-02 10:17 [PATCH 00/21] Rid W=1 warnings from IDE Lee Jones
                   ` (11 preceding siblings ...)
  2021-06-02 10:17 ` [PATCH 12/21] ide: it821x: Fix a couple of incorrectly documented functions Lee Jones
@ 2021-06-02 10:17 ` Lee Jones
  2021-06-02 10:17 ` [PATCH 14/21] ide: via82cxxx: Fix misdocumentation of via_set_speed()'s 'hwif' param Lee Jones
                   ` (8 subsequent siblings)
  21 siblings, 0 replies; 25+ messages in thread
From: Lee Jones @ 2021-06-02 10:17 UTC (permalink / raw)
  To: lee.jones; +Cc: linux-kernel, David S. Miller, Andre Hedrick, linux-ide

Fixes the following W=1 kernel build warning(s):

 drivers/ide/siimage.c:115: warning: Function parameter or member 'drive' not described in 'siimage_seldev'
 drivers/ide/siimage.c:115: warning: Excess function parameter 'hwif' description in 'siimage_seldev'
 drivers/ide/siimage.c:196: warning: expecting prototype for sil_udma_filter(). Prototype was for sil_pata_udma_filter() instead

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Andre Hedrick <andre@linux-ide.org>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/ide/siimage.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ide/siimage.c b/drivers/ide/siimage.c
index c190dc6dfb50a..64fa6b253a824 100644
--- a/drivers/ide/siimage.c
+++ b/drivers/ide/siimage.c
@@ -103,7 +103,7 @@ static unsigned long siimage_selreg(ide_hwif_t *hwif, int r)
 
 /**
  *	siimage_seldev		-	return register base
- *	@hwif: interface
+ *	@drive: interface
  *	@r: config offset
  *
  *	Turn a config register offset into the right address in either
@@ -183,7 +183,7 @@ static void sil_iowrite32(struct pci_dev *dev, u32 val, unsigned long addr)
 }
 
 /**
- *	sil_udma_filter		-	compute UDMA mask
+ *	sil_pata_udma_filter		-	compute UDMA mask
  *	@drive: IDE device
  *
  *	Compute the available UDMA speeds for the device on the interface.
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH 14/21] ide: via82cxxx: Fix misdocumentation of via_set_speed()'s 'hwif' param
  2021-06-02 10:17 [PATCH 00/21] Rid W=1 warnings from IDE Lee Jones
                   ` (12 preceding siblings ...)
  2021-06-02 10:17 ` [PATCH 13/21] ide: siimage: Fix some incorrectly documented functions/params Lee Jones
@ 2021-06-02 10:17 ` Lee Jones
  2021-06-02 10:17 ` [PATCH 15/21] ide: ide-cd_ioctl: Remove unused variable 'stat' Lee Jones
                   ` (7 subsequent siblings)
  21 siblings, 0 replies; 25+ messages in thread
From: Lee Jones @ 2021-06-02 10:17 UTC (permalink / raw)
  To: lee.jones; +Cc: linux-kernel, David S. Miller, linux-ide

Fixes the following W=1 kernel build warning(s):

 drivers/ide/via82cxxx.c:122: warning: Function parameter or member 'hwif' not described in 'via_set_speed'
 drivers/ide/via82cxxx.c:122: warning: Excess function parameter 'dev' description in 'via_set_speed'

Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/ide/via82cxxx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ide/via82cxxx.c b/drivers/ide/via82cxxx.c
index 166feaeed6e38..9beb25cfa5436 100644
--- a/drivers/ide/via82cxxx.c
+++ b/drivers/ide/via82cxxx.c
@@ -111,7 +111,7 @@ struct via82cxxx_dev
 
 /**
  *	via_set_speed			-	write timing registers
- *	@dev: PCI device
+ *	@hwif: IDE interface
  *	@dn: device
  *	@timing: IDE timing data to use
  *
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH 15/21] ide: ide-cd_ioctl: Remove unused variable 'stat'
  2021-06-02 10:17 [PATCH 00/21] Rid W=1 warnings from IDE Lee Jones
                   ` (13 preceding siblings ...)
  2021-06-02 10:17 ` [PATCH 14/21] ide: via82cxxx: Fix misdocumentation of via_set_speed()'s 'hwif' param Lee Jones
@ 2021-06-02 10:17 ` Lee Jones
  2021-06-02 10:17 ` [PATCH 16/21] ide: ide-cd: Demote kernel-doc abuse Lee Jones
                   ` (6 subsequent siblings)
  21 siblings, 0 replies; 25+ messages in thread
From: Lee Jones @ 2021-06-02 10:17 UTC (permalink / raw)
  To: lee.jones
  Cc: linux-kernel, David S. Miller, Scott Snyder, Erik Andersen,
	Jens Axboe, linux-ide

Fixes the following W=1 kernel build warning(s):

 drivers/ide/ide-cd_ioctl.c: In function ‘ide_cdrom_select_speed’:
 drivers/ide/ide-cd_ioctl.c:212:6: warning: variable ‘stat’ set but not used [-Wunused-but-set-variable]

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Scott Snyder <snyder@fnald0.fnal.gov>
Cc: Erik Andersen <andersee@debian.org>
Cc: Jens Axboe <axboe@suse.de>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/ide/ide-cd_ioctl.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/ide/ide-cd_ioctl.c b/drivers/ide/ide-cd_ioctl.c
index 011eab9c69b7e..22ec8b7a6b90f 100644
--- a/drivers/ide/ide-cd_ioctl.c
+++ b/drivers/ide/ide-cd_ioctl.c
@@ -209,7 +209,6 @@ int ide_cdrom_select_speed(struct cdrom_device_info *cdi, int speed)
 	ide_drive_t *drive = cdi->handle;
 	struct cdrom_info *cd = drive->driver_data;
 	u8 buf[ATAPI_CAPABILITIES_PAGE_SIZE];
-	int stat;
 	unsigned char cmd[BLK_MAX_CDB];
 
 	if (speed == 0)
@@ -230,7 +229,7 @@ int ide_cdrom_select_speed(struct cdrom_device_info *cdi, int speed)
 		cmd[5] = speed & 0xff;
 	}
 
-	stat = ide_cd_queue_pc(drive, cmd, 0, NULL, NULL, NULL, 0, 0);
+	ide_cd_queue_pc(drive, cmd, 0, NULL, NULL, NULL, 0, 0);
 
 	if (!ide_cdrom_get_capabilities(drive, buf)) {
 		ide_cdrom_update_speed(drive, buf);
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH 16/21] ide: ide-cd: Demote kernel-doc abuse
  2021-06-02 10:17 [PATCH 00/21] Rid W=1 warnings from IDE Lee Jones
                   ` (14 preceding siblings ...)
  2021-06-02 10:17 ` [PATCH 15/21] ide: ide-cd_ioctl: Remove unused variable 'stat' Lee Jones
@ 2021-06-02 10:17 ` Lee Jones
  2021-06-02 10:17 ` [PATCH 17/21] ide: ide-acpi: Mark debugging variable 'bus' as __maybe_unused Lee Jones
                   ` (5 subsequent siblings)
  21 siblings, 0 replies; 25+ messages in thread
From: Lee Jones @ 2021-06-02 10:17 UTC (permalink / raw)
  To: lee.jones
  Cc: linux-kernel, David S. Miller, Scott Snyder, Erik Andersen,
	Jens Axboe, linux-ide

Fixes the following W=1 kernel build warning(s):

 drivers/ide/ide-cd.c:285: warning: Function parameter or member 'drive' not described in 'cdrom_decode_status'
 drivers/ide/ide-cd.c:285: warning: Function parameter or member 'stat' not described in 'cdrom_decode_status'
 drivers/ide/ide-cd.c:285: warning: expecting prototype for Returns(). Prototype was for cdrom_decode_status() instead

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Scott Snyder <snyder@fnald0.fnal.gov>
Cc: Erik Andersen <andersee@debian.org>
Cc: Jens Axboe <axboe@suse.de>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/ide/ide-cd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
index cffbcc27a34cc..5adbb22116fe1 100644
--- a/drivers/ide/ide-cd.c
+++ b/drivers/ide/ide-cd.c
@@ -275,7 +275,7 @@ static void ide_cd_free_sense(ide_drive_t *drive)
 	drive->sense_rq_armed = false;
 }
 
-/**
+/*
  * Returns:
  * 0: if the request should be continued.
  * 1: if the request will be going through error recovery.
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH 17/21] ide: ide-acpi: Mark debugging variable 'bus' as __maybe_unused
  2021-06-02 10:17 [PATCH 00/21] Rid W=1 warnings from IDE Lee Jones
                   ` (15 preceding siblings ...)
  2021-06-02 10:17 ` [PATCH 16/21] ide: ide-cd: Demote kernel-doc abuse Lee Jones
@ 2021-06-02 10:17 ` Lee Jones
  2021-06-02 10:17 ` [PATCH 18/21] ide: ide-io: Document ide_intr()'s param 'irq' Lee Jones
                   ` (4 subsequent siblings)
  21 siblings, 0 replies; 25+ messages in thread
From: Lee Jones @ 2021-06-02 10:17 UTC (permalink / raw)
  To: lee.jones; +Cc: linux-kernel, David S. Miller, linux-ide

Fixes the following W=1 kernel build warning(s):

 drivers/ide/ide-acpi.c: In function ‘ide_get_dev_handle’:
 drivers/ide/ide-acpi.c:126:15: warning: variable ‘bus’ set but not used [-Wunused-but-set-variable]

Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/ide/ide-acpi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/ide/ide-acpi.c b/drivers/ide/ide-acpi.c
index 9a4ec281b9854..816ebbbf699b5 100644
--- a/drivers/ide/ide-acpi.c
+++ b/drivers/ide/ide-acpi.c
@@ -123,7 +123,8 @@ static int ide_get_dev_handle(struct device *dev, acpi_handle *handle,
 			       u64 *pcidevfn)
 {
 	struct pci_dev *pdev = to_pci_dev(dev);
-	unsigned int bus, devnum, func;
+	unsigned int __maybe_unused bus;
+	unsigned int devnum, func;
 	u64 addr;
 	acpi_handle dev_handle;
 	acpi_status status;
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH 18/21] ide: ide-io: Document ide_intr()'s param 'irq'
  2021-06-02 10:17 [PATCH 00/21] Rid W=1 warnings from IDE Lee Jones
                   ` (16 preceding siblings ...)
  2021-06-02 10:17 ` [PATCH 17/21] ide: ide-acpi: Mark debugging variable 'bus' as __maybe_unused Lee Jones
@ 2021-06-02 10:17 ` Lee Jones
  2021-06-02 10:17 ` [PATCH 19/21] ide: piix: Fix incorrectly documented param 'hwif' Lee Jones
                   ` (3 subsequent siblings)
  21 siblings, 0 replies; 25+ messages in thread
From: Lee Jones @ 2021-06-02 10:17 UTC (permalink / raw)
  To: lee.jones; +Cc: linux-kernel, David S. Miller, linux-ide

Fixes the following W=1 kernel build warning(s):

 drivers/ide/ide-io.c:775: warning: Function parameter or member 'irq' not described in 'ide_intr'

Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/ide/ide-io.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c
index bd3e78985bcc7..129d036645f85 100644
--- a/drivers/ide/ide-io.c
+++ b/drivers/ide/ide-io.c
@@ -750,6 +750,7 @@ static void unexpected_intr(int irq, ide_hwif_t *hwif)
 
 /**
  *	ide_intr	-	default IDE interrupt handler
+ *	@irq: IRQ number
  *	@dev_id: hwif
  *
  *	This is the default IRQ handler for the IDE layer. You should
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH 19/21] ide: piix: Fix incorrectly documented param 'hwif'
  2021-06-02 10:17 [PATCH 00/21] Rid W=1 warnings from IDE Lee Jones
                   ` (17 preceding siblings ...)
  2021-06-02 10:17 ` [PATCH 18/21] ide: ide-io: Document ide_intr()'s param 'irq' Lee Jones
@ 2021-06-02 10:17 ` Lee Jones
  2021-06-02 10:17 ` [PATCH 20/21] ide: ide-acpi: Provide missing description for param 'obj_loc' Lee Jones
                   ` (2 subsequent siblings)
  21 siblings, 0 replies; 25+ messages in thread
From: Lee Jones @ 2021-06-02 10:17 UTC (permalink / raw)
  To: lee.jones
  Cc: linux-kernel, David S. Miller, Andre Hedrick, Software, Inc, linux-ide

Fixes the following W=1 kernel build warning(s):

 drivers/ide/piix.c:69: warning: Function parameter or member 'hwif' not described in 'piix_set_pio_mode'
 drivers/ide/piix.c:69: warning: Excess function parameter 'port' description in 'piix_set_pio_mode'

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Andre Hedrick <andre@linux-ide.org>
Cc: "Software, Inc" <source@mvista.com>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/ide/piix.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ide/piix.c b/drivers/ide/piix.c
index ede42d2a5b0b1..6a22c281ea90a 100644
--- a/drivers/ide/piix.c
+++ b/drivers/ide/piix.c
@@ -59,7 +59,7 @@ static int no_piix_dma;
 
 /**
  *	piix_set_pio_mode	-	set host controller for PIO mode
- *	@port: port
+ *	@hwif: IDE interface
  *	@drive: drive
  *
  *	Set the interface PIO mode based upon the settings done by AMI BIOS.
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH 20/21] ide: ide-acpi: Provide missing description for param 'obj_loc'
  2021-06-02 10:17 [PATCH 00/21] Rid W=1 warnings from IDE Lee Jones
                   ` (18 preceding siblings ...)
  2021-06-02 10:17 ` [PATCH 19/21] ide: piix: Fix incorrectly documented param 'hwif' Lee Jones
@ 2021-06-02 10:17 ` Lee Jones
  2021-06-02 10:17 ` [PATCH 21/21] ide: pmac: Staticise local function 'pmac_ide_probe' Lee Jones
  2021-06-07  8:26 ` [PATCH 00/21] Rid W=1 warnings from IDE Christoph Hellwig
  21 siblings, 0 replies; 25+ messages in thread
From: Lee Jones @ 2021-06-02 10:17 UTC (permalink / raw)
  To: lee.jones; +Cc: linux-kernel, David S. Miller, linux-ide

Fixes the following W=1 kernel build warning(s):

 drivers/ide/ide-acpi.c:229: warning: Function parameter or member 'obj_loc' not described in 'do_drive_get_GTF'

Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/ide/ide-acpi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ide/ide-acpi.c b/drivers/ide/ide-acpi.c
index 816ebbbf699b5..fd80789722bbe 100644
--- a/drivers/ide/ide-acpi.c
+++ b/drivers/ide/ide-acpi.c
@@ -214,6 +214,7 @@ static acpi_handle ide_acpi_hwif_get_handle(ide_hwif_t *hwif)
  * @drive: the drive for which the taskfile settings should be retrieved
  * @gtf_length: number of bytes of _GTF data returned at @gtf_address
  * @gtf_address: buffer containing _GTF taskfile arrays
+ * @obj_loc: placeholder for return data
  *
  * The _GTF method has no input parameters.
  * It returns a variable number of register set values (registers
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* [PATCH 21/21] ide: pmac: Staticise local function 'pmac_ide_probe'
  2021-06-02 10:17 [PATCH 00/21] Rid W=1 warnings from IDE Lee Jones
                   ` (19 preceding siblings ...)
  2021-06-02 10:17 ` [PATCH 20/21] ide: ide-acpi: Provide missing description for param 'obj_loc' Lee Jones
@ 2021-06-02 10:17 ` Lee Jones
  2021-06-07  8:26 ` [PATCH 00/21] Rid W=1 warnings from IDE Christoph Hellwig
  21 siblings, 0 replies; 25+ messages in thread
From: Lee Jones @ 2021-06-02 10:17 UTC (permalink / raw)
  To: lee.jones
  Cc: linux-kernel, David S. Miller, Michael Ellerman,
	Benjamin Herrenschmidt, Paul Mackerras, linux-ide, linuxppc-dev

Fixes the following W=1 kernel build warning(s):

 drivers/ide/pmac.c:1418:12: warning: no previous prototype for ‘pmac_ide_probe’ [-Wmissing-prototypes]

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: linux-ide@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/ide/pmac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c
index ea0b064b5f56b..d51a2e252b6f2 100644
--- a/drivers/ide/pmac.c
+++ b/drivers/ide/pmac.c
@@ -1415,7 +1415,7 @@ static struct pci_driver pmac_ide_pci_driver = {
 };
 MODULE_DEVICE_TABLE(pci, pmac_ide_pci_match);
 
-int __init pmac_ide_probe(void)
+static int __init pmac_ide_probe(void)
 {
 	int error;
 
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 25+ messages in thread

* Re: [PATCH 00/21] Rid W=1 warnings from IDE
  2021-06-02 10:17 [PATCH 00/21] Rid W=1 warnings from IDE Lee Jones
                   ` (20 preceding siblings ...)
  2021-06-02 10:17 ` [PATCH 21/21] ide: pmac: Staticise local function 'pmac_ide_probe' Lee Jones
@ 2021-06-07  8:26 ` Christoph Hellwig
  2021-06-14  9:12   ` Lee Jones
  21 siblings, 1 reply; 25+ messages in thread
From: Christoph Hellwig @ 2021-06-07  8:26 UTC (permalink / raw)
  To: Lee Jones
  Cc: linux-kernel, Adrian Sun, Alan Cox, Andre Hedrick,
	Benjamin Herrenschmidt, Benoit Poulot-Cazajous,
	Christian Brunner, Christopher J. Reimer, CJ, Clear Zhang,
	David S. Miller, Duncan Laurie, Erik Andersen, Frank Tiernan,
	Gadi Oxman, Jens Axboe, linux-ide, linuxppc-dev, Mark Lord,
	Michael Ellerman, Mike Waychison, or, Paul Mackerras,
	Robert Bringman, Scott Snyder, Sergei Shtylyov, Tim Hockin

Please don't touch this code as it is about to be removed entirely.

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH 00/21] Rid W=1 warnings from IDE
  2021-06-07  8:26 ` [PATCH 00/21] Rid W=1 warnings from IDE Christoph Hellwig
@ 2021-06-14  9:12   ` Lee Jones
  2021-06-16 13:52     ` Christoph Hellwig
  0 siblings, 1 reply; 25+ messages in thread
From: Lee Jones @ 2021-06-14  9:12 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: linux-kernel, Adrian Sun, Alan Cox, Andre Hedrick,
	Benjamin Herrenschmidt, Benoit Poulot-Cazajous,
	Christian Brunner, Christopher J. Reimer, CJ, Clear Zhang,
	David S. Miller, Duncan Laurie, Erik Andersen, Frank Tiernan,
	Gadi Oxman, Jens Axboe, linux-ide, linuxppc-dev, Mark Lord,
	Michael Ellerman, Mike Waychison, or, Paul Mackerras,
	Robert Bringman, Scott Snyder, Sergei Shtylyov, Tim Hockin

On Mon, 07 Jun 2021, Christoph Hellwig wrote:

> Please don't touch this code as it is about to be removed entirely.

Do you have an ETA for this work?

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 25+ messages in thread

* Re: [PATCH 00/21] Rid W=1 warnings from IDE
  2021-06-14  9:12   ` Lee Jones
@ 2021-06-16 13:52     ` Christoph Hellwig
  0 siblings, 0 replies; 25+ messages in thread
From: Christoph Hellwig @ 2021-06-16 13:52 UTC (permalink / raw)
  To: Lee Jones
  Cc: Christoph Hellwig, linux-kernel, Adrian Sun, Alan Cox,
	Andre Hedrick, Benjamin Herrenschmidt, Benoit Poulot-Cazajous,
	Christian Brunner, Christopher J. Reimer, CJ, Clear Zhang,
	David S. Miller, Duncan Laurie, Erik Andersen, Frank Tiernan,
	Gadi Oxman, Jens Axboe, linux-ide, linuxppc-dev, Mark Lord,
	Michael Ellerman, Mike Waychison, or, Paul Mackerras,
	Robert Bringman, Scott Snyder, Sergei Shtylyov, Tim Hockin

On Mon, Jun 14, 2021 at 10:12:28AM +0100, Lee Jones wrote:
> On Mon, 07 Jun 2021, Christoph Hellwig wrote:
> 
> > Please don't touch this code as it is about to be removed entirely.
> 
> Do you have an ETA for this work?

I just resent the series.

^ permalink raw reply	[flat|nested] 25+ messages in thread

end of thread, other threads:[~2021-06-16 13:54 UTC | newest]

Thread overview: 25+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-02 10:17 [PATCH 00/21] Rid W=1 warnings from IDE Lee Jones
2021-06-02 10:17 ` [PATCH 01/21] ide: alim15x3: Document alim15x3_init_one()'s 'id' param Lee Jones
2021-06-02 10:17 ` [PATCH 02/21] ide: ide-dma: Document ide_dma_unmap_sg()'s missing 'cmd' param Lee Jones
2021-06-02 10:17 ` [PATCH 03/21] ide: ide-dma-sff: Provide some missing 'param' descriptions Lee Jones
2021-06-02 10:17 ` [PATCH 04/21] ide: ide-io: Fix a few kernel-doc misdemeanours Lee Jones
2021-06-02 10:17 ` [PATCH 05/21] ide: ide-proc: Strip out unused fops structure and accompanying call-back Lee Jones
2021-06-02 10:17 ` [PATCH 06/21] ide: cs5530: Fix incorrect documentation for function init_chipset_cs5530() Lee Jones
2021-06-02 10:17 ` [PATCH 07/21] ide: ide-probe: Fix-up incorrectly documented function probe_for_drive() Lee Jones
2021-06-02 10:17 ` [PATCH 08/21] ide: hpt366: Provide some missing descriptions for 'f_{low,high}' Lee Jones
2021-06-02 10:17 ` [PATCH 09/21] ide: piix: Remove unused variable 'sitre' Lee Jones
2021-06-02 10:17 ` [PATCH 10/21] ide: pdc202xx_new: Supply missing description for 'set_indexed_reg()'s 'value' param Lee Jones
2021-06-02 10:17 ` [PATCH 11/21] ide: slc90e66: Remove unused variable 'sitre' Lee Jones
2021-06-02 10:17 ` [PATCH 12/21] ide: it821x: Fix a couple of incorrectly documented functions Lee Jones
2021-06-02 10:17 ` [PATCH 13/21] ide: siimage: Fix some incorrectly documented functions/params Lee Jones
2021-06-02 10:17 ` [PATCH 14/21] ide: via82cxxx: Fix misdocumentation of via_set_speed()'s 'hwif' param Lee Jones
2021-06-02 10:17 ` [PATCH 15/21] ide: ide-cd_ioctl: Remove unused variable 'stat' Lee Jones
2021-06-02 10:17 ` [PATCH 16/21] ide: ide-cd: Demote kernel-doc abuse Lee Jones
2021-06-02 10:17 ` [PATCH 17/21] ide: ide-acpi: Mark debugging variable 'bus' as __maybe_unused Lee Jones
2021-06-02 10:17 ` [PATCH 18/21] ide: ide-io: Document ide_intr()'s param 'irq' Lee Jones
2021-06-02 10:17 ` [PATCH 19/21] ide: piix: Fix incorrectly documented param 'hwif' Lee Jones
2021-06-02 10:17 ` [PATCH 20/21] ide: ide-acpi: Provide missing description for param 'obj_loc' Lee Jones
2021-06-02 10:17 ` [PATCH 21/21] ide: pmac: Staticise local function 'pmac_ide_probe' Lee Jones
2021-06-07  8:26 ` [PATCH 00/21] Rid W=1 warnings from IDE Christoph Hellwig
2021-06-14  9:12   ` Lee Jones
2021-06-16 13:52     ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).