From: Christoph Hellwig <hch@lst.de> To: "David S. Miller" <davem@davemloft.net>, Jens Axboe <axboe@kernel.dk>, Geert Uytterhoeven <geert@linux-m68k.org> Cc: Richard Henderson <rth@twiddle.net>, Ivan Kokshaysky <ink@jurassic.park.msu.ru>, Matt Turner <mattst88@gmail.com>, Russell King <linux@armlinux.org.uk>, Michael Ellerman <mpe@ellerman.id.au>, Linus Torvalds <torvalds@linux-foundation.org>, linux-ide@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-m68k@lists.linux-m68k.org Subject: [PATCH 1/6] pata_cypress: add a module option to disable BM-DMA Date: Wed, 16 Jun 2021 15:46:53 +0200 [thread overview] Message-ID: <20210616134658.1471835-2-hch@lst.de> (raw) In-Reply-To: <20210616134658.1471835-1-hch@lst.de> Multiple users report that they need to disable DMA on this driver, so provide an option to do so without affecting all of libata. Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/ata/pata_cypress.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/ata/pata_cypress.c b/drivers/ata/pata_cypress.c index e1486fe298ae..5b3a7a8ebef6 100644 --- a/drivers/ata/pata_cypress.c +++ b/drivers/ata/pata_cypress.c @@ -41,6 +41,10 @@ enum { CY82_INDEX_TIMEOUT = 0x32 }; +static bool enable_dma = true; +module_param(enable_dma, bool, 0); +MODULE_PARM_DESC(enable_dma, "Enable bus master DMA operations"); + /** * cy82c693_set_piomode - set initial PIO mode data * @ap: ATA interface @@ -124,14 +128,16 @@ static struct ata_port_operations cy82c693_port_ops = { static int cy82c693_init_one(struct pci_dev *pdev, const struct pci_device_id *id) { - static const struct ata_port_info info = { + static struct ata_port_info info = { .flags = ATA_FLAG_SLAVE_POSS, .pio_mask = ATA_PIO4, - .mwdma_mask = ATA_MWDMA2, .port_ops = &cy82c693_port_ops }; const struct ata_port_info *ppi[] = { &info, &ata_dummy_port_info }; + if (enable_dma) + info.mwdma_mask = ATA_MWDMA2; + /* Devfn 1 is the ATA primary. The secondary is magic and on devfn2. For the moment we don't handle the secondary. FIXME */ -- 2.30.2
next prev parent reply other threads:[~2021-06-16 13:48 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-16 13:46 remove the legacy ide driver v2 Christoph Hellwig 2021-06-16 13:46 ` Christoph Hellwig [this message] 2021-06-16 14:16 ` [PATCH 1/6] pata_cypress: add a module option to disable BM-DMA Russell King (Oracle) 2021-06-16 13:46 ` [PATCH 2/6] alpha: use libata instead of the legacy ide driver Christoph Hellwig 2021-06-16 13:46 ` [PATCH 3/6] ARM: disable CONFIG_IDE in footbridge_defconfig Christoph Hellwig 2021-06-16 13:46 ` [PATCH 4/6] ARM: disable CONFIG_IDE in pxa_defconfig Christoph Hellwig 2021-06-16 13:46 ` [PATCH 5/6] m68k: use libata instead of the legacy ide driver Christoph Hellwig 2021-06-16 14:03 ` Geert Uytterhoeven 2021-06-16 14:04 ` Christoph Hellwig 2021-06-16 13:51 ` remove the legacy ide driver v2 John Paul Adrian Glaubitz 2021-06-16 13:52 ` Christoph Hellwig 2021-06-16 14:52 ` Jens Axboe 2021-06-18 14:38 ` Jens Axboe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210616134658.1471835-2-hch@lst.de \ --to=hch@lst.de \ --cc=axboe@kernel.dk \ --cc=davem@davemloft.net \ --cc=geert@linux-m68k.org \ --cc=ink@jurassic.park.msu.ru \ --cc=linux-alpha@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-ide@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-m68k@lists.linux-m68k.org \ --cc=linux@armlinux.org.uk \ --cc=mattst88@gmail.com \ --cc=mpe@ellerman.id.au \ --cc=rth@twiddle.net \ --cc=torvalds@linux-foundation.org \ --subject='Re: [PATCH 1/6] pata_cypress: add a module option to disable BM-DMA' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).