linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/5 v2] pata: ixp4xx: Use local dev variable
@ 2021-07-31 21:35 Linus Walleij
  2021-07-31 21:35 ` [PATCH 2/5 v2] pata: ixp4xx: Use IS_ENABLED() to determine endianness Linus Walleij
                   ` (4 more replies)
  0 siblings, 5 replies; 8+ messages in thread
From: Linus Walleij @ 2021-07-31 21:35 UTC (permalink / raw)
  To: Jens Axboe, linux-ide
  Cc: linux-arm-kernel, Imre Kaloz, Krzysztof Halasa, Linus Walleij

Let's simplify all &pdev->dev references by creating a
local struct device *dev variable.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
ChangeLog v1->v2:
- No changes
---
 drivers/ata/pata_ixp4xx_cf.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/ata/pata_ixp4xx_cf.c b/drivers/ata/pata_ixp4xx_cf.c
index 5881d64af943..23f0f7cacd52 100644
--- a/drivers/ata/pata_ixp4xx_cf.c
+++ b/drivers/ata/pata_ixp4xx_cf.c
@@ -139,6 +139,7 @@ static int ixp4xx_pata_probe(struct platform_device *pdev)
 	struct resource *cs0, *cs1;
 	struct ata_host *host;
 	struct ata_port *ap;
+	struct device *dev = &pdev->dev;
 	struct ixp4xx_pata_data *data = dev_get_platdata(&pdev->dev);
 	int ret;
 	int irq;
@@ -150,17 +151,17 @@ static int ixp4xx_pata_probe(struct platform_device *pdev)
 		return -EINVAL;
 
 	/* allocate host */
-	host = ata_host_alloc(&pdev->dev, 1);
+	host = ata_host_alloc(dev, 1);
 	if (!host)
 		return -ENOMEM;
 
 	/* acquire resources and fill host */
-	ret = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32));
+	ret = dma_set_coherent_mask(dev, DMA_BIT_MASK(32));
 	if (ret)
 		return ret;
 
-	data->cs0 = devm_ioremap(&pdev->dev, cs0->start, 0x1000);
-	data->cs1 = devm_ioremap(&pdev->dev, cs1->start, 0x1000);
+	data->cs0 = devm_ioremap(dev, cs0->start, 0x1000);
+	data->cs1 = devm_ioremap(dev, cs1->start, 0x1000);
 
 	if (!data->cs0 || !data->cs1)
 		return -ENOMEM;
@@ -185,7 +186,7 @@ static int ixp4xx_pata_probe(struct platform_device *pdev)
 
 	ixp4xx_setup_port(ap, data, cs0->start, cs1->start);
 
-	ata_print_version_once(&pdev->dev, DRV_VERSION);
+	ata_print_version_once(dev, DRV_VERSION);
 
 	/* activate host */
 	return ata_host_activate(host, irq, ata_sff_interrupt, 0, &ixp4xx_sht);
-- 
2.31.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-08-04 12:40 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-31 21:35 [PATCH 1/5 v2] pata: ixp4xx: Use local dev variable Linus Walleij
2021-07-31 21:35 ` [PATCH 2/5 v2] pata: ixp4xx: Use IS_ENABLED() to determine endianness Linus Walleij
2021-07-31 21:35 ` [PATCH 3/5 v2] pata: ixp4xx: Refer to cmd and ctl rather than csN Linus Walleij
2021-07-31 21:35 ` [PATCH 4/5 v2] pata: ixp4xx: Add DT bindings Linus Walleij
2021-08-02 13:39   ` Rob Herring
2021-08-02 16:30   ` Rob Herring
2021-07-31 21:35 ` [PATCH 5/5 v2] pata: ixp4xx: Rewrite to use device tree Linus Walleij
2021-08-04 12:40 ` [PATCH 1/5 v2] pata: ixp4xx: Use local dev variable Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).