From: Damien Le Moal <damien.lemoal@wdc.com>
To: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-ide@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Cc: Sathya Prakash <sathya.prakash@broadcom.com>,
Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>
Subject: [PATCH v3 1/9] libata: fix ata_host_alloc_pinfo()
Date: Fri, 6 Aug 2021 20:11:37 +0900 [thread overview]
Message-ID: <20210806111145.445697-2-damien.lemoal@wdc.com> (raw)
In-Reply-To: <20210806111145.445697-1-damien.lemoal@wdc.com>
Avoid a potential NULL pointer dereference by testing that the ATA port
info variable "pi".
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
---
drivers/ata/libata-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 61c762961ca8..ea8b91297f12 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -5458,7 +5458,7 @@ struct ata_host *ata_host_alloc_pinfo(struct device *dev,
ap->link.flags |= pi->link_flags;
ap->ops = pi->port_ops;
- if (!host->ops && (pi->port_ops != &ata_dummy_port_ops))
+ if (!host->ops && pi && pi->port_ops != &ata_dummy_port_ops)
host->ops = pi->port_ops;
}
--
2.31.1
next prev parent reply other threads:[~2021-08-06 11:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 11:11 [PATCH v3 0/9] libata cleanups and improvements Damien Le Moal
2021-08-06 11:11 ` Damien Le Moal [this message]
2021-08-06 11:11 ` [PATCH v3 2/9] libata: fix ata_host_start() Damien Le Moal
2021-08-06 11:11 ` [PATCH v3 3/9] libata: cleanup device sleep capability detection Damien Le Moal
2021-08-06 11:11 ` [PATCH v3 4/9] libata: cleanup ata_dev_configure() Damien Le Moal
2021-08-06 11:35 ` Hannes Reinecke
2021-08-06 11:11 ` [PATCH v3 5/9] libata: cleanup NCQ priority handling Damien Le Moal
2021-08-06 11:11 ` [PATCH v3 6/9] libata: fix ata_read_log_page() warning Damien Le Moal
2021-08-06 11:11 ` [PATCH v3 7/9] libata: print feature list on device scan Damien Le Moal
2021-08-06 11:11 ` [PATCH v3 8/9] libahci: Introduce ncq_prio_supported sysfs sttribute Damien Le Moal
2021-08-06 11:37 ` Hannes Reinecke
2021-08-06 12:17 ` Damien Le Moal
2021-08-06 11:11 ` [PATCH v3 9/9] scsi: mpt3sas: Introduce sas_ncq_prio_supported " Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210806111145.445697-2-damien.lemoal@wdc.com \
--to=damien.lemoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sathya.prakash@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
--subject='Re: [PATCH v3 1/9] libata: fix ata_host_alloc_pinfo()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).