linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Add AHCI support for (noname) PCIe sata cards based on ASM1062+JBM575 cards, usually 10 SATA ports or more. DeviceID: 0624 (rev 01)
@ 2021-10-11  8:56 István Pongrácz
  0 siblings, 0 replies; 3+ messages in thread
From: István Pongrácz @ 2021-10-11  8:56 UTC (permalink / raw)
  To: linux-ide, damien.lemoal; +Cc: István Pongrácz

---
 drivers/ata/ahci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 186cbf90c8ea..f8199f021ed4 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -592,6 +592,7 @@ static const struct pci_device_id ahci_pci_tbl[] = {
 	{ PCI_VDEVICE(ASMEDIA, 0x0612), board_ahci },	/* ASM1062 */
 	{ PCI_VDEVICE(ASMEDIA, 0x0621), board_ahci },   /* ASM1061R */
 	{ PCI_VDEVICE(ASMEDIA, 0x0622), board_ahci },   /* ASM1062R */
+	{ PCI_VDEVICE(ASMEDIA, 0x0624), board_ahci },   /* ASMedia Technology Inc. Device 0624 (rev 01) based PCIe port multiplier cards (ex. 10 ports card with 1 x ASM1062 + 2 x JMB575 */
 
 	/*
 	 * Samsung SSDs found on some macbooks.  NCQ times out if MSI is
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Add AHCI support for (noname) PCIe sata cards based on ASM1062+JBM575 cards, usually 10 SATA ports or more. DeviceID: 0624 (rev 01)
  2021-10-11  8:59 István Pongrácz
@ 2021-10-11  9:18 ` Damien Le Moal
  0 siblings, 0 replies; 3+ messages in thread
From: Damien Le Moal @ 2021-10-11  9:18 UTC (permalink / raw)
  To: István Pongrácz, linux-ide

On 2021/10/11 17:59, István Pongrácz wrote:

Your commit title is too lon. Shorten it to:

Add AHCI support for ASM1062+JBM575 cards

And then add a commit message with the details (PCIe card, usually 10 ports,
etc. Whatever information is relevant to describe the hardware.

Also please sign your patch (Add a Signed-off-by: xxx tag). You can do this
automatically by doing a "git commit -s" when creating your patch.

> ---
>  drivers/ata/ahci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 186cbf90c8ea..f8199f021ed4 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -592,6 +592,7 @@ static const struct pci_device_id ahci_pci_tbl[] = {
>  	{ PCI_VDEVICE(ASMEDIA, 0x0612), board_ahci },	/* ASM1062 */
>  	{ PCI_VDEVICE(ASMEDIA, 0x0621), board_ahci },   /* ASM1061R */
>  	{ PCI_VDEVICE(ASMEDIA, 0x0622), board_ahci },   /* ASM1062R */
> +	{ PCI_VDEVICE(ASMEDIA, 0x0624), board_ahci },   /* ASMedia Technology Inc. Device 0624 (rev 01) based PCIe port multiplier cards (ex. 10 ports card with 1 x ASM1062 + 2 x JMB575 */

Line too long. Please shorten the comment to /* ASM1062+JMB575 */

>  
>  	/*
>  	 * Samsung SSDs found on some macbooks.  NCQ times out if MSI is
> 


-- 
Damien Le Moal
Western Digital Research

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] Add AHCI support for (noname) PCIe sata cards based on ASM1062+JBM575 cards, usually 10 SATA ports or more. DeviceID: 0624 (rev 01)
@ 2021-10-11  8:59 István Pongrácz
  2021-10-11  9:18 ` Damien Le Moal
  0 siblings, 1 reply; 3+ messages in thread
From: István Pongrácz @ 2021-10-11  8:59 UTC (permalink / raw)
  To: linux-ide, damien.lemoal; +Cc: István Pongrácz

---
 drivers/ata/ahci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 186cbf90c8ea..f8199f021ed4 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -592,6 +592,7 @@ static const struct pci_device_id ahci_pci_tbl[] = {
 	{ PCI_VDEVICE(ASMEDIA, 0x0612), board_ahci },	/* ASM1062 */
 	{ PCI_VDEVICE(ASMEDIA, 0x0621), board_ahci },   /* ASM1061R */
 	{ PCI_VDEVICE(ASMEDIA, 0x0622), board_ahci },   /* ASM1062R */
+	{ PCI_VDEVICE(ASMEDIA, 0x0624), board_ahci },   /* ASMedia Technology Inc. Device 0624 (rev 01) based PCIe port multiplier cards (ex. 10 ports card with 1 x ASM1062 + 2 x JMB575 */
 
 	/*
 	 * Samsung SSDs found on some macbooks.  NCQ times out if MSI is
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-11  9:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-11  8:56 [PATCH] Add AHCI support for (noname) PCIe sata cards based on ASM1062+JBM575 cards, usually 10 SATA ports or more. DeviceID: 0624 (rev 01) István Pongrácz
2021-10-11  8:59 István Pongrácz
2021-10-11  9:18 ` Damien Le Moal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).