From: "Reimar Döffinger" <Reimar.Doeffinger@gmx.de>
To: Damien Le Moal <Damien.LeMoal@wdc.com>,
linux-ide@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
hch@infradead.org, Paul Menzel <pmenzel@molgen.mpg.de>
Subject: [PATCH v5] Fixes to DMA state check
Date: Tue, 12 Oct 2021 08:27:43 +0200 [thread overview]
Message-ID: <20211012062749.4728-1-Reimar.Doeffinger@gmx.de> (raw)
Patch series to add ata_dma_enabled calls instead of incorrectly
checking dev->dma_mode != 0.
Only the first patch is confirmed to have caused real issues
that it indeed fixes, rest based purely on code review.
Changes v5:
Add stable Cc to first patch, which is confirmed to fix
issues seen by users.
Changes v4:
- split per file/driver
- added Signed-off-by and Tested-by lines, improved commit messages
Changes v3:
- found and updated more cases in pata_ali, pata_amd and pata_radisys.
Changes v2:
- removed initialization change for SATA. I got confused by the
ping-pong between libata-eh and libata-core and thought SATA did not
set up xfermode
- reviewed other cases that used dma_mode in boolean context and those
seemed to need changing as well, so added them to patch.
I did not see any places that would set dma_mode to 0 ever, so I
do think they were all indeed wrong.
next reply other threads:[~2021-10-12 6:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 6:27 Reimar Döffinger [this message]
2021-10-12 6:27 ` [PATCH 1/6] libata: fix checking of DMA state Reimar Döffinger
2021-10-12 6:27 ` [PATCH 2/6] libata-scsi: " Reimar Döffinger
2021-10-12 6:27 ` [PATCH 3/6] pata_ali: " Reimar Döffinger
2021-10-12 6:27 ` [PATCH 4/6] pata_amd: " Reimar Döffinger
2021-10-12 6:27 ` [PATCH 5/6] pata_optidma: " Reimar Döffinger
2021-10-12 6:27 ` [PATCH 6/6] pata_radisys: " Reimar Döffinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211012062749.4728-1-Reimar.Doeffinger@gmx.de \
--to=reimar.doeffinger@gmx.de \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).