From: kernel test robot <lkp@intel.com>
To: Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Hans de Goede <hdegoede@redhat.com>, Jens Axboe <axboe@kernel.dk>,
Hannes Reinecke <hare@suse.de>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
Rob Herring <robh+dt@kernel.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v5 07/23] ata: libahci_platform: Convert to using devm bulk clocks API
Date: Fri, 15 Jul 2022 04:58:44 +0800 [thread overview]
Message-ID: <202207150410.A4kg5upp-lkp@intel.com> (raw)
In-Reply-To: <20220713052917.27036-8-Sergey.Semin@baikalelectronics.ru>
Hi Serge,
I love your patch! Yet something to improve:
[auto build test ERROR on robh/for-next]
[also build test ERROR on axboe-block/for-next linus/master v5.19-rc6 next-20220714]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Serge-Semin/ata-ahci-Add-DWC-Baikal-T1-AHCI-SATA-support/20220713-133437
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: riscv-randconfig-r004-20220714 (https://download.01.org/0day-ci/archive/20220715/202207150410.A4kg5upp-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 5e61b9c556267086ef9b743a0b57df302eef831b)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/7225145d9ff95641c04bdc1dd85915be6cd5ce57
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Serge-Semin/ata-ahci-Add-DWC-Baikal-T1-AHCI-SATA-support/20220713-133437
git checkout 7225145d9ff95641c04bdc1dd85915be6cd5ce57
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/ata/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/ata/ahci_dm816.c:72:6: error: invalid argument type 'struct clk_bulk_data' to unary expression
if (!hpriv->clks[1]) {
^~~~~~~~~~~~~~~
>> drivers/ata/ahci_dm816.c:77:29: error: passing 'struct clk_bulk_data' to parameter of incompatible type 'struct clk *'
refclk_rate = clk_get_rate(hpriv->clks[1]);
^~~~~~~~~~~~~~
include/linux/clk.h:584:40: note: passing argument to parameter 'clk' here
unsigned long clk_get_rate(struct clk *clk);
^
2 errors generated.
vim +72 drivers/ata/ahci_dm816.c
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 60
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 61 static int ahci_dm816_phy_init(struct ahci_host_priv *hpriv, struct device *dev)
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 62 {
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 63 unsigned long refclk_rate;
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 64 int mpy;
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 65 u32 val;
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 66
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 67 /*
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 68 * We should have been supplied two clocks: the functional and
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 69 * keep-alive clock and the external reference clock. We need the
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 70 * rate of the latter to calculate the correct value of MPY bits.
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 71 */
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 @72 if (!hpriv->clks[1]) {
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 73 dev_err(dev, "reference clock not supplied\n");
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 74 return -EINVAL;
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 75 }
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 76
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 @77 refclk_rate = clk_get_rate(hpriv->clks[1]);
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 78 if ((refclk_rate % 100) != 0) {
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 79 dev_err(dev, "reference clock rate must be divisible by 100\n");
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 80 return -EINVAL;
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 81 }
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 82
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 83 mpy = ahci_dm816_get_mpy_bits(refclk_rate);
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 84 if (mpy < 0) {
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 85 dev_err(dev, "can't calculate the MPY bits value\n");
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 86 return -EINVAL;
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 87 }
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 88
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 89 /* Enable the PHY and configure the first HBA port. */
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 90 val = AHCI_DM816_PHY_MPY(mpy) | AHCI_DM816_PHY_LOS(1) |
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 91 AHCI_DM816_PHY_RXCDR(4) | AHCI_DM816_PHY_RXEQ(1) |
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 92 AHCI_DM816_PHY_TXSWING(3) | AHCI_DM816_PHY_ENPLL(1);
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 93 writel(val, hpriv->mmio + AHCI_DM816_P0PHYCR_REG);
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 94
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 95 /* Configure the second HBA port. */
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 96 val = AHCI_DM816_PHY_LOS(1) | AHCI_DM816_PHY_RXCDR(4) |
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 97 AHCI_DM816_PHY_RXEQ(1) | AHCI_DM816_PHY_TXSWING(3);
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 98 writel(val, hpriv->mmio + AHCI_DM816_P1PHYCR_REG);
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 99
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 100 return 0;
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 101 }
df46e6a4c06c89a Bartosz Golaszewski 2017-03-14 102
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-07-14 20:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 5:28 [PATCH v5 00/23] ata: ahci: Add DWC/Baikal-T1 AHCI SATA support Serge Semin
2022-07-13 5:28 ` [PATCH v5 01/23] dt-bindings: ata: ahci-platform: Move dma-coherent to sata-common.yaml Serge Semin
2022-07-13 5:28 ` [PATCH v5 02/23] dt-bindings: ata: ahci-platform: Detach common AHCI bindings Serge Semin
2022-07-13 5:28 ` [PATCH v5 03/23] dt-bindings: ata: ahci-platform: Clarify common AHCI props constraints Serge Semin
2022-07-13 5:28 ` [PATCH v5 04/23] dt-bindings: ata: sata: Extend number of SATA ports Serge Semin
2022-07-13 5:28 ` [PATCH v5 05/23] dt-bindings: ata: sata-brcm: Apply common AHCI schema Serge Semin
2022-07-13 5:28 ` [PATCH v5 06/23] ata: libahci_platform: Convert to using platform devm-ioremap methods Serge Semin
2022-07-13 5:29 ` [PATCH v5 07/23] ata: libahci_platform: Convert to using devm bulk clocks API Serge Semin
2022-07-14 20:58 ` kernel test robot [this message]
2022-07-13 5:29 ` [PATCH v5 08/23] ata: libahci_platform: Sanity check the DT child nodes number Serge Semin
2022-07-13 5:29 ` [PATCH v5 09/23] ata: libahci_platform: Parse ports-implemented property in resources getter Serge Semin
2022-07-13 5:29 ` [PATCH v5 10/23] ata: libahci_platform: Introduce reset assertion/deassertion methods Serge Semin
2022-07-13 5:29 ` [PATCH v5 11/23] dt-bindings: ata: ahci: Add platform capability properties Serge Semin
2022-07-13 5:29 ` [PATCH v5 12/23] ata: libahci: Extend port-cmd flags set with port capabilities Serge Semin
2022-07-13 5:29 ` [PATCH v5 13/23] ata: libahci: Discard redundant force_port_map parameter Serge Semin
2022-07-13 5:29 ` [PATCH v5 14/23] ata: libahci: Don't read AHCI version twice in the save-config method Serge Semin
2022-07-13 5:29 ` [PATCH v5 15/23] ata: ahci: Convert __ahci_port_base to accepting hpriv as arguments Serge Semin
2022-07-13 5:29 ` [PATCH v5 16/23] ata: ahci: Introduce firmware-specific caps initialization Serge Semin
2022-07-13 5:29 ` [PATCH v5 17/23] dt-bindings: ata: ahci: Add DWC AHCI SATA controller DT schema Serge Semin
2022-07-18 20:33 ` Rob Herring
2022-07-13 5:29 ` [PATCH v5 18/23] ata: libahci_platform: Add function returning a clock-handle by id Serge Semin
2022-07-13 5:29 ` [PATCH v5 19/23] ata: ahci: Add DWC AHCI SATA controller support Serge Semin
2022-07-13 5:29 ` [PATCH v5 20/23] dt-bindings: ata: ahci: Add Baikal-T1 AHCI SATA controller DT schema Serge Semin
2022-07-18 20:34 ` Rob Herring
2022-07-13 5:29 ` [PATCH v5 21/23] ata: ahci-dwc: Add platform-specific quirks support Serge Semin
2022-07-13 5:29 ` [PATCH v5 22/23] ata: ahci-dwc: Add Baikal-T1 AHCI SATA interface support Serge Semin
2022-07-13 5:29 ` [PATCH v5 23/23] MAINTAINERS: Add maintainers for DWC AHCI SATA driver Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202207150410.A4kg5upp-lkp@intel.com \
--to=lkp@intel.com \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Pavel.Parkhomenko@baikalelectronics.ru \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=devicetree@vger.kernel.org \
--cc=hare@suse.de \
--cc=hdegoede@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).