From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: linux-ide@vger.kernel.org, Ondrej Zary <linux@zary.sk>
Cc: Sergey Shtylyov <s.shtylyov@omp.ru>
Subject: [PATCH 2/2] ata: pata_parport-bpck6: Declare mode_map as static
Date: Thu, 23 Mar 2023 12:38:36 +0900 [thread overview]
Message-ID: <20230323033836.352672-3-damien.lemoal@opensource.wdc.com> (raw)
In-Reply-To: <20230323033836.352672-1-damien.lemoal@opensource.wdc.com>
Compilation C=1 of the bpck6 protocol module generates the following
message:
drivers/ata/pata_parport/bpck6.c:62:5: warning: symbol 'mode_map' was
not declared. Should it be static?
Fix this by declaring mode_map as static.
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
drivers/ata/pata_parport/bpck6.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/pata_parport/bpck6.c b/drivers/ata/pata_parport/bpck6.c
index 295dbe5cdaa4..76febd07a9bb 100644
--- a/drivers/ata/pata_parport/bpck6.c
+++ b/drivers/ata/pata_parport/bpck6.c
@@ -59,8 +59,8 @@
#define PPCMODE_EPP_WORD 5
#define PPCMODE_EPP_DWORD 6
-int mode_map[] = { PPCMODE_UNI_FW, PPCMODE_BI_FW, PPCMODE_EPP_BYTE,
- PPCMODE_EPP_WORD, PPCMODE_EPP_DWORD };
+static int mode_map[] = { PPCMODE_UNI_FW, PPCMODE_BI_FW, PPCMODE_EPP_BYTE,
+ PPCMODE_EPP_WORD, PPCMODE_EPP_DWORD };
static void bpck6_send_cmd(struct pi_adapter *pi, u8 cmd)
{
--
2.39.2
next prev parent reply other threads:[~2023-03-23 3:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 3:38 [PATCH 0/2] Fixes for pata parport bpck6 protocol driver Damien Le Moal
2023-03-23 3:38 ` [PATCH 1/2] ata: pata_parport-bpck6: Remove dependency on 64BIT Damien Le Moal
2023-03-23 21:01 ` Ondrej Zary
2023-03-23 22:37 ` Damien Le Moal
2023-03-26 20:14 ` Ondrej Zary
2023-03-23 3:38 ` Damien Le Moal [this message]
2023-03-26 20:14 ` [PATCH 2/2] ata: pata_parport-bpck6: Declare mode_map as static Ondrej Zary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230323033836.352672-3-damien.lemoal@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux@zary.sk \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).