Linux-ide Archive on lore.kernel.org
 help / color / Atom feed
From: John Garry <john.garry@huawei.com>
To: Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>
Cc: <martin.petersen@oracle.com>, <brking@us.ibm.com>,
	<jinpu.wang@cloud.ionos.com>, <mpe@ellerman.id.au>,
	<linux-scsi@vger.kernel.org>, <linux-ide@vger.kernel.org>
Subject: Re: fix ATAPI support for libsas drivers
Date: Tue, 23 Jun 2020 12:44:38 +0100
Message-ID: <2bcf7cc7-f3e0-de41-8bf2-b8c5979fe927@huawei.com> (raw)
In-Reply-To: <bed58e53-2019-cbb6-2ebe-93d0e404c90a@suse.de>

On 22/06/2020 07:28, Hannes Reinecke wrote:
> On 6/18/20 5:28 PM, Christoph Hellwig wrote:
>> On Thu, Jun 18, 2020 at 10:02:58AM +0100, John Garry wrote:
>>> On 15/06/2020 07:46, Christoph Hellwig wrote:
>>>> Hi all,
>>>>
>>>> this series fixes the ATAPI DMA drain refactoring for SAS HBAs that
>>>> use libsas.
>>>> .
>>>>
>>>
>>> Something I meant to ask before and was curious about, specifically 
>>> since
>>> ipr doesn't actually use libsas: Why not wire up other SAS HBAs, like
>>> megaraid_sas?
>>
>> megaraid_sas and mpt3sas don't use the libata code at all.  ipr actually
>> is a special case and uses libata directly instead of libsas (something
>> I hadn't realized, but which doesn't change anything for the patches
>> itself, just possibly the commit log).
>>
> More to the point, megaraid_sas and mpt3sas have their own SATL in 
> firmware so there is no need to use libata here.

ok.

BTW, @Christoph, I have no setup to verify this refactoring for anything 
which uses libsas (that I know about, anyway).

Thanks


      reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-15  6:46 Christoph Hellwig
2020-06-15  6:46 ` [PATCH 1/2] libata: provide a ata_scsi_dma_need_drain stub for !CONFIG_ATA Christoph Hellwig
2020-06-16  3:46   ` Martin K. Petersen
2020-06-15  6:46 ` [PATCH 2/2] scsi: wire up ata_scsi_dma_need_drain for SAS HBA drivers Christoph Hellwig
2020-06-18  9:02 ` fix ATAPI support for libsas drivers John Garry
2020-06-18 15:28   ` Christoph Hellwig
2020-06-22  6:28     ` Hannes Reinecke
2020-06-23 11:44       ` John Garry [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2bcf7cc7-f3e0-de41-8bf2-b8c5979fe927@huawei.com \
    --to=john.garry@huawei.com \
    --cc=brking@us.ibm.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=jinpu.wang@cloud.ionos.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ide Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-ide/0 linux-ide/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-ide linux-ide/ https://lore.kernel.org/linux-ide \
		linux-ide@vger.kernel.org
	public-inbox-index linux-ide

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-ide


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git