* [PATCH 0/2] Fix deferred probing for the Toshiba TX493x IDE drivers
@ 2021-04-23 20:40 Sergey Shtylyov
2021-04-23 20:41 ` [PATCH 1/2] tx4938ide: fix deferred probing Sergey Shtylyov
2021-04-23 20:42 ` [PATCH 2/2] tx4939ide: " Sergey Shtylyov
0 siblings, 2 replies; 3+ messages in thread
From: Sergey Shtylyov @ 2021-04-23 20:40 UTC (permalink / raw)
To: David S. Miller, linux-ide
Here are 2 patches against the of DaveM's 'ide.git' repo. The Toshiba TX493x IDE
drivers call platform_get_irq() but override its result in case of error which
prevents the deferred probing from working...
[1/2] tx4938ide: fix deferred probing
[2/2] tx4939ide: fix deferred probing
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/2] tx4938ide: fix deferred probing
2021-04-23 20:40 [PATCH 0/2] Fix deferred probing for the Toshiba TX493x IDE drivers Sergey Shtylyov
@ 2021-04-23 20:41 ` Sergey Shtylyov
2021-04-23 20:42 ` [PATCH 2/2] tx4939ide: " Sergey Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Sergey Shtylyov @ 2021-04-23 20:41 UTC (permalink / raw)
To: David S. Miller, linux-ide
The driver overrides the error codes returned by platform_get_irq() to
-ENODEV, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the
error code upstream.
Fixes: 28502848f52f ("ide: Add tx4938ide driver (v2)")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
---
drivers/ide/tx4938ide.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: ide/drivers/ide/tx4938ide.c
===================================================================
--- ide.orig/drivers/ide/tx4938ide.c
+++ ide/drivers/ide/tx4938ide.c
@@ -139,7 +139,7 @@ static int __init tx4938ide_probe(struct
irq = platform_get_irq(pdev, 0);
if (irq < 0)
- return -ENODEV;
+ return irq;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res)
return -ENODEV;
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/2] tx4939ide: fix deferred probing
2021-04-23 20:40 [PATCH 0/2] Fix deferred probing for the Toshiba TX493x IDE drivers Sergey Shtylyov
2021-04-23 20:41 ` [PATCH 1/2] tx4938ide: fix deferred probing Sergey Shtylyov
@ 2021-04-23 20:42 ` Sergey Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Sergey Shtylyov @ 2021-04-23 20:42 UTC (permalink / raw)
To: David S. Miller, linux-ide
The driver overrides the error codes returned by platform_get_irq() to
-ENODEV, so if it returns -EPROBE_DEFER, the driver will fail the probe
permanently instead of the deferred probing. Switch to propagating the
error code upstream.
Fixes: 37897989232e ("ide: Add tx4939ide driver (v6)")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
---
drivers/ide/tx4939ide.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: ide/drivers/ide/tx4939ide.c
===================================================================
--- ide.orig/drivers/ide/tx4939ide.c
+++ ide/drivers/ide/tx4939ide.c
@@ -543,7 +543,7 @@ static int __init tx4939ide_probe(struct
irq = platform_get_irq(pdev, 0);
if (irq < 0)
- return -ENODEV;
+ return irq;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res)
return -ENODEV;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-23 20:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-23 20:40 [PATCH 0/2] Fix deferred probing for the Toshiba TX493x IDE drivers Sergey Shtylyov
2021-04-23 20:41 ` [PATCH 1/2] tx4938ide: fix deferred probing Sergey Shtylyov
2021-04-23 20:42 ` [PATCH 2/2] tx4939ide: " Sergey Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).