From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Baokun Li <libaokun1@huawei.com>,
axboe@kernel.dk, tj@kernel.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: yebin10@huawei.com, yukuai3@huawei.com, Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next 2/2] sata_fsl: fix warning in remove_proc_entry when rmmod sata_fsl
Date: Sat, 20 Nov 2021 12:51:24 +0300 [thread overview]
Message-ID: <361abc20-e01e-3c3a-3217-2e7ed6cb3f76@gmail.com> (raw)
In-Reply-To: <fcf2d384-ee03-298c-c1ac-5a39c0d85784@opensource.wdc.com>
On 20.11.2021 9:08, Damien Le Moal wrote:
> On 11/20/21 00:43, Sergei Shtylyov wrote:
>>> diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
>>> index 30759fd1c3a2..011daac4a14e 100644
>>> --- a/drivers/ata/sata_fsl.c
>>> +++ b/drivers/ata/sata_fsl.c
>>> @@ -1493,7 +1493,7 @@ static int sata_fsl_probe(struct platform_device *ofdev)
>>> host_priv->ssr_base = ssr_base;
>>> host_priv->csr_base = csr_base;
>>>
>>> - irq = irq_of_parse_and_map(ofdev->dev.of_node, 0);
>>> + irq = platform_get_irq(ofdev, 0);
>>> if (!irq) {
>>
>> if (irq < 0) {
>>
>> platform_get_irq() returns negative error codes, not 0 on failure.
>
> Sergei,
>
> By the way, the kdoc comment for platform_get_irq() says:
>
> "Return: non-zero IRQ number on success, negative error number on failure."
>
> But irq 0 is valid, isn't it ? So shouldn't this be changed to something
> like:
>
> "Return: IRQ number on success, negative error number on failure."
No, it's not valid (the current code WARN()s about it) and won't be
returned anymore after my patch [1] gets applied.
[1] https://marc.info/?l=linux-kernel&m=163623041902285
MBR, Sergei
next prev parent reply other threads:[~2021-11-20 9:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 4:11 [PATCH -next 0/2] fix two bugs when trying rmmod sata_fsl Baokun Li
2021-11-19 4:11 ` [PATCH -next 1/2] sata_fsl: fix UAF in sata_fsl_port_stop when " Baokun Li
2021-11-19 4:11 ` [PATCH -next 2/2] sata_fsl: fix warning in remove_proc_entry " Baokun Li
2021-11-19 15:43 ` Sergei Shtylyov
2021-11-20 2:16 ` libaokun (A)
2021-11-20 2:18 ` libaokun (A)
2021-11-20 6:08 ` Damien Le Moal
2021-11-20 9:51 ` Sergei Shtylyov [this message]
2021-11-21 23:24 ` Damien Le Moal
2021-11-19 22:18 ` Damien Le Moal
2021-11-20 2:22 ` libaokun (A)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=361abc20-e01e-3c3a-3217-2e7ed6cb3f76@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=hulkci@huawei.com \
--cc=libaokun1@huawei.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=yebin10@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).