From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAA1DC433EF for ; Tue, 21 Jun 2022 22:12:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229458AbiFUWMz (ORCPT ); Tue, 21 Jun 2022 18:12:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229846AbiFUWMx (ORCPT ); Tue, 21 Jun 2022 18:12:53 -0400 Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8B822FE7E for ; Tue, 21 Jun 2022 15:12:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1655849568; x=1687385568; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=2YdjSyXdtAlPmAv8WQhydNn+Hsj90wFDk7YivN/TXZU=; b=aCq1ACBTTd4B9SCg5xE+gT07JNY05wCQAkroKn+FMaMk+pWpOs5CMozM o5XZqMy6fj0jKAXyup4SGTeR71kEVSm33x7t/6T5eOmBGFOjnafTO6L1b i+Gz4sC1FqefLuRLjLfyv9cfkE7T+9EXQjq3YTf/gdB5Cx6ZbRASEJiSV jsVPm3ZYYdKP9C+NCwMMPUvTd+RlPH/SZ5/KdtcbJWrp9tfQRZs27OzVv lxUx99VOn2ibSH75GfITvsl1UNNVlhNfmutd3BODWqtaUA0lkeVFYvKgs AI0AyBKZz83nFgSYar7qvOXDnvv14rYiM24I9bZSf7ukOhCo0cwCnkkhf w==; X-IronPort-AV: E=Sophos;i="5.92,210,1650902400"; d="scan'208";a="203760187" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 22 Jun 2022 06:12:47 +0800 IronPort-SDR: LHUdnKRPirEFFBrobEUd7ALkcV5pEFTt0ulKzIvBugOjMh0NolFNWnHQyyiz9+TAaKbx6U2nTa i74pG8KqFGArukGkivgEzVF7hpZBWPxvibPLDp12TSDi48A6+VWJWpd9sKixpc24x9ZE1W58AY jqLYL/no1UPKN2nKi56Ntrkcoo8AzFl/7kDzsKKe3SXXYPERbZQCcsmzwvoyk6K/yMfhUQCUsc Jo0l5BZbCtxc2tOiSuM3LrDDxfcVls1M8RvxA/7TA+PvGQSi89X8YMA6oE+MemexlTmrV7yvgP ctT3QjkTs3DXZY4riVoTjpHU Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Jun 2022 14:30:55 -0700 IronPort-SDR: aGd6g2+b/qRmdALMvAiJGr9nO7JWB0+ginVdKifVVUZ27PMdeWfWr+1fTGYZQepdZP3rCkTWoi 27CYd169et2s6YpHeqR/unLoEV+5ovLfTntlZxll50E6MeBqui+t6YqoyRCiI3+QktYbGoYEeO 5c7GM0bGtBjBAX4J7xU0AFa8PW0639/oz5ur8PqxQ8jcusxs7xWzbkTIJMT7ska9+pI+Jvb57M nCiK/fTBVUst+zmmjDH5SJSHJk3kPuy6mpCUM89PWC9qquC5QExprTmXzKRPWHqY8oygahSL+F pf8= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Jun 2022 15:12:49 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4LSLNv5jYvz1Rwnl for ; Tue, 21 Jun 2022 15:12:47 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1655849566; x=1658441567; bh=2YdjSyXdtAlPmAv8WQhydNn+Hsj90wFDk7Y ivN/TXZU=; b=jyGUb+1DDZcEATwAD6vKSOoTaTw/HRqDLTXBGFzFvtSQ2djp+2c 80Q9vZYattEAF5m9XKR52BChG39Bcs+i4IbGxeT0UhkLuU2E6+INX195RIH6kDiN WL9HDcZqF83egXL8UZoKkiFDol7aEdjcTp6oq6vyUaz/MAPcOa6XJRuVygkIIQN/ ff/tSakfaw/bfQmYTxrQjTwN++xOCw075XEJJsdYPNkGSSaUZANyH/nPINMFXe7v A3ml6ZjLnP9ut2sVvXM3Ingg/ff3BIheKn1phL9yQm4DxtW5DFthPWpbO9HPFzTA 93GG/BAqNz2tvhAEQwAzKEripfwL92KI3fg== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id JVWJ6ZXJOGX8 for ; Tue, 21 Jun 2022 15:12:46 -0700 (PDT) Received: from [10.225.163.90] (unknown [10.225.163.90]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4LSLNs69w1z1RtVk; Tue, 21 Jun 2022 15:12:45 -0700 (PDT) Message-ID: <369448ed-f89a-c2db-1850-91450d8b5998@opensource.wdc.com> Date: Wed, 22 Jun 2022 07:12:44 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: Do we still need the scsi IPR driver ? Content-Language: en-US To: Brian King , Brian King , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org References: <3dbd9ae4-a101-e55d-79c8-9b3a96ab5b17@linux.vnet.ibm.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 6/22/22 05:52, Brian King wrote: > On 6/21/22 3:36 PM, Brian King wrote: >> On 6/19/22 11:48 PM, Damien Le Moal wrote: >>> >>> Polling people here: Do we still need the scsi IPR driver for IBM Power >>> Linux RAID adapters (IBM iSeries: 5702, 5703, 2780, 5709, 570A, 570B >>> adapters) ? >>> >>> The reason I am asking is because this driver is the *only* libsas/ata >>> driver that does not define a ->error_handler port operation. If this >>> driver is removed, or if it is modified to use a ->error_handler operation >>> to handle failed commands, then a lot of code simplification can be done >>> in libata, which I am trying to do to facilitate the processing of some >>> special error completion for commands using a command duration limit. >> >> We still need it around for now. IBM still sells these adapters >> and they can still be ordered even on our latest Power 10 systems. > > At one point I did look into modifying ipr to use an ->error_handler. > I recall I ran into some issues that resulted in this getting put > on the shelf, but its been a while. I'll go dig that code up and > see what it looks like. Thanks. It would be really great if you can convert to using error_handler. This is really the last ata/libsas driver that does not use this. > > Thanks, > > Brian > > -- Damien Le Moal Western Digital Research