linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] Add AHCI support for ASM1062+JBM575 cards
@ 2021-10-11 21:04 István Pongrácz
  2021-10-11 21:08 ` Damien Le Moal
  0 siblings, 1 reply; 2+ messages in thread
From: István Pongrácz @ 2021-10-11 21:04 UTC (permalink / raw)
  To: linux-ide, damien.lemoal; +Cc: István Pongrácz

Add support for PCIe SATA expander cards based on ASMedia 1062 + JBM575
controllers.
These cards can provide up to 10 or more SATA ports on one PCIe card.

Signed-off-by: István Pongrácz <pongracz.istvan@gmail.com>
---
 drivers/ata/ahci.c | 1 +
 1 file changed, 1 insertion(+)
 Changes from v1: rework commit message to meet syntax and content requirements.

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 186cbf90c8ea..97fd96b67731 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -592,6 +592,7 @@ static const struct pci_device_id ahci_pci_tbl[] = {
 	{ PCI_VDEVICE(ASMEDIA, 0x0612), board_ahci },	/* ASM1062 */
 	{ PCI_VDEVICE(ASMEDIA, 0x0621), board_ahci },   /* ASM1061R */
 	{ PCI_VDEVICE(ASMEDIA, 0x0622), board_ahci },   /* ASM1062R */
+	{ PCI_VDEVICE(ASMEDIA, 0x0624), board_ahci },   /* ASM1062+JMB575 */
 
 	/*
 	 * Samsung SSDs found on some macbooks.  NCQ times out if MSI is
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] Add AHCI support for ASM1062+JBM575 cards
  2021-10-11 21:04 [PATCH v2] Add AHCI support for ASM1062+JBM575 cards István Pongrácz
@ 2021-10-11 21:08 ` Damien Le Moal
  0 siblings, 0 replies; 2+ messages in thread
From: Damien Le Moal @ 2021-10-11 21:08 UTC (permalink / raw)
  To: István Pongrácz, linux-ide

On 2021/10/12 6:04, István Pongrácz wrote:
> Add support for PCIe SATA expander cards based on ASMedia 1062 + JBM575
> controllers.
> These cards can provide up to 10 or more SATA ports on one PCIe card.
> 
> Signed-off-by: István Pongrácz <pongracz.istvan@gmail.com>
> ---
>  drivers/ata/ahci.c | 1 +
>  1 file changed, 1 insertion(+)
>  Changes from v1: rework commit message to meet syntax and content requirements.

Almost ! This line must be the first one after "---" And put a blank line after
it. After that, it is the patch proper. It should look like:

...
Signed-off-by: István Pongrácz <pongracz.istvan@gmail.com>
---
Changes from v1: rework commit message to meet syntax and content requirements.

 drivers/ata/ahci.c | 1 +
 1 file changed, 1 insertion(+)
...


Apart from that, this looks good.

> 
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 186cbf90c8ea..97fd96b67731 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -592,6 +592,7 @@ static const struct pci_device_id ahci_pci_tbl[] = {
>  	{ PCI_VDEVICE(ASMEDIA, 0x0612), board_ahci },	/* ASM1062 */
>  	{ PCI_VDEVICE(ASMEDIA, 0x0621), board_ahci },   /* ASM1061R */
>  	{ PCI_VDEVICE(ASMEDIA, 0x0622), board_ahci },   /* ASM1062R */
> +	{ PCI_VDEVICE(ASMEDIA, 0x0624), board_ahci },   /* ASM1062+JMB575 */
>  
>  	/*
>  	 * Samsung SSDs found on some macbooks.  NCQ times out if MSI is
> 


-- 
Damien Le Moal
Western Digital Research

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-11 21:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-11 21:04 [PATCH v2] Add AHCI support for ASM1062+JBM575 cards István Pongrácz
2021-10-11 21:08 ` Damien Le Moal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).