From: Sowjanya Komatineni <skomatineni@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>, <axboe@kernel.dk>,
<thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
<robh+dt@kernel.org>
Cc: <pchandru@nvidia.com>, <devicetree@vger.kernel.org>,
<linux-ide@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 3/3] ata: ahci_tegra: Add AHCI support for Tegra186
Date: Wed, 7 Apr 2021 15:57:33 -0700 [thread overview]
Message-ID: <49eba27e-18fa-b682-1385-2930dfff28ac@nvidia.com> (raw)
In-Reply-To: <594c622e-4505-3448-1c7b-eae8f36cbad8@gmail.com>
On 4/7/21 2:36 PM, Dmitry Osipenko wrote:
> 07.04.2021 04:25, Sowjanya Komatineni пишет:
>> + if (!tegra->pdev->dev.pm_domain) {
>> + ret = tegra_powergate_sequence_power_up(TEGRA_POWERGATE_SATA,
>> + tegra->sata_clk,
>> + tegra->sata_rst);
>> + if (ret)
>> + goto disable_regulators;
>> + }
>>
> Hi,
>
> Why you haven't added condition for tegra_powergate_power_off()? I think
> it should break GENPD and legacy PD API isn't not supported by T186 at all.
>
> I'm also not sure whether the power up/down sequence is correct using GENPD.
>
> Moreover the driver doesn't support runtime PM, so GENPD should be
> always off?
This driver already using legacy PD API's so thought its supported and
added power domain device check during powergate_sequence_power_up and
yes same should apply for powergate_power_off as well. But if legacy PD
is not supported by T186 then not sure why original driver even using
these API's.
Preetham/Thierry, Can you please comment ?
But as RPM is not implemented yet for this driver, GENPD will be OFF but
SATA is not in power-gate by the time kernel starts and functionally works.
But with RPM implementation, I guess we can do proper power gate on/off.
next prev parent reply other threads:[~2021-04-07 22:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 1:25 [PATCH v4 0/3] Add AHCI support for Tegra186 Sowjanya Komatineni
2021-04-07 1:25 ` [PATCH v4 1/3] dt-bindings: ata: tegra: Convert binding documentation to YAML Sowjanya Komatineni
2021-04-07 15:04 ` Thierry Reding
2021-04-07 1:25 ` [PATCH v4 2/3] dt-binding: ata: tegra: Add dt-binding documentation for Tegra186 Sowjanya Komatineni
2021-04-07 15:04 ` Thierry Reding
2021-04-07 1:25 ` [PATCH v4 3/3] ata: ahci_tegra: Add AHCI support " Sowjanya Komatineni
2021-04-07 15:05 ` Thierry Reding
2021-04-07 21:36 ` Dmitry Osipenko
2021-04-07 22:57 ` Sowjanya Komatineni [this message]
2021-04-07 23:00 ` Sowjanya Komatineni
2021-04-07 23:25 ` Dmitry Osipenko
2021-04-08 13:06 ` Thierry Reding
2021-04-08 14:41 ` Dmitry Osipenko
2021-04-07 15:44 ` [PATCH v4 0/3] " Jens Axboe
2021-04-07 16:18 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49eba27e-18fa-b682-1385-2930dfff28ac@nvidia.com \
--to=skomatineni@nvidia.com \
--cc=axboe@kernel.dk \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pchandru@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).