From: Finn Thain <fthain@linux-m68k.org>
To: Michael Schmitz <schmitzmic@gmail.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Richard Zidlicky <rz@linux-m68k.org>,
Jens Axboe <axboe@kernel.dk>,
"David S. Miller" <davem@davemloft.net>,
linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] m68k/q40: Replace q40ide with pata_falcon and falconide
Date: Mon, 7 Jun 2021 12:07:00 +1000 (AEST) [thread overview]
Message-ID: <4a32d59-ebb-9dc-fec7-ad172547d9a3@linux-m68k.org> (raw)
In-Reply-To: <e250cffb-9edd-1b84-3826-58079758b35a@gmail.com>
On Mon, 7 Jun 2021, Michael Schmitz wrote:
> Hi Finn,
>
> are there any substantial changes from what I'd tested before?
The request_region() stuff is new, and I reworked the host->get_lock and
host->release_lock changes. So you may want to review it again.
> Your patch conflicts with (I think) the Mac IDE patches now in Geert's
> tree, and I'd rather avoid hand-patching the lot if at all possible:
>
> m68k_q40_Replace_q40ide_with_pata_falcon_and_falconide
> Applying: m68k/q40: Replace q40ide with pata_falcon and falconide
> error: patch failed: arch/m68k/configs/multi_defconfig:351
> error: arch/m68k/configs/multi_defconfig: patch does not apply
> error: patch failed: drivers/ide/Kconfig:731
> error: drivers/ide/Kconfig: patch does not apply
> error: patch failed: drivers/ide/Makefile:29
> error: drivers/ide/Makefile: patch does not apply
>
I should have sent these as a two-part series. Sorry about that.
You'll need to apply this patch first:
https://lore.kernel.org/linux-ide/3de9a93d-2f7-a650-1fa-c2129a4a765b@nippy.intranet/T/
> What's your baseline for this patch?
>
I've used v5.12 and v5.13-rc5, but mostly I develop on the mac68k branch
in my github repository.
> (In the alternative: just add my Tested-by if nothing changed aside from the
> IO region reservation)
>
I have tested these patches in Aranym (including a multi-platform
atari/q40 build which required your ISA fix) but I don't have any way to
test the q40-only code.
next prev parent reply other threads:[~2021-06-07 2:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-06 9:15 [PATCH] m68k/q40: Replace q40ide with pata_falcon and falconide Finn Thain
2021-06-06 21:10 ` Michael Schmitz
2021-06-07 2:07 ` Finn Thain [this message]
2021-06-07 3:41 ` Michael Schmitz
2021-06-08 3:01 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a32d59-ebb-9dc-fec7-ad172547d9a3@linux-m68k.org \
--to=fthain@linux-m68k.org \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=rz@linux-m68k.org \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).