From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: "Enrico Weigelt, metux IT consult" <info@metux.net>,
linux-kernel@vger.kernel.org
Cc: axboe@kernel.dk, hdegoede@redhat.com, b.zolnierkie@samsung.com,
linus.walleij@linaro.org, linux-ide@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH 4/9] drivers: ata: ahci_xgene: use devm_platform_ioremap_resource()
Date: Tue, 12 Mar 2019 17:43:49 +0300 [thread overview]
Message-ID: <4cab769a-f4cf-4042-fd0b-1a33f0dbd4f7@cogentembedded.com> (raw)
In-Reply-To: <1552382374-28789-4-git-send-email-info@metux.net>
Hello!
On 03/12/2019 12:19 PM, Enrico Weigelt, metux IT consult wrote:
> Use the new helper that wraps the calls to platform_get_resource()
> and devm_ioremap_resource() together.
>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
> ---
> drivers/ata/ahci_xgene.c | 21 +++++++--------------
> 1 file changed, 7 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c
> index 7e157e1..99c622c 100644
> --- a/drivers/ata/ahci_xgene.c
> +++ b/drivers/ata/ahci_xgene.c
> @@ -752,7 +752,6 @@ static int xgene_ahci_probe(struct platform_device *pdev)
[...]
> /* Retrieve the optional IP mux resource */
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 4);
> - if (res) {
> - void __iomem *csr = devm_ioremap_resource(dev, res);
> - if (IS_ERR(csr))
> - return PTR_ERR(csr);
> -
> - ctx->csr_mux = csr;
> + ctx->csr_mux = csr = devm_platform_ioremap_resource(pdev, 4);
> + if (IS_ERR(ctx->csr_mux)) {
> + dev_info(&pdev->dev, "cant get ip mux resource (optional)");
Can't.
> + ctx->csr_mux = NULL;
MBR, Sergei
next prev parent reply other threads:[~2019-03-12 14:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 9:19 [PATCH 1/9] drivers: ata: ahci_octeon: use devm_platform_ioremap_resource() Enrico Weigelt, metux IT consult
2019-03-12 9:19 ` [PATCH 2/9] drivers: ata: ahci_seattle: " Enrico Weigelt, metux IT consult
2019-03-12 9:19 ` [PATCH 3/9] drivers: ata: ahci_tegra: " Enrico Weigelt, metux IT consult
2019-03-12 10:04 ` Jon Hunter
2019-03-12 9:19 ` [PATCH 4/9] drivers: ata: ahci_xgene: " Enrico Weigelt, metux IT consult
2019-03-12 14:43 ` Sergei Shtylyov [this message]
2019-03-12 9:19 ` [PATCH 5/9] drivers: ata: libahci_platform: " Enrico Weigelt, metux IT consult
2019-03-12 9:19 ` [PATCH 6/9] drivers: ata: pata_bk3710: " Enrico Weigelt, metux IT consult
2019-03-12 9:19 ` [PATCH 7/9] drivers: ata: sata_dwc_460ex: " Enrico Weigelt, metux IT consult
2019-03-12 9:19 ` [PATCH 8/9] drivers: ata: sata_gemini: " Enrico Weigelt, metux IT consult
2019-04-03 3:37 ` Linus Walleij
2019-03-12 9:19 ` [PATCH 9/9] drivers: ata: sata_rcar: " Enrico Weigelt, metux IT consult
2019-03-12 15:06 ` Sergei Shtylyov
2019-08-20 12:35 [PATCH 1/9] drivers: ata: ahci_octeon: " Enrico Weigelt, metux IT consult
2019-08-20 12:35 ` [PATCH 4/9] drivers: ata: ahci_xgene: " Enrico Weigelt, metux IT consult
2019-08-20 13:45 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cab769a-f4cf-4042-fd0b-1a33f0dbd4f7@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=axboe@kernel.dk \
--cc=b.zolnierkie@samsung.com \
--cc=hdegoede@redhat.com \
--cc=info@metux.net \
--cc=linus.walleij@linaro.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).