From: Jens Axboe <axboe@kernel.dk>
To: Jiri Slaby <jslaby@suse.cz>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH v2 2/3] ata: make qc_prep return an int
Date: Tue, 9 Jul 2019 21:04:11 -0600 [thread overview]
Message-ID: <4ed428e5-8108-e6c5-b580-9dd20ec049f0@kernel.dk> (raw)
In-Reply-To: <20190709100203.19049-2-jslaby@suse.cz>
On 7/9/19 4:02 AM, Jiri Slaby wrote:
> In case a driver wants to return an error. sata_mv is one of those --
> see the next patch.
Not against the change as such, but there seems to be some confusion on
int vs enum ata_completion_errors. The latter is probably poorly named
if you're going to start using it for prep return, but would probably
still be saner to have an AC_ERR_OK as 0 and use that and use the enum.
--
Jens Axboe
next prev parent reply other threads:[~2019-07-10 3:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 10:02 [PATCH v2 1/3] ata: Documentation, fix function names Jiri Slaby
2019-07-09 10:02 ` [PATCH v2 2/3] ata: make qc_prep return an int Jiri Slaby
2019-07-10 3:04 ` Jens Axboe [this message]
2019-07-09 10:02 ` [PATCH v2 3/3] ata: sata_mv, avoid trigerrable BUG_ON Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ed428e5-8108-e6c5-b580-9dd20ec049f0@kernel.dk \
--to=axboe@kernel.dk \
--cc=jslaby@suse.cz \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).