From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7718C5DF60 for ; Fri, 8 Nov 2019 14:27:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B7BC7222C2 for ; Fri, 8 Nov 2019 14:27:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="iqwILVQY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726335AbfKHO1A (ORCPT ); Fri, 8 Nov 2019 09:27:00 -0500 Received: from mail-io1-f50.google.com ([209.85.166.50]:37139 "EHLO mail-io1-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726039AbfKHO1A (ORCPT ); Fri, 8 Nov 2019 09:27:00 -0500 Received: by mail-io1-f50.google.com with SMTP id 1so6552679iou.4 for ; Fri, 08 Nov 2019 06:26:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=U+gZ1iZyMycMyu4RO24BAjLSYNHz9sOObk4L5rAMf7c=; b=iqwILVQYZSgmH9OUII6SqeT4Drvw0j1zpDG2nt3rLVuYNmHI7uc2IUg7rI+JESGb7J VPdhKPgxjTYrje0kLVpESYLZeMPp32BZE9qQW3kRPV4A2Ov04mesqZ7YGidApVohuRQ/ s1C0A+EmO3dMNP+YvKu0SHgwE9+YqcymXT1jRkDqwT8LaDVCEAmgQOau+ojwU/TOJyYv FbZ94VSTvKvxoN68eEF3O3bSY5UvDEhKkshv3g7CDh9e3NkSC6+y92JYNZfCRTv7UEh5 OXRNey3HvzswzpyTOhU3rakgDLkDbiXKQQS/kgpE9zIr1d955aRiaB8CIeiks5cn7mXa +j+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=U+gZ1iZyMycMyu4RO24BAjLSYNHz9sOObk4L5rAMf7c=; b=KeCiU7sEYzMDmE4ccUx6ywUAitsRfax8IwCBXJZDNWuR/qsHfpGfp9aANK5/AtiZuX 350KykPlHYuOVixGN+FtKWmPZyq9WJjG9LN8YSMG5oSh0z6+EIqfYsWBK3q7041RSq0q 1IwXJEYL4puBX52/0oacVCG68uVfTxaDBAhUTA0mWVZGuc1tQV+kP3FkDI6ySOGyCx5R K60l4Q8KGcKMdX0DqflEe9Bqbjw1+ReniPmpIKlTRnJ38gor6VkltMq9dRDV//BmXMMQ AjMOgXcTP1o+uabbHuSERW7p/OaD8aTgVumXF8Sm17HLm3X9ddjSGyilMl2CVHg7MXAq Sfaw== X-Gm-Message-State: APjAAAVtPKYZPuQSdopyxlREQpwJIaJ0d+mJm7/s/zbRvUdeSqNDNK3U 4tBzmbvCS0qPPtZTMgT2acbmGA== X-Google-Smtp-Source: APXvYqzwYZ+WipkYapK99X3KqatJkMZI+Jw2MzH942P7q0uMgKJc79YO5XDMV6HvnRPVP9zk3ee6lA== X-Received: by 2002:a6b:f914:: with SMTP id j20mr11044257iog.223.1573223219271; Fri, 08 Nov 2019 06:26:59 -0800 (PST) Received: from [192.168.1.159] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id u9sm452653ior.46.2019.11.08.06.26.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Nov 2019 06:26:58 -0800 (PST) Subject: Re: [PATCH][V2] ata: pata_artop: make arrays static const, makes object smaller To: Colin King , Bartlomiej Zolnierkiewicz , linux-ide@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20191006142956.23360-1-colin.king@canonical.com> From: Jens Axboe Message-ID: <5dae76cc-e71d-d295-7947-b7005a7f1af3@kernel.dk> Date: Fri, 8 Nov 2019 07:26:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191006142956.23360-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 10/6/19 8:29 AM, Colin King wrote: > From: Colin Ian King > > Don't populate the const arrays on the stack but instead make them > static. Makes the object code smaller by 292 bytes. > > Before: > text data bss dec hex filename > 6988 3132 128 10248 2808 drivers/ata/pata_artop.o > > After: > text data bss dec hex filename > 6536 3292 128 9956 26e4 drivers/ata/pata_artop.o > > (gcc version 9.2.1, amd64) Applied, thanks. -- Jens Axboe