From: Hans de Goede <hdegoede@redhat.com>
To: sven.auhagen@voleatech.de, axboe@kernel.dk, robh+dt@kernel.org,
tglx@linutronix.de, maz@kernel.org, gregory.clement@bootlin.com
Cc: linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, jason@lakedaemon.net, andrew@lunn.ch,
rjw@rjwysocki.net, viresh.kumar@linaro.org,
antoine.tenart@bootlin.com, maxime.chevallier@bootlin.com,
thomas.petazzoni@bootlin.com, miquel.raynal@bootlin.com
Subject: Re: [PATCH 1/7] ata: ahci: mvebu: Rename a platform data flag
Date: Tue, 27 Oct 2020 14:54:37 +0100 [thread overview]
Message-ID: <6974d0f5-e600-d495-e132-9d3efbd4fd82@redhat.com> (raw)
In-Reply-To: <20201007154554.66650-2-sven.auhagen@voleatech.de>
Hi,
On 10/7/20 5:45 PM, sven.auhagen@voleatech.de wrote:
> From: Miquel Raynal <miquel.raynal@bootlin.com>
>
> Before adding more entries in the platform data structure, rename the
> flags entry to be more precise and name it host_flags.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/ata/ahci_mvebu.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/ata/ahci_mvebu.c b/drivers/ata/ahci_mvebu.c
> index d4bba3ace45d..43bb2db59698 100644
> --- a/drivers/ata/ahci_mvebu.c
> +++ b/drivers/ata/ahci_mvebu.c
> @@ -30,7 +30,7 @@
>
> struct ahci_mvebu_plat_data {
> int (*plat_config)(struct ahci_host_priv *hpriv);
> - unsigned int flags;
> + unsigned int host_flags;
> };
>
> static void ahci_mvebu_mbus_config(struct ahci_host_priv *hpriv,
> @@ -196,7 +196,7 @@ static int ahci_mvebu_probe(struct platform_device *pdev)
> if (IS_ERR(hpriv))
> return PTR_ERR(hpriv);
>
> - hpriv->flags |= pdata->flags;
> + hpriv->flags |= pdata->host_flags;
> hpriv->plat_data = (void *)pdata;
>
> rc = ahci_platform_enable_resources(hpriv);
> @@ -227,7 +227,7 @@ static const struct ahci_mvebu_plat_data ahci_mvebu_armada_380_plat_data = {
>
> static const struct ahci_mvebu_plat_data ahci_mvebu_armada_3700_plat_data = {
> .plat_config = ahci_mvebu_armada_3700_config,
> - .flags = AHCI_HFLAG_SUSPEND_PHYS,
> + .host_flags = AHCI_HFLAG_SUSPEND_PHYS,
> };
>
> static const struct of_device_id ahci_mvebu_of_match[] = {
>
next prev parent reply other threads:[~2020-10-27 13:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 15:45 [PATCH 0/7] Armada8k enable per-port SATA interrupts and drop a hack in the IRQ subsystem sven.auhagen
2020-10-07 15:45 ` [PATCH 1/7] ata: ahci: mvebu: Rename a platform data flag sven.auhagen
2020-10-07 16:01 ` Marc Zyngier
2020-10-07 16:02 ` Sven Auhagen
2020-10-27 13:54 ` Hans de Goede [this message]
2020-10-07 15:45 ` [PATCH 2/7] ata: ahci: mvebu: Support A8k compatible sven.auhagen
2020-10-27 13:54 ` Hans de Goede
2020-10-07 15:45 ` [PATCH 3/7] ata: ahci: mvebu: Add support for A8k legacy DT bindings sven.auhagen
2020-10-27 14:22 ` Hans de Goede
2020-10-27 15:14 ` Sven Auhagen
2020-10-07 15:45 ` [PATCH 4/7] irqchip/irq-mvebu-icu: Remove the double SATA ports interrupt hack sven.auhagen
2020-10-27 14:24 ` Hans de Goede
2020-10-07 15:45 ` [PATCH 5/7] dt-bindings: ata: Update ahci bindings with possible per-port interrupts sven.auhagen
2020-10-27 14:25 ` Hans de Goede
2020-10-07 15:45 ` [PATCH 6/7] dt-bindings: ata: Update ahci_mvebu bindings sven.auhagen
2020-10-27 14:25 ` Hans de Goede
2020-10-07 15:45 ` [PATCH 7/7] arm64: dts: marvell: armada-cp110: Switch to per-port SATA interrupts sven.auhagen
2020-10-27 14:26 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6974d0f5-e600-d495-e132-9d3efbd4fd82@redhat.com \
--to=hdegoede@redhat.com \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=axboe@kernel.dk \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=maz@kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=sven.auhagen@voleatech.de \
--cc=tglx@linutronix.de \
--cc=thomas.petazzoni@bootlin.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).