From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>
Cc: Tim Waugh <tim@cyberelk.net>, Borislav Petkov <bp@alien8.de>,
Jan Kara <jack@suse.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/7] cdrom: factor out a cdrom_read_tocentry helper
Date: Thu, 23 Apr 2020 07:41:18 +0000 [thread overview]
Message-ID: <BY5PR04MB6900ABB062D1941B97EA8F3EE7D30@BY5PR04MB6900.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20200423071224.500849-4-hch@lst.de
On 2020/04/23 16:15, Christoph Hellwig wrote:
> Factor out a version of the CDROMREADTOCENTRY ioctl handler that can
> be called directly from kernel space.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/cdrom/cdrom.c | 39 ++++++++++++++++++++++-----------------
> include/linux/cdrom.h | 3 +++
> 2 files changed, 25 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
> index a1d2112fd283..c91d1e138214 100644
> --- a/drivers/cdrom/cdrom.c
> +++ b/drivers/cdrom/cdrom.c
> @@ -2666,32 +2666,37 @@ static int cdrom_ioctl_read_tochdr(struct cdrom_device_info *cdi,
> return 0;
> }
>
> +int cdrom_read_tocentry(struct cdrom_device_info *cdi,
> + struct cdrom_tocentry *entry)
> +{
> + u8 requested_format = entry->cdte_format;
> + int ret;
> +
> + if (requested_format != CDROM_MSF && requested_format != CDROM_LBA)
> + return -EINVAL;
> +
> + /* make interface to low-level uniform */
> + entry->cdte_format = CDROM_MSF;
> + ret = cdi->ops->audio_ioctl(cdi, CDROMREADTOCENTRY, entry);
> + if (!ret)
> + sanitize_format(&entry->cdte_addr, &entry->cdte_format,
> + requested_format);
> + return ret;
> +}
> +EXPORT_SYMBOL_GPL(cdrom_read_tocentry);
> +
> static int cdrom_ioctl_read_tocentry(struct cdrom_device_info *cdi,
> void __user *argp)
> {
> struct cdrom_tocentry entry;
> - u8 requested_format;
> int ret;
>
> - /* cd_dbg(CD_DO_IOCTL, "entering CDROMREADTOCENTRY\n"); */
> -
> if (copy_from_user(&entry, argp, sizeof(entry)))
> return -EFAULT;
> -
> - requested_format = entry.cdte_format;
> - if (requested_format != CDROM_MSF && requested_format != CDROM_LBA)
> - return -EINVAL;
> - /* make interface to low-level uniform */
> - entry.cdte_format = CDROM_MSF;
> - ret = cdi->ops->audio_ioctl(cdi, CDROMREADTOCENTRY, &entry);
> - if (ret)
> - return ret;
> - sanitize_format(&entry.cdte_addr, &entry.cdte_format, requested_format);
> -
> - if (copy_to_user(argp, &entry, sizeof(entry)))
> + ret = cdrom_read_tocentry(cdi, &entry);
> + if (!ret && copy_to_user(argp, &entry, sizeof(entry)))
> return -EFAULT;
> - /* cd_dbg(CD_DO_IOCTL, "CDROMREADTOCENTRY successful\n"); */
> - return 0;
> + return ret;
> }
>
> static int cdrom_ioctl_play_msf(struct cdrom_device_info *cdi,
> diff --git a/include/linux/cdrom.h b/include/linux/cdrom.h
> index 4f74ce050253..008c4d79fa33 100644
> --- a/include/linux/cdrom.h
> +++ b/include/linux/cdrom.h
> @@ -94,6 +94,9 @@ struct cdrom_device_ops {
> struct packet_command *);
> };
>
> +int cdrom_read_tocentry(struct cdrom_device_info *cdi,
> + struct cdrom_tocentry *entry);
> +
> /* the general block_device operations structure: */
> extern int cdrom_open(struct cdrom_device_info *cdi, struct block_device *bdev,
> fmode_t mode);
>
Looks OK to me.
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2020-04-23 7:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 7:12 stop using ioctl_by_bdev for file system access to CDROMs Christoph Hellwig
2020-04-23 7:12 ` [PATCH 1/7] block: add a cdrom_device_info pointer to struct gendisk Christoph Hellwig
2020-04-23 7:40 ` Damien Le Moal
2020-04-23 7:12 ` [PATCH 2/7] ide-cd: rename cdrom_read_tocentry Christoph Hellwig
2020-04-23 7:41 ` Damien Le Moal
2020-04-23 7:12 ` [PATCH 3/7] cdrom: factor out a cdrom_read_tocentry helper Christoph Hellwig
2020-04-23 7:41 ` Damien Le Moal [this message]
2020-04-23 7:12 ` [PATCH 4/7] cdrom: factor out a cdrom_multisession helper Christoph Hellwig
2020-04-23 7:41 ` Damien Le Moal
2020-04-23 7:12 ` [PATCH 5/7] hfsplus: stop using ioctl_by_bdev Christoph Hellwig
2020-04-23 7:42 ` Damien Le Moal
2020-04-23 7:12 ` [PATCH 6/7] isofs: " Christoph Hellwig
2020-04-23 7:42 ` Damien Le Moal
2020-04-23 11:03 ` Jan Kara
2020-04-24 6:52 ` Christoph Hellwig
2020-04-24 9:21 ` Jan Kara
2020-04-23 7:12 ` [PATCH 7/7] udf: " Christoph Hellwig
2020-04-23 7:43 ` Damien Le Moal
2020-04-23 11:05 ` Jan Kara
2020-04-25 7:56 stop using ioctl_by_bdev for file system access to CDROMs v2 Christoph Hellwig
2020-04-25 7:57 ` [PATCH 3/7] cdrom: factor out a cdrom_read_tocentry helper Christoph Hellwig
2020-04-27 6:17 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR04MB6900ABB062D1941B97EA8F3EE7D30@BY5PR04MB6900.namprd04.prod.outlook.com \
--to=damien.lemoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=bp@alien8.de \
--cc=hch@lst.de \
--cc=jack@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tim@cyberelk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).