From: Bruce Stenning <b.stenning@indigovision.com>
To: Tejun Heo <htejun@gmail.com>, Mark Lord <kernel@teksavvy.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: RE: sata_mv port lockup on hotplug (kernel 2.6.38.2)
Date: Mon, 25 Apr 2011 15:54:38 +0100 [thread overview]
Message-ID: <C1438B59050E1B4C9482FF3266AD6BA32C775549E4@gretna.indigovision.com> (raw)
In-Reply-To: 20110423005610.GC1576@mtj.dyndns.org
Tejun wrote:
> Yeap, devices behind SATA-PATA bridge were still affected by the transfer
> mode so libata tries to slow them down too along with link speed when
> limiting speed due to errors. Shouldn't affect native SATA devices.
Thanks.
I wrote:
> 00040055
> 00040015
> __ata_port_freeze: ata4 port frozen
> ata_port_schedule_eh: port EH scheduled
> ata_eh_thaw_port: ata4 port thawed
> ata_std_postreset: ENTER
> ata4: SATA link down (SStatus 0 SControl 310)
> ata_std_postreset: EXIT
> ata_eh_revalidate_and_attach: ENTER
> ata_eh_revalidate_and_attach: EXIT rc=-5
> ata4.00: disabled
> ata_eh_revalidate_and_attach: ENTER
> ata_eh_recover: EXIT, rc=0
> ata4: EH complete
> ata_scsi_error: EXIT
> ata_scsi_hotplug: ENTER
> ata4.00: detaching (SCSI 3:0:0:0)
> ata_scsi_hotplug: EXIT
Okay, so the ata_eh_thaw_port has raced (and won) against whatever was in the
process of masking off the irq (the __ata_port_freeze?), which then completes
leaving libata/sata_mv thinking the port is thawed while no further irqs get
generated.
Could ata_port_freeze or __ata_port_freeze (which don't claim the ap's lock)
have been invoked and then slept while ata_eh_thaw_port runs?
Bruce.
Latest News at: http://www.indigovision.com/index.php/en/news.html
next prev parent reply other threads:[~2011-04-25 14:54 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <C1438B59050E1B4C9482FF3266AD6BA32C7493557A@gretna.indigovision.com>
[not found] ` <C1438B59050E1B4C9482FF3266AD6BA32C7493559F@gretna.indigovision.com>
2011-04-06 21:00 ` sata_mv port lockup on hotplug (kernel 2.6.38.2) Alejandro Riveira Fernández
[not found] ` <4D9CD275.9000002@teksavvy.com>
2011-04-08 12:43 ` Bruce Stenning
2011-04-09 0:48 ` Mark Lord
2011-04-12 10:30 ` Bruce Stenning
2011-04-12 14:07 ` Mark Lord
2011-04-12 14:55 ` Mark Lord
2011-04-23 0:56 ` Tejun Heo
2011-04-25 11:07 ` Bruce Stenning
2011-04-25 11:30 ` Tejun Heo
2011-04-26 18:27 ` Mark Lord
2011-04-25 14:54 ` Bruce Stenning [this message]
2011-04-25 16:22 ` Tejun Heo
2011-04-26 13:13 ` Bruce Stenning
2011-04-26 13:50 ` Tejun Heo
2011-04-26 15:41 ` Bruce Stenning
2011-04-26 15:52 ` Tejun Heo
2011-04-26 16:05 ` Bruce Stenning
2011-04-30 14:01 ` Tejun Heo
2011-05-17 15:30 ` Bruce Stenning
2011-05-25 9:41 ` Tejun Heo
2011-05-25 13:36 ` Bruce Stenning
2011-05-25 22:27 ` Mark Lord
2011-05-30 13:07 ` Bruce Stenning
2011-05-31 2:04 ` Mark Lord
2011-06-10 12:28 ` Mark Lord
2011-06-10 14:01 ` Tejun Heo
2011-06-10 17:32 ` Mark Lord
2011-06-10 17:39 ` Jeff Garzik
2011-06-10 20:49 ` Mark Lord
2011-06-10 21:20 ` Jeff Garzik
2011-06-11 12:19 ` Tejun Heo
2011-06-12 17:10 ` Mark Lord
2011-06-13 10:48 ` Tejun Heo
2011-08-29 15:49 ` Bruce Stenning
2011-09-02 1:13 ` Tejun Heo
2011-09-02 16:22 ` Bruce Stenning
2011-09-06 3:45 ` Tejun Heo
2011-09-06 12:19 ` Bruce Stenning
2011-09-06 16:33 ` Tejun Heo
2011-09-06 16:42 ` Tejun Heo
2011-09-07 12:09 ` Bruce Stenning
2011-09-08 1:16 ` Tejun Heo
2011-09-06 12:26 ` Bruce Stenning
2011-09-06 14:40 ` Bruce Stenning
2011-09-06 15:22 ` Bruce Stenning
2011-04-26 18:37 ` Mark Lord
2011-04-13 15:10 ` Mark Lord
2011-04-13 16:13 ` Bruce Stenning
2011-04-14 16:50 ` Bruce Stenning
2011-04-15 0:28 ` Mark Lord
2011-04-15 13:21 ` Bruce Stenning
2011-04-15 15:36 ` Mark Lord
2011-04-18 10:30 ` Bruce Stenning
2011-04-23 0:56 ` Tejun Heo
2011-04-15 3:15 ` Mikael Abrahamsson
2011-04-15 3:32 ` Mark Lord
2011-04-15 7:43 ` Mikael Abrahamsson
2011-04-15 12:35 ` Mark Lord
2011-04-15 14:04 ` Mikael Abrahamsson
2011-04-15 15:30 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C1438B59050E1B4C9482FF3266AD6BA32C775549E4@gretna.indigovision.com \
--to=b.stenning@indigovision.com \
--cc=htejun@gmail.com \
--cc=kernel@teksavvy.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).