From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 432AAC433DF for ; Mon, 6 Jul 2020 14:31:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1ED862070B for ; Mon, 6 Jul 2020 14:31:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="G6sMfBcy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729195AbgGFObk (ORCPT ); Mon, 6 Jul 2020 10:31:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729148AbgGFObk (ORCPT ); Mon, 6 Jul 2020 10:31:40 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6FDEC061755 for ; Mon, 6 Jul 2020 07:31:39 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id q5so41179079wru.6 for ; Mon, 06 Jul 2020 07:31:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lhw/BUTROVOYN40TpUh0RgTpP5MGKfF0bQwNQn8IkII=; b=G6sMfBcyiYZnXJjewARbxvkBt3nPIhVdokEGhTOdGLVzWM49cWwLxahf6Rk2CZ1TFB s/0S87lpRaLeyIqVJQEXwzGp3bW5n5qiDoJasdHuh95CUnRkVR+HzZeQgjKbYbhlqt3b WD9MqtcyVkJe4aVoz5MvW6z5eWkzVtxC+SoaE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lhw/BUTROVOYN40TpUh0RgTpP5MGKfF0bQwNQn8IkII=; b=ncYn7aka8D6oTLn7HDSrYeM9Hqe95EWRZiXpdjTFbdg0n6s1nYXJ9XDGYMYPEPd/Zn /SNn7Pprf6v3oz2PKxTUMe2vCtYOi7VvHnIeytkEanxwtGkWvRPw0AcSPk6jsHnZ8QBQ E5GpXllr71+DXQ3J8LCvjHNf7IgP/1GuR96nj/MYRrvvnSuTZcXAuQn0ThN/SHhexFJI GX5z707U9OCmiauH6RYwvy5qNRp0pRqbYhFJvYqwMpnbFsawLoPld+g8qVx7LDIJoBEA 2+bbjXpp/wxsyyUMe3ebaUfHAb8S9Oe4Z7ojnS9tmbsCe67Vt+Hed5gRSxLCFzR3tptJ qi9Q== X-Gm-Message-State: AOAM530Yq8pd098+ISLTu0wxX/Qy4ULIhBh2I0Tmh8mMLpaGfVPZLLr4 KmmQL0AtsVM1b0dAreQ69itO3AJdqYjzkLrPP/fkfg== X-Google-Smtp-Source: ABdhPJyHqRH6FGwmZgD3+KEklIah/GrAEhS53xleM7Xl7Ibxb6V9FYXfGur/MTogqCYMmnM+3ePQijdxNsAEQ6ymJm4= X-Received: by 2002:adf:edc6:: with SMTP id v6mr49556859wro.413.1594045898580; Mon, 06 Jul 2020 07:31:38 -0700 (PDT) MIME-Version: 1.0 References: <20200701212155.37830-1-james.quinlan@broadcom.com> <20200701212155.37830-3-james.quinlan@broadcom.com> <968d6802-b30e-b618-1dd5-1b1a5ba6548a@cogentembedded.com> In-Reply-To: <968d6802-b30e-b618-1dd5-1b1a5ba6548a@cogentembedded.com> From: Jim Quinlan Date: Mon, 6 Jul 2020 10:31:27 -0400 Message-ID: Subject: Re: [PATCH v6 02/12] ata: ahci_brcm: Fix use of BCM7216 reset controller To: Sergei Shtylyov Cc: "open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS" , Nicolas Saenz Julienne , "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" , Jens Axboe , Philipp Zabel , Florian Fainelli , Hans de Goede , "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" , open list Content-Type: text/plain; charset="UTF-8" Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On Thu, Jul 2, 2020 at 5:32 AM Sergei Shtylyov wrote: > > Hello! > > On 02.07.2020 0:21, Jim Quinlan wrote: > > > From: Jim Quinlan > > > > A reset controller "rescal" is shared between the AHCI driver and the PCIe > > driver for the BrcmSTB 7216 chip. Use > > devm_reset_control_get_optional_shared control() to handle this sharing. > > Not "devm_reset_control_get_optional_shared() control"? Hi Sergei, sorry for the delay in my response. I will fix the above. Thanks again, Jim > > > > > > Signed-off-by: Jim Quinlan > > > > Fixes: 272ecd60a636 ("ata: ahci_brcm: BCM7216 reset is self de-asserting") > > Fixes: c345ec6a50e9 ("ata: ahci_brcm: Support BCM7216 reset controller name") > > --- > > drivers/ata/ahci_brcm.c | 11 +++-------- > > 1 file changed, 3 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/ata/ahci_brcm.c b/drivers/ata/ahci_brcm.c > > index 6853dbb4131d..d6115bc04b09 100644 > > --- a/drivers/ata/ahci_brcm.c > > +++ b/drivers/ata/ahci_brcm.c > [...] > > @@ -452,11 +451,10 @@ static int brcm_ahci_probe(struct platform_device *pdev) > > > > /* Reset is optional depending on platform and named differently */ > > if (priv->version == BRCM_SATA_BCM7216) > > - reset_name = "rescal"; > > + priv->rcdev = devm_reset_control_get_optional_shared(&pdev->dev, "rescal"); > > else > > - reset_name = "ahci"; > > + priv->rcdev = devm_reset_control_get_optional(&pdev->dev, "ahci"); > > > > - priv->rcdev = devm_reset_control_get_optional(&pdev->dev, reset_name); > > if (IS_ERR(priv->rcdev)) > > return PTR_ERR(priv->rcdev); > > > [...] > > MBR, Sergei