From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99FC2C433DF for ; Sat, 25 Jul 2020 10:24:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E43B206EB for ; Sat, 25 Jul 2020 10:24:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CuqnYAU7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726612AbgGYKYK (ORCPT ); Sat, 25 Jul 2020 06:24:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726572AbgGYKYJ (ORCPT ); Sat, 25 Jul 2020 06:24:09 -0400 Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C402C0619D3; Sat, 25 Jul 2020 03:24:08 -0700 (PDT) Received: by mail-pj1-x102e.google.com with SMTP id k71so6669234pje.0; Sat, 25 Jul 2020 03:24:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xya5iI6mez6VslA4WdyUYY4hYny+oShJ8iGDbkTMdog=; b=CuqnYAU7N/48bI5+Re7xSER7U0PmBoiTZMFXzwKrLovKAZSCrcZGp0tqyIzHE89WED 5D8i7ovJ2GSa5gbDx6uIi4SaEA6Gkdzd5tYYMZOOV59Z1BleX3fktbSILxWJecNUv9JG Z7U9r853PPne6Jjv3kzqB9Q9EIFM7N8xqXD+wbmwMBeumVF7akdhdghYi15pjPtWYE31 oORnDkHE1wHmQkrhiYKnDGP1pgUjnjGWaG9AY687angKKQbI7oMfP6qBIvwRhSaXc69F BPURuIRgGpimIylas2PUB99IEghQW1IEG+StN0XnSNb8Cz0RVdBZnJKL05y8fkHLiJB+ OIOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xya5iI6mez6VslA4WdyUYY4hYny+oShJ8iGDbkTMdog=; b=Dg1rJmfv9z4XtpdBTTN9JcyNpH0qnYRzojEgIenyCDpl2pobp0K94i5Oel/pVuk/Xh eHl6DMmyFyWqwoexsuRSMt0IFakkNTOiAvIZQu1fAFjNPX61m1GRPOcLbqDTyt4jDDjr 9auaT6NWek0tan59x91csisipcaTsxksiHuarlpQsxyTXMwxYq6xBnVbZPf6GEouHgnG 49FBPNPEsVrZNCCdhOzRaLa9f/+ltyrPT/sgg5kvjZcg6wMR5MGgOFLfDFrYKLB54Ulv YVZVCuJQ/nQthmrqm7K2HV57qOW7ruj9gOM8sthCtTMjTjiZEkY6FtOw6arYZ83ZdZ1y RZNg== X-Gm-Message-State: AOAM5301jPT1Y7xNL/wqVO4rzZks6w0+0PlKUF6Wr79sPEPGThCDdR+Y PoA+ZzqBYdl/LhqmratsWQsfVheU+Mk1Z6MClok= X-Google-Smtp-Source: ABdhPJxZDi30ldujm27ky8oI7MBOqxieiu1hysjQsqeG6INm3eAisFNDfHQewgGivDRncMAbee+CvYgrdtqqInaoAAg= X-Received: by 2002:a17:90a:498b:: with SMTP id d11mr9956403pjh.129.1595672647801; Sat, 25 Jul 2020 03:24:07 -0700 (PDT) MIME-Version: 1.0 References: <20200724171706.1550403-1-tasleson@redhat.com> <20200724171706.1550403-6-tasleson@redhat.com> In-Reply-To: <20200724171706.1550403-6-tasleson@redhat.com> From: Andy Shevchenko Date: Sat, 25 Jul 2020 13:23:51 +0300 Message-ID: Subject: Re: [v4 05/11] nvme: Add durable name for dev_printk To: Tony Asleson Cc: linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi , Bartlomiej Zolnierkiewicz , Jens Axboe Content-Type: text/plain; charset="UTF-8" Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On Fri, Jul 24, 2020 at 8:19 PM Tony Asleson wrote: > > Corrections from Keith Busch review comments. Good! And where is the commit message? > +static ssize_t wwid_show(struct device *dev, struct device_attribute *attr, > + char *buf); > + > +static int dev_to_nvme_durable_name(const struct device *dev, char *buf, size_t len) > +{ > + char serial[144]; /* Max 141 for wwid_show */ > + ssize_t serial_len = wwid_show((struct device *)dev, NULL, serial); > + > + if (serial_len > 0 && serial_len < len) { > + serial_len -= 1; /* Remove the '\n' from the string */ > + strncpy(buf, serial, serial_len); > + return serial_len; > + } > + return 0; > +} Sorry, but this is ugly. Can we rather get some common code from wwid_show() and reuse it there and here w/o above dances with \n? -- With Best Regards, Andy Shevchenko