From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 149C4C433E0 for ; Mon, 18 May 2020 11:24:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E8E89206D4 for ; Mon, 18 May 2020 11:24:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727772AbgERLYa (ORCPT ); Mon, 18 May 2020 07:24:30 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:40584 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726739AbgERLYa (ORCPT ); Mon, 18 May 2020 07:24:30 -0400 Received: by mail-ot1-f65.google.com with SMTP id d26so7695593otc.7; Mon, 18 May 2020 04:24:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=S+/xJo9DYFV5x/KGWI9bYykM6mq0Xnr1uVyyiFMOM94=; b=Y1TXobsoU2Lmp4U/8L5YGzh0WkqFwCw/MDZ87ObhHLJTWmtMOimQskBr1/pbdWjP75 MJzrlD6TnptUtEaImuH9sNuPt4YyZY3kI/HTJ2Up2RSXirs4GYPSz0Fge7nicdEz/GXA QFVOLgiLVF0FCpbcs/Es3B5UpiA2WBiJE6tQOqg0k9esI9Xo0rtm0BDS8NTQRvTC52rI T2MUGuFN/USBlEWEvvu8A7v1EurJ9jMydykR8leyxtxK7z6sN0sRdwm799HfTLh1wBbA R09IycWVjec5eWiT1qKk9BmSI0iz5xpu/HVR2h+lOnPH5CgksqfwPiBu4DvmfixZXtoV hKKQ== X-Gm-Message-State: AOAM5312P1nLMyt2BTLykHafZ924Fj7G0tJKVbPDOAEitDbdmca0qxiM EkRPKMopYj89LiZqofOeAGvu6VLLt0g0JqaA9SA= X-Google-Smtp-Source: ABdhPJwNoxButZwgH4SDPteHjBuwwMLD1bqxVYkjDcQmRozmQtDNJ0fFE+TRSmeEzroqrNyEaK173xc8SAa+z83VsXs= X-Received: by 2002:a05:6830:18d9:: with SMTP id v25mr7897454ote.107.1589801068351; Mon, 18 May 2020 04:24:28 -0700 (PDT) MIME-Version: 1.0 References: <1589555337-5498-1-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> <1589555337-5498-6-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com> <20200515171754.GF19423@ninjato> In-Reply-To: <20200515171754.GF19423@ninjato> From: Geert Uytterhoeven Date: Mon, 18 May 2020 13:24:15 +0200 Message-ID: Subject: Re: [PATCH 05/17] mmc: renesas_sdhi_sys_dmac: Add support for r8a7742 SoC To: Wolfram Sang Cc: Lad Prabhakar , Jens Axboe , Rob Herring , Ulf Hansson , Sergei Shtylyov , "David S. Miller" , Wim Van Sebroeck , Guenter Roeck , linux-ide@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Linux I2C , Linux MMC List , netdev , Linux-Renesas , Linux Watchdog Mailing List , Prabhakar Content-Type: text/plain; charset="UTF-8" Sender: linux-ide-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org Hi Wolfram, Prabhakar, On Fri, May 15, 2020 at 7:17 PM Wolfram Sang wrote: > On Fri, May 15, 2020 at 04:08:45PM +0100, Lad Prabhakar wrote: > > Add support for r8a7742 SoC. Renesas RZ/G1H (R8A7742) SDHI is identical to > > the R-Car Gen2 family. > > > > Signed-off-by: Lad Prabhakar > > Reviewed-by: Marian-Cristian Rotariu > > I think we can skip this because of the generic fallback? The other Agreed. > entries come from a time when we had a different policy IIRC. Indeed. Commit c16a854e4463078a ("mmc: renesas_sdhi: Add r8a7743/5 support") predated commit d6dc425ae595e140 ("mmc: renesas_sdhi: implement R-Car Gen[123] fallback compatibility strings"). > > --- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c > > +++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c > > @@ -75,6 +75,7 @@ static const struct of_device_id renesas_sdhi_sys_dmac_of_match[] = { > > { .compatible = "renesas,sdhi-r7s72100", .data = &of_rz_compatible, }, > > { .compatible = "renesas,sdhi-r8a7778", .data = &of_rcar_gen1_compatible, }, > > { .compatible = "renesas,sdhi-r8a7779", .data = &of_rcar_gen1_compatible, }, > > + { .compatible = "renesas,sdhi-r8a7742", .data = &of_rcar_gen2_compatible, }, > > { .compatible = "renesas,sdhi-r8a7743", .data = &of_rcar_gen2_compatible, }, > > { .compatible = "renesas,sdhi-r8a7745", .data = &of_rcar_gen2_compatible, }, > > { .compatible = "renesas,sdhi-r8a7790", .data = &of_rcar_gen2_compatible, }, Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds