From: Michael Schmitz <schmitzmic@gmail.com> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: "Linux/m68k" <linux-m68k@vger.kernel.org>, linux-ide@vger.kernel.org, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Michael Schmitz <schmitz@debian.org> Subject: Re: [PATCH] ide: falconide: convert to platform driver Date: Wed, 6 Nov 2019 07:31:21 +1300 Message-ID: <CAOmrzkKLosq7LdXS6BuvHSARPXCXPiasW1zGywY3+hoys4NxoA@mail.gmail.com> (raw) In-Reply-To: <CAMuHMdXM+h_GsbkSvyfpLJ0DJixmr-wOS_d5qQrZ8e7VY_bbPg@mail.gmail.com> Hi Geert, thanks for the review! On Tue, Nov 5, 2019 at 9:11 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Michael, > > On Tue, Nov 5, 2019 at 7:38 AM Michael Schmitz <schmitzmic@gmail.com> wrote: > > With the introduction of a platform device for the Atari Falcon IDE > > interface, the old Falcon IDE driver no longer loads (resource already > > claimed by the platform device). > > > > Convert falconide driver to use the same platform device that is used > > by pata_falcon also. > > > > Tested (as built-in driver) on my Atari Falcon. > > > > Signed-off-by: Michael Schmitz <schmitzmic@gmail.com> > > CC: Geert Uytterhoeven <geert@linux-m68k.org> > > Thanks for your patch! > > > --- a/drivers/ide/falconide.c > > +++ b/drivers/ide/falconide.c > > @@ -15,6 +15,7 @@ > > #include <linux/blkdev.h> > > #include <linux/ide.h> > > #include <linux/init.h> > > +#include <linux/platform_device.h> > > > > #include <asm/setup.h> > > #include <asm/atarihw.h> > > @@ -23,6 +24,7 @@ > > #include <asm/ide.h> > > > > #define DRV_NAME "falconide" > > +#define DRV_VERSION "0.1.0" > > Does anyone care about that version? Not likely. > Will it ever be updated? You ask me? You're still listed as driver author! I'll remove the version. > > > @@ -169,10 +177,21 @@ static int __init falconide_init(void) Should I remove the __init here? Doesn't hurt in the built-in use case, what about use as a module? > > err_free: > > ide_host_free(host); > > err: > > - release_mem_region(ATA_HD_BASE, 0x40); > > + release_mem_region(res->start, resource_size(res)); > > return rc; > > } > > > > -module_init(falconide_init); > > +static struct platform_driver ide_falcon_driver = { > > + .driver = { > > + .name = "atari-falcon-ide", > > + }, > > +}; > > Missing .remove() callback. Can't easily test driver remove, but I can certainly add a callback for that. ide_unregister does the Right Thing (i.e. leaves the ST-DMA interrupt registered) so no reason why it shouldn't work. > > > + > > +module_platform_driver_probe(ide_falcon_driver, falconide_init); > > + > > > > +MODULE_AUTHOR("Geert Uytterhoeven"); > > +MODULE_DESCRIPTION("low-level driver for Atari Falcon IDE"); > > MODULE_LICENSE("GPL"); > > +MODULE_ALIAS("platform:atari-falcon-ide"); > > +MODULE_VERSION(DRV_VERSION); > > I'd drop the MODULE_VERSION(). Done. Shall I merge this one with part one of the old series so there's no chance of a bisection going wrong? Cheers, Michael > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
next prev parent reply index Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-26 3:54 [PATCH RESEND v2 0/2] Convert Atari Falcon IDE driver to platform device Michael Schmitz 2019-09-26 3:54 ` [PATCH RESEND v2 1/2] m68k/atari: add platform device for Falcon IDE port Michael Schmitz 2019-11-04 10:56 ` Geert Uytterhoeven 2019-11-04 21:09 ` Michael Schmitz 2019-11-05 6:37 ` [PATCH] ide: falconide: convert to platform driver Michael Schmitz 2019-11-05 8:11 ` Geert Uytterhoeven 2019-11-05 18:31 ` Michael Schmitz [this message] 2019-11-05 18:46 ` Geert Uytterhoeven 2019-11-05 20:02 ` Michael Schmitz 2019-11-05 21:13 ` Michael Schmitz 2019-11-05 21:43 ` Geert Uytterhoeven 2019-11-06 1:35 ` Michael Schmitz 2019-11-05 6:43 ` [PATCH RESEND v2 1/2] m68k/atari: add platform device for Falcon IDE port Michael Schmitz 2019-09-26 3:54 ` [PATCH RESEND v2 2/2] drivers/ata: convert pata_falcon to arch platform device Michael Schmitz 2019-11-04 10:58 ` Geert Uytterhoeven 2019-10-25 20:33 ` [PATCH RESEND v2 0/2] Convert Atari Falcon IDE driver to " Jens Axboe 2019-10-26 18:17 ` Geert Uytterhoeven 2019-10-28 7:03 ` Michael Schmitz 2019-11-04 11:04 ` Geert Uytterhoeven 2019-11-04 19:17 ` Michael Schmitz 2019-11-04 20:06 ` Geert Uytterhoeven 2019-11-04 21:10 ` John Paul Adrian Glaubitz 2019-11-04 21:21 ` Michael Schmitz 2019-11-04 21:42 ` John Paul Adrian Glaubitz 2019-11-05 6:57 ` Michael Schmitz 2019-11-06 1:34 ` Michael Schmitz 2019-11-06 2:47 ` [PATCH v3] m68k/atari: convert legacy Falcon IDE driver to platform driver Michael Schmitz 2019-11-18 9:20 ` Geert Uytterhoeven 2019-11-18 9:41 ` John Paul Adrian Glaubitz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAOmrzkKLosq7LdXS6BuvHSARPXCXPiasW1zGywY3+hoys4NxoA@mail.gmail.com \ --to=schmitzmic@gmail.com \ --cc=b.zolnierkie@samsung.com \ --cc=geert@linux-m68k.org \ --cc=linux-ide@vger.kernel.org \ --cc=linux-m68k@vger.kernel.org \ --cc=schmitz@debian.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-ide Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-ide/0 linux-ide/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-ide linux-ide/ https://lore.kernel.org/linux-ide \ linux-ide@vger.kernel.org public-inbox-index linux-ide Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-ide AGPL code for this site: git clone https://public-inbox.org/public-inbox.git