From: Rob Herring <robh@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: devicetree@vger.kernel.org,
"Damien Le Moal" <damien.lemoal@opensource.wdc.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
"Gregory Fong" <gregory.0xf0@gmail.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Marc Zyngier" <maz@kernel.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Lee Jones" <lee.jones@linaro.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Amit Kucheria" <amitk@kernel.org>,
"Zhang Rui" <rui.zhang@intel.com>,
"Markus Mayer" <mmayer@broadcom.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Al Cooper" <alcooperx@gmail.com>,
"Doug Berger" <opendmb@gmail.com>,
"open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)"
<linux-ide@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list:MULTIMEDIA CARD (MMC),
SECURE DIGITAL (SD) AND..." <linux-mmc@vger.kernel.org>,
"open list:PWM SUBSYSTEM" <linux-pwm@vger.kernel.org>,
"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
<linux-crypto@vger.kernel.org>,
"open list:REAL TIME CLOCK (RTC) SUBSYSTEM"
<linux-rtc@vger.kernel.org>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
"open list:USB SUBSYSTEM" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH v3 13/15] dt-bindings: ata: Convert Broadcom SATA to YAML
Date: Tue, 14 Dec 2021 13:10:35 -0600 [thread overview]
Message-ID: <YbjsK50twTm0PWj9@robh.at.kernel.org> (raw)
In-Reply-To: <20211208003727.3596577-14-f.fainelli@gmail.com>
On Tue, Dec 07, 2021 at 04:37:24PM -0800, Florian Fainelli wrote:
> Convert the Broadcom SATA3 AHCI controller Device Tree binding to YAML
> to help with validation.
>
> Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> .../bindings/ata/brcm,sata-brcm.txt | 45 ---------
> .../bindings/ata/brcm,sata-brcm.yaml | 98 +++++++++++++++++++
> 2 files changed, 98 insertions(+), 45 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/ata/brcm,sata-brcm.txt
> create mode 100644 Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml
>
> diff --git a/Documentation/devicetree/bindings/ata/brcm,sata-brcm.txt b/Documentation/devicetree/bindings/ata/brcm,sata-brcm.txt
> deleted file mode 100644
> index b9ae4ce4a0a0..000000000000
> --- a/Documentation/devicetree/bindings/ata/brcm,sata-brcm.txt
> +++ /dev/null
> @@ -1,45 +0,0 @@
> -* Broadcom SATA3 AHCI Controller
> -
> -SATA nodes are defined to describe on-chip Serial ATA controllers.
> -Each SATA controller should have its own node.
> -
> -Required properties:
> -- compatible : should be one or more of
> - "brcm,bcm7216-ahci"
> - "brcm,bcm7425-ahci"
> - "brcm,bcm7445-ahci"
> - "brcm,bcm-nsp-ahci"
> - "brcm,sata3-ahci"
> - "brcm,bcm63138-ahci"
> -- reg : register mappings for AHCI and SATA_TOP_CTRL
> -- reg-names : "ahci" and "top-ctrl"
> -- interrupts : interrupt mapping for SATA IRQ
> -
> -Optional properties:
> -
> -- reset: for "brcm,bcm7216-ahci" must be a valid reset phandle
> - pointing to the RESCAL reset controller provider node.
> -- reset-names: for "brcm,bcm7216-ahci", must be "rescal".
> -
> -Also see ahci-platform.txt.
> -
> -Example:
> -
> - sata@f045a000 {
> - compatible = "brcm,bcm7445-ahci", "brcm,sata3-ahci";
> - reg = <0xf045a000 0xa9c>, <0xf0458040 0x24>;
> - reg-names = "ahci", "top-ctrl";
> - interrupts = <0 30 0>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - sata0: sata-port@0 {
> - reg = <0>;
> - phys = <&sata_phy 0>;
> - };
> -
> - sata1: sata-port@1 {
> - reg = <1>;
> - phys = <&sata_phy 1>;
> - };
> - };
> diff --git a/Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml b/Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml
> new file mode 100644
> index 000000000000..3e24f45c65af
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml
> @@ -0,0 +1,98 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/ata/brcm,sata-brcm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom SATA3 AHCI Controller
> +
> +description:
> + SATA nodes are defined to describe on-chip Serial ATA controllers.
> + Each SATA controller should have its own node.
> +
> +maintainers:
> + - Florian Fainelli <f.fainelli@gmail.com>
> +
> +allOf:
> + - $ref: sata-common.yaml#
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - brcm,bcm7216-ahci
> + - const: brcm,sata3-ahci
> + - items:
> + - enum:
> + - brcm,bcm7445-ahci
> + - const: brcm,sata3-ahci
> + - items:
> + - enum:
> + - brcm,bcm7425-ahci
> + - const: brcm,sata3-ahci
> + - items:
> + - const: brcm,bcm-nsp-ahci
> + - items:
> + - enum:
> + - brcm,bcm63138-ahci
> + - const: brcm,sata3-ahci
Is there some reason this is not grouped into 2 oneOf entries? If not, I
can fixup.
> +
> + reg:
> + minItems: 2
> + maxItems: 2
> +
> + reg-names:
> + items:
> + - const: ahci
> + - const: top-ctrl
> +
> + interrupts: true
maxItems: 1 ?
> +
> + dma-coherent: true
> +
> +if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - brcm,bcm7216-ahci
> + - brcm,bcm63138-ahci
> +then:
> + properties:
> + resets:
> + maxItems: 1
> + reset-names:
> + enum:
> + - rescal
> + - ahci
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - "#address-cells"
> + - "#size-cells"
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + sata@f045a000 {
> + compatible = "brcm,bcm7445-ahci", "brcm,sata3-ahci";
> + reg = <0xf045a000 0xa9c>, <0xf0458040 0x24>;
> + reg-names = "ahci", "top-ctrl";
> + interrupts = <0 30 0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sata0: sata-port@0 {
> + reg = <0>;
> + phys = <&sata_phy 0>;
> + };
> +
> + sata1: sata-port@1 {
> + reg = <1>;
> + phys = <&sata_phy 1>;
> + };
> + };
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2021-12-14 19:10 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 0:37 [PATCH v3 00/15] Broadcom DT bindings updates to YAML Florian Fainelli
2021-12-08 0:37 ` [PATCH v3 01/15] dt-bindings: mmc: Convert Broadcom STB SDHCI binding " Florian Fainelli
2022-01-05 16:39 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 02/15] dt-bindings: reset: Convert Broadcom STB reset " Florian Fainelli
2021-12-09 9:41 ` Philipp Zabel
2021-12-09 23:25 ` Florian Fainelli
2021-12-14 17:47 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 03/15] dt-bindings: pwm: Convert BCM7038 PWM binding " Florian Fainelli
2021-12-14 17:47 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 04/15] dt-bindings: rtc: Convert Broadcom STB waketimer " Florian Fainelli
2021-12-14 18:00 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 05/15] dt-bindings: gpio: Convert Broadcom STB GPIO " Florian Fainelli
2021-12-10 1:44 ` Linus Walleij
2021-12-10 15:22 ` Bartosz Golaszewski
2021-12-14 18:02 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 06/15] dt-binding: interrupt-controller: Convert BCM7038 L1 intc " Florian Fainelli
2021-12-14 18:04 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 07/15] dt-bindings: interrupt-controller: Convert BCM7120 L2 " Florian Fainelli
2021-12-14 18:06 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 08/15] dt-bindings: interrupt-controller: Merge BCM3380 with BCM7120 Florian Fainelli
2021-12-08 0:37 ` [PATCH v3 09/15] dt-bindings: interrupt-controller: Convert Broadcom STB L2 to YAML Florian Fainelli
2021-12-14 18:14 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 10/15] dt-bindings: rng: Convert iProc RNG200 " Florian Fainelli
2021-12-14 18:17 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 11/15] dt-bindings: thermal: Convert Broadcom TMON " Florian Fainelli
2021-12-14 18:18 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 12/15] ARM: dts: NSP: Rename SATA unit name Florian Fainelli
2021-12-08 1:23 ` Damien Le Moal
2021-12-08 0:37 ` [PATCH v3 13/15] dt-bindings: ata: Convert Broadcom SATA to YAML Florian Fainelli
2021-12-08 13:44 ` Rob Herring
2021-12-08 17:33 ` Florian Fainelli
2021-12-14 18:28 ` Rob Herring
2021-12-14 19:10 ` Rob Herring [this message]
2021-12-08 0:37 ` [PATCH v3 14/15] dt-bindings: bus: Convert GISB arbiter " Florian Fainelli
2021-12-14 19:14 ` Rob Herring
2021-12-08 0:37 ` [PATCH v3 15/15] dt-bindings: usb: Convert BDC " Florian Fainelli
2021-12-14 19:16 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbjsK50twTm0PWj9@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alcooperx@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=amitk@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@bgdev.pl \
--cc=damien.lemoal@opensource.wdc.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.0xf0@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mmayer@broadcom.com \
--cc=opendmb@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=rafael@kernel.org \
--cc=rjui@broadcom.com \
--cc=rui.zhang@intel.com \
--cc=sbranden@broadcom.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).