linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Damien Le Moal <damien.lemoal@wdc.com>,
	Jens Axboe <axboe@kernel.dk>,
	linux-ide@vger.kernel.org
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH v5 1/9] libata: fix ata_host_alloc_pinfo()
Date: Tue, 10 Aug 2021 08:06:24 +0200	[thread overview]
Message-ID: <a4bf7bcf-9a73-991b-019a-35ebfe5ffecb@suse.de> (raw)
In-Reply-To: <20210810054939.30760-2-damien.lemoal@wdc.com>

On 8/10/21 7:49 AM, Damien Le Moal wrote:
> Avoid static checkers warnings about a potential NULL pointer
> dereference for the port info variable pi. To do so, test that at least
> one port info is available on entry to ata_host_alloc_pinfo() and start
> the ata port initialization for() loop with pi initialized to the first
> port info passed as argument (which is already checked to be non NULL).
> Within the for() loop, get the next port info, if it is not NULL,
> after initializing the ata port using the previous port info.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
>   drivers/ata/libata-core.c | 18 ++++++++++++++----
>   1 file changed, 14 insertions(+), 4 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer

  reply	other threads:[~2021-08-10  6:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10  5:49 [PATCH v5 0/9] libata cleanups and improvements Damien Le Moal
2021-08-10  5:49 ` [PATCH v5 1/9] libata: fix ata_host_alloc_pinfo() Damien Le Moal
2021-08-10  6:06   ` Hannes Reinecke [this message]
2021-08-10  5:49 ` [PATCH v5 2/9] libata: fix ata_host_start() Damien Le Moal
2021-08-10  5:49 ` [PATCH v5 3/9] libata: simplify ata_scsi_rbuf_fill() Damien Le Moal
2021-08-10  5:49 ` [PATCH v5 4/9] libata: cleanup device sleep capability detection Damien Le Moal
2021-08-10  5:49 ` [PATCH v5 5/9] libata: cleanup ata_dev_configure() Damien Le Moal
2021-08-10  5:49 ` [PATCH v5 6/9] libata: cleanup NCQ priority handling Damien Le Moal
2021-08-10  5:49 ` [PATCH v5 7/9] libata: fix ata_read_log_page() warning Damien Le Moal
2021-08-10  5:49 ` [PATCH v5 8/9] libata: print feature list on device scan Damien Le Moal
2021-08-10  5:49 ` [PATCH v5 9/9] libahci: Introduce ncq_prio_supported sysfs sttribute Damien Le Moal
2021-08-11 19:07   ` Niklas Cassel
2021-08-11 23:30     ` Damien Le Moal
2021-08-13 13:56       ` Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4bf7bcf-9a73-991b-019a-35ebfe5ffecb@suse.de \
    --to=hare@suse.de \
    --cc=axboe@kernel.dk \
    --cc=damien.lemoal@wdc.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --subject='Re: [PATCH v5 1/9] libata: fix ata_host_alloc_pinfo()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).