From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Jens Axboe <axboe@kernel.dk>, linux-ide@vger.kernel.org
Subject: Re: [PATCH 14/46] libata: add reset tracepoints
Date: Mon, 10 Feb 2020 14:42:44 +0100 [thread overview]
Message-ID: <a9df9616-03c7-48bb-026a-e99cbef5ad44@samsung.com> (raw)
In-Reply-To: <20200204165547.115220-15-hare@suse.de>
On 2/4/20 5:55 PM, Hannes Reinecke wrote:
> To follow the flow of control we should be using tracepoints, as
> they will tie in with the actual I/O flow and deliver a better
> overview about what it happening.
> This patch adds tracepoints for hard and soft reset and adds
> them in the libata-eh control flow.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
checkpatch.pl complains about CodingStyle issues:
WARNING: line over 80 characters
#164: FILE: include/trace/events/libata.h:350:
+ TP_PROTO(struct ata_link *link, unsigned int *class, unsigned long deadline),
ERROR: space prohibited after that open parenthesis '('
#169: FILE: include/trace/events/libata.h:355:
+ __field( unsigned int, ata_port )
ERROR: space prohibited before that close parenthesis ')'
#169: FILE: include/trace/events/libata.h:355:
+ __field( unsigned int, ata_port )
ERROR: space prohibited after that open parenthesis '('
#170: FILE: include/trace/events/libata.h:356:
+ __array( unsigned int, class, 2)
ERROR: space prohibited after that open parenthesis '('
#171: FILE: include/trace/events/libata.h:357:
+ __field( unsigned long, deadline)
WARNING: line over 80 characters
#187: FILE: include/trace/events/libata.h:373:
+ TP_PROTO(struct ata_link *link, unsigned int *class, unsigned long deadline),
WARNING: line over 80 characters
#191: FILE: include/trace/events/libata.h:377:
+ TP_PROTO(struct ata_link *link, unsigned int *class, unsigned long deadline),
WARNING: line over 80 characters
#195: FILE: include/trace/events/libata.h:381:
+ TP_PROTO(struct ata_link *link, unsigned int *class, unsigned long deadline),
ERROR: space prohibited after that open parenthesis '('
#205: FILE: include/trace/events/libata.h:391:
+ __field( unsigned int, ata_port )
ERROR: space prohibited before that close parenthesis ')'
#205: FILE: include/trace/events/libata.h:391:
+ __field( unsigned int, ata_port )
ERROR: space prohibited after that open parenthesis '('
#206: FILE: include/trace/events/libata.h:392:
+ __array( unsigned int, class, 2)
ERROR: space prohibited after that open parenthesis '('
#207: FILE: include/trace/events/libata.h:393:
+ __field( int, rc)
Otherwise the patch looks fine.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/ata/libata-eh.c | 16 +++++++-
> include/trace/events/libata.h | 88 +++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 102 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> index 3bfd9da58473..253dcf903c1b 100644
> --- a/drivers/ata/libata-eh.c
> +++ b/drivers/ata/libata-eh.c
> @@ -2787,12 +2787,19 @@ int ata_eh_reset(struct ata_link *link, int classify,
>
> /* mark that this EH session started with reset */
> ehc->last_reset = jiffies;
> - if (reset == hardreset)
> + if (reset == hardreset) {
> ehc->i.flags |= ATA_EHI_DID_HARDRESET;
> - else
> + trace_ata_link_hardreset_begin(link, classes, deadline);
> + } else {
> ehc->i.flags |= ATA_EHI_DID_SOFTRESET;
> + trace_ata_link_softreset_begin(link, classes, deadline);
> + }
>
> rc = ata_do_reset(link, reset, classes, deadline, true);
> + if (reset == hardreset)
> + trace_ata_link_hardreset_end(link, classes, rc);
> + else
> + trace_ata_link_softreset_end(link, classes, rc);
> if (rc && rc != -EAGAIN) {
> failed_link = link;
> goto fail;
> @@ -2806,8 +2813,11 @@ int ata_eh_reset(struct ata_link *link, int classify,
> ata_link_info(slave, "hard resetting link\n");
>
> ata_eh_about_to_do(slave, NULL, ATA_EH_RESET);
> + trace_ata_slave_hardreset_begin(slave, classes,
> + deadline);
> tmp = ata_do_reset(slave, reset, classes, deadline,
> false);
> + trace_ata_slave_hardreset_end(slave, classes, tmp);
> switch (tmp) {
> case -EAGAIN:
> rc = -EAGAIN;
> @@ -2834,7 +2844,9 @@ int ata_eh_reset(struct ata_link *link, int classify,
> }
>
> ata_eh_about_to_do(link, NULL, ATA_EH_RESET);
> + trace_ata_link_softreset_begin(link, classes, deadline);
> rc = ata_do_reset(link, reset, classes, deadline, true);
> + trace_ata_link_softreset_end(link, classes, rc);
> if (rc) {
> failed_link = link;
> goto fail;
> diff --git a/include/trace/events/libata.h b/include/trace/events/libata.h
> index ab69434e2329..e9fb4d44eeac 100644
> --- a/include/trace/events/libata.h
> +++ b/include/trace/events/libata.h
> @@ -132,6 +132,22 @@
> ata_protocol_name(ATAPI_PROT_PIO), \
> ata_protocol_name(ATAPI_PROT_DMA))
>
> +#define ata_class_name(class) { class, #class }
> +#define show_class_name(val) \
> + __print_symbolic(val, \
> + ata_class_name(ATA_DEV_UNKNOWN), \
> + ata_class_name(ATA_DEV_ATA), \
> + ata_class_name(ATA_DEV_ATA_UNSUP), \
> + ata_class_name(ATA_DEV_ATAPI), \
> + ata_class_name(ATA_DEV_ATAPI_UNSUP), \
> + ata_class_name(ATA_DEV_PMP), \
> + ata_class_name(ATA_DEV_PMP_UNSUP), \
> + ata_class_name(ATA_DEV_SEMB), \
> + ata_class_name(ATA_DEV_SEMB_UNSUP), \
> + ata_class_name(ATA_DEV_ZAC), \
> + ata_class_name(ATA_DEV_ZAC_UNSUP), \
> + ata_class_name(ATA_DEV_NONE))
> +
> const char *libata_trace_parse_status(struct trace_seq*, unsigned char);
> #define __parse_status(s) libata_trace_parse_status(p, s)
>
> @@ -329,6 +345,78 @@ TRACE_EVENT(ata_eh_link_autopsy_qc,
> __parse_eh_err_mask(__entry->eh_err_mask))
> );
>
> +DECLARE_EVENT_CLASS(ata_link_reset_begin_template,
> +
> + TP_PROTO(struct ata_link *link, unsigned int *class, unsigned long deadline),
> +
> + TP_ARGS(link, class, deadline),
> +
> + TP_STRUCT__entry(
> + __field( unsigned int, ata_port )
> + __array( unsigned int, class, 2)
> + __field( unsigned long, deadline)
> + ),
> +
> + TP_fast_assign(
> + __entry->ata_port = link->ap->print_id;
> + memcpy(__entry->class, class, 2);
> + __entry->deadline = deadline;
> + ),
> +
> + TP_printk("ata_port=%u deadline=%lu classes=[%s,%s]",
> + __entry->ata_port, __entry->deadline,
> + show_class_name(__entry->class[0]),
> + show_class_name(__entry->class[1]))
> +);
> +
> +DEFINE_EVENT(ata_link_reset_begin_template, ata_link_hardreset_begin,
> + TP_PROTO(struct ata_link *link, unsigned int *class, unsigned long deadline),
> + TP_ARGS(link, class, deadline));
> +
> +DEFINE_EVENT(ata_link_reset_begin_template, ata_slave_hardreset_begin,
> + TP_PROTO(struct ata_link *link, unsigned int *class, unsigned long deadline),
> + TP_ARGS(link, class, deadline));
> +
> +DEFINE_EVENT(ata_link_reset_begin_template, ata_link_softreset_begin,
> + TP_PROTO(struct ata_link *link, unsigned int *class, unsigned long deadline),
> + TP_ARGS(link, class, deadline));
> +
> +DECLARE_EVENT_CLASS(ata_link_reset_end_template,
> +
> + TP_PROTO(struct ata_link *link, unsigned int *class, int rc),
> +
> + TP_ARGS(link, class, rc),
> +
> + TP_STRUCT__entry(
> + __field( unsigned int, ata_port )
> + __array( unsigned int, class, 2)
> + __field( int, rc)
> + ),
> +
> + TP_fast_assign(
> + __entry->ata_port = link->ap->print_id;
> + memcpy(__entry->class, class, 2);
> + __entry->rc = rc;
> + ),
> +
> + TP_printk("ata_port=%u rc=%d class=[%s,%s]",
> + __entry->ata_port, __entry->rc,
> + show_class_name(__entry->class[0]),
> + show_class_name(__entry->class[1]))
> +);
> +
> +DEFINE_EVENT(ata_link_reset_end_template, ata_link_hardreset_end,
> + TP_PROTO(struct ata_link *link, unsigned int *class, int rc),
> + TP_ARGS(link, class, rc));
> +
> +DEFINE_EVENT(ata_link_reset_end_template, ata_slave_hardreset_end,
> + TP_PROTO(struct ata_link *link, unsigned int *class, int rc),
> + TP_ARGS(link, class, rc));
> +
> +DEFINE_EVENT(ata_link_reset_end_template, ata_link_softreset_end,
> + TP_PROTO(struct ata_link *link, unsigned int *class, int rc),
> + TP_ARGS(link, class, rc));
> +
> #endif /* _TRACE_LIBATA_H */
>
> /* This part must be outside protection */
>
next prev parent reply other threads:[~2020-02-10 13:42 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 16:55 [PATCH 00/46] ata: kill ATA_DEBUG Hannes Reinecke
2020-02-04 16:55 ` [PATCH 01/46] libata: drop BPRINTK() Hannes Reinecke
2020-02-04 16:55 ` [PATCH 02/46] libata.h: whitespace and indentation fixes Hannes Reinecke
2020-02-10 11:51 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 03/46] libata-transport: Whitespace cleanup Hannes Reinecke
2020-02-10 11:52 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 04/46] libata: move ata_{port,link,dev}_dbg to standard dev_XXX() macros Hannes Reinecke
2020-02-10 12:25 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 05/46] libata: remove pointless debugging messages Hannes Reinecke
2020-02-10 12:34 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 06/46] ata_piix: remove debugging message in piix_init() Hannes Reinecke
2020-02-10 12:36 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 07/46] libata-core: remove pointless debugging messages Hannes Reinecke
2020-02-05 8:08 ` Sergei Shtylyov
2020-02-10 12:37 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 08/46] libata: Add ata_port_classify() helper Hannes Reinecke
2020-02-10 12:44 ` Bartlomiej Zolnierkiewicz
2020-02-13 7:15 ` Hannes Reinecke
2020-02-04 16:55 ` [PATCH 09/46] libata: move ata_dump_id() to dynamic debugging Hannes Reinecke
2020-02-05 1:51 ` kbuild test robot
2020-02-10 12:47 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 10/46] sata_mv: replace DPRINTK with 'pci_dump' module parameter Hannes Reinecke
2020-02-10 12:51 ` Bartlomiej Zolnierkiewicz
2020-02-10 12:54 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 11/46] sata_nv: move DPRINTK to ata debugging Hannes Reinecke
2020-02-10 13:25 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 12/46] sata_sx4: move DPRINTK to VPRINTK Hannes Reinecke
2020-02-10 13:29 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 13/46] ata_piix: Drop DPRINTK() statement Hannes Reinecke
2020-02-10 13:32 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 14/46] libata: add reset tracepoints Hannes Reinecke
2020-02-10 13:42 ` Bartlomiej Zolnierkiewicz [this message]
2020-02-12 10:11 ` Hannes Reinecke
2020-02-04 16:55 ` [PATCH 15/46] ahci: drop DPRINTK() calls in reset Hannes Reinecke
2020-02-10 13:43 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 16/46] ahci_qorig: " Hannes Reinecke
2020-02-10 13:45 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 17/46] pata_octeon_cf: " Hannes Reinecke
2020-02-10 13:46 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 18/46] libahci: " Hannes Reinecke
2020-02-10 13:46 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 19/46] sata_rcar: " Hannes Reinecke
2020-02-10 13:48 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 20/46] sata_sil24: " Hannes Reinecke
2020-02-10 13:48 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 21/46] sata_fsl: " Hannes Reinecke
2020-02-10 13:49 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 22/46] libata-core: " Hannes Reinecke
2020-02-10 13:50 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 23/46] libata-sff: " Hannes Reinecke
2020-02-10 13:54 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 24/46] libata: tracepoints for bus-master DMA Hannes Reinecke
2020-02-10 15:21 ` Bartlomiej Zolnierkiewicz
2020-02-10 15:23 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 25/46] libata-sff: add tracepoints for HSM state machine Hannes Reinecke
2020-02-10 15:32 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 26/46] pata_octeon_cf: add bmdma tracepoints and drop DPRINTK() Hannes Reinecke
2020-02-10 15:36 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 27/46] sata_rcar: drop DPRINTK call in sata_rcar_exec_command() Hannes Reinecke
2020-02-10 15:37 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 28/46] libata-scsi: drop DPRINTK calls for cdb translation Hannes Reinecke
2020-02-10 15:40 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 29/46] libata-sff: add tracepoints for ata_sff_flush_pio_task() Hannes Reinecke
2020-02-10 15:44 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 30/46] libata-core: add postreset tracepoints Hannes Reinecke
2020-02-10 15:47 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 31/46] pata_octeon_cf: move DPRINTK to VPRINTK Hannes Reinecke
2020-02-10 15:48 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 32/46] pata_pdc202xx_old: Drop DPRINTK in pdc202xx_exec_command() Hannes Reinecke
2020-02-10 15:49 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 33/46] pata_sil680: Drop DPRINTK in sil_sff_exec_command() Hannes Reinecke
2020-02-10 15:51 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 34/46] pdc_adma: move DPRINTK to VPRINTK Hannes Reinecke
2020-02-10 15:52 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 35/46] sata_rcar: " Hannes Reinecke
2020-02-10 15:52 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 36/46] sata_qstor: " Hannes Reinecke
2020-02-10 15:53 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 37/46] pata_pdc2027x: Replace PDPRINTK() with standard ata logging Hannes Reinecke
2020-02-10 15:59 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 38/46] sata_fsl: move DPRINTK to ata debugging Hannes Reinecke
2020-02-10 16:07 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 39/46] libata: add tracepoints for ATA error handling Hannes Reinecke
2020-02-10 16:45 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 40/46] libata-eh: remove DPRINTK() calls for request sense Hannes Reinecke
2020-02-10 16:46 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 41/46] libata-core: move DPRINTK to ata debugging Hannes Reinecke
2020-02-10 16:48 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 42/46] libata: remove DPRINTK() macro Hannes Reinecke
2020-02-04 16:55 ` [PATCH 43/46] libata: kill ATA_MSG_INFO Hannes Reinecke
2020-02-10 16:49 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 44/46] libata: kill ATA_MSG_CTL Hannes Reinecke
2020-02-10 16:49 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 45/46] libata: remove references to ATA_DEBUG Hannes Reinecke
2020-02-10 16:50 ` Bartlomiej Zolnierkiewicz
2020-02-04 16:55 ` [PATCH 46/46] libata: remove ATA_NDEBUG Hannes Reinecke
2020-02-10 16:51 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9df9616-03c7-48bb-026a-e99cbef5ad44@samsung.com \
--to=b.zolnierkie@samsung.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).