From: Max Staudt <max@enpas.org>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-ide@vger.kernel.org, linux-m68k@vger.kernel.org,
linux-kernel@vger.kernel.org,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Michael Schmitz <schmitzmic@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH v2] ata/pata_buddha: Probe via modalias instead of initcall
Date: Thu, 25 Jul 2019 19:59:35 +0200 [thread overview]
Message-ID: <ac754751-0f51-c733-e367-a85f8cb7dbf5@enpas.org> (raw)
In-Reply-To: <a81d7a5f-c773-9769-cddd-95d2fe47d32e@enpas.org>
On 07/25/2019 07:33 PM, Max Staudt wrote:
> On 07/25/2019 07:03 PM, Bartlomiej Zolnierkiewicz wrote:
>> Please try to implement it, should be as simple as:
>>
>> static void pata_buddha_remove(struct zorro_dev *zdev)
>> {
>> struct ata_host *host = dev_get_drvdata(&zdev->dev);
>>
>> ata_host_detach(host);
>> }
>>
>> [ ata_host_alloc() in pata_buddha_probe() sets drvdata to host ]
>
> Seeing as the driver is almost 1:1 the same as pata_gayle, I see no reason against this.
>
> Do you need me to test module removal on the real machine, or is it okay to take your suggestion as-is, given that it is already accepted in pata_gayle?
Nevermind, I found a way to test it somewhat quickly. I can confirm that it works. Thanks for your suggestion!
Max
next prev parent reply other threads:[~2019-07-25 17:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 10:22 [PATCH v2] ata/pata_buddha: Probe via modalias instead of initcall Max Staudt
[not found] ` <CGME20190725170359eucas1p271187268f749869088f60bf961194169@eucas1p2.samsung.com>
2019-07-25 17:03 ` Bartlomiej Zolnierkiewicz
2019-07-25 17:33 ` Max Staudt
2019-07-25 17:59 ` Max Staudt [this message]
2019-07-25 18:01 ` John Paul Adrian Glaubitz
2019-07-29 8:53 ` Geert Uytterhoeven
2019-07-29 10:49 ` Max
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac754751-0f51-c733-e367-a85f8cb7dbf5@enpas.org \
--to=max@enpas.org \
--cc=b.zolnierkie@samsung.com \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).